Okay I think I'm done using spoiler tags for the rest of my life now.
That commit was absolutely magical.
Seriously good work. When all the HLE Zelda ucodes issues are taken care of, I expect a nice, long Dolphin article on the blog
wait, pulse wave generation? Is that a thing specific to zelda ucode (still not entirely clear as to what exactly that is) or is it a feature of the gamecube hardware? If it's the latter, I know a large group of people who might be interested in the gamecube with this information...
EDIT: While I'm being a bitch about such small things I might even touch that the "correct" name for such waves, "pulse", is technically incorrect since pulse in audio refers just to things that are 1-bit, and this usage mostly came about when it was figured out that the pulse channels on the NES were technically pulse channels, and then stuck even though the "pulse wave" channels on the NES are technically 4-bit. Their most correct name is not square or pulse, but rectangle.
Or you can go back to calling them square because, as it has been highlighted before in one of naturalviolence's many rants in the past, multiple terminologies leads to confusion. Even though square is wrong and pulse is wrong.
Oh wow that is awesome. One more-less reason to use LLE in favor of the superior performing HLE.
Now onto volume issues and maybe we can get Dolby support for HLE, afaik Dolby only works with LLE and OpenAL backend.
I believe in you devs!
Off topic: The issue I previously mentioned with the upgrade only occurs when logged in, logged out everything appears normal. It is still not fixed. It's not on my end since I disabled extensions, fully cleared my cache and cookies for dolphin-emu. It may be a Chrome specific issue and does not happen on other browsers.
@delroth
Nice.
Also might want to fix your forum user title.
@kinkinkijkin
I don't know wtf you're talking about here.
Here are the definitions for square and pulse waves:
Wikipedia entry for square wave Wrote:amplitude alternates at a steady frequency between fixed minimum and maximum values, with the same duration at minimum and maximum. The transition between minimum to maximum is instantaneous for an ideal square wave
Wikipedia entry for pulse wave Wrote:similar to a square wave, but does not have the symmetrical shape associated with a perfect square wave. It is a term common to synthesizer programming, and is a typical waveform available on many synthesizers.
Wikipedia entry for pulse wave Wrote:The pulse wave is also known as the rectangular wave, the periodic version of the rectangular function.
It's pretty much the same universal definition everywhere. Also as pointed out above rectangular and pulse waves are the same thing. They're just words that describe what the waveform pattern looks like.
okay, so, I got something wrong but you didn't catch the actual thing I got wrong (wikipedia is a bad source for anything related to audio)
square is a type of rectangle is a type of pulse is audio that can be simplified to a single bit of depth.
BUT
Pulse is technically correct to refer to squares and rectangles as the latter two are encompassed under the former. My entire 5 minutes spent writing that was wasted as what I was trying to get across was wrong.
Though, let me get to why the wikipedia entry is WRONG.
Imagine that the following represents a single-bit waveform:
1101011101100101011101000001
That waveform is technically a pulse because of the fact that it only used maximum and minimum amplitudes, which is the only actual requirement for a wave (or technically any data) to be considered a pulse. Contrary to popular belief, it does not need to be a rectangle. However, it does not need to not be a rectangle (meaning that my rant in my earlier post is very wrong).
The following is also a pulse:
1100110011001100110011001100
And it also happens to be a rectangle, and a square.
Wait, so how is it that wikipedia is wrong about this? Well, its definition of pulse makes PCM (pulse-code modulation) incorrect, but the wikipedia page on PCM treats PCM as the technically-correct term (while also throwing in that it's usually used to refer incorrectly to LPCM, but don't delude yourself into thinking that the "P" means anything but "pulse" in LPCM, since LPCM is just "Linear Pulse-Code Modulation). So, first step is that wikipedia has been found to be incredible on the definition of a pulse wave OR PCM, as it contradicts itself on them. Next, which one is wikipedia wrong about? Well, considering that the pulse wave page is the only time that it refers to the pulse and rectangle being the same thing I'm going to put my money on the small, infrequently-edited outlier being the wrong one in this case. Especially since I know personally that it is wrong.
Don't trust wikipedia.
Maybe you should stop arguing about words you don't really understand.
I know I bullshit fairly often on here, but audio is my goddamned field. I know the definition of a pulse as it applies to audio.
I stepped on a black wasp today >