understand anybody me or i'm in the wrong thread?
3D Vision patch (v2 !!)
|
10-27-2010, 10:48 AM
(10-21-2010, 05:25 PM)Uhyve Wrote: There's a slight alteration of the patch you can use here: Is there some way to reduce the amount of duplicated code in EFBTextureToD3DBackBuffer_3dVision, maybe by changing the order of the lines or adding additional isEnable3dVision checks in the original code ? The rest of the code looks fine. 10-27-2010, 06:17 PM
Hi!
I like this patch but would be gr8 if it was fixed for multiplay, because when try to activate a second remote when running in 3d mode (fullscreen) dolphin crash.. i have troubleshooted it and it only happens when having 3d enabled. 10-28-2010, 12:39 AM
(10-27-2010, 10:48 AM)skid Wrote: Is there some way to reduce the amount of duplicated code in EFBTextureToD3DBackBuffer_3dVision, maybe by changing the order of the lines or adding additional isEnable3dVision checks in the original code ? The rest of the code looks fine.I could try cleaning it up, though I just made the patch compile properly, I don't even know what most of the stuff does. Most of it looks like it could just use if statements in the normal EFBTextureToD3DBackBuffer. 10-28-2010, 09:32 AM
Yeh, I'd be happy to commit it to svn if that one criticism is resolved. I would fix it myself but I cannot use nvidia 3d vision to test it on.
Yeah... thought I understood what was going on but really, I have no idea what any of the code is doing. It's a shame that the original patch maker isn't about.
Edit: Actually... hmmm.... might be able to figure this thing out. Edit 2: Wahey, I did it. Just gonna clean it all up a bit though first, plus make sure I didn't break anything. Edit 3: Is this any better? If it's still not up to scratch, I'm fine with trying to fix things again, it was actually fun trying to decipher what goes on inside Dolphin. Edit 4: Just found out, it doesn't work with a full rebuild... Last edit I promise: Wait... it does work after all. But not when internal resolution is set to Fractional. No idea why.
Yes, the patch looks better. Fractional might be going wrong on this line:
Code: D3D::drawShadedTexQuad(read_texture,&sourcerect,Renderer::GetFullTargetWidth(),Renderer::GetFullTargetHeight(),Renderer::GetFullTargetWidth(),Renderer::GetFullTargetHeight(),PixelShaderCache::GetColorCopyProgram(SSAAMode),VertexShaderCache::GetSimpleVertexShader(0)); Double check the FullTargetWidth and FullTargetHeight stuff. Fractional should work the same as Integral. 10-28-2010, 05:38 PM
keep up the good work.. hope u find a good solution.. i look into this again when im back home on my "dolphin"computer.. strange that seems like so few playing in 3d on dolphin.. Super Mario Galaxy 2, Sport Resort and Resident Evil 4 looks amazing with 3dvision.. unfortunally Resort crashes sometimes but has nothing to do with 3dvisionpatch but maybe nvidiaboard GPUs and cpu sync.
Okay, had to re-add some parts from the original patch, which is a shame, since it was getting pretty clean looking. Everything but RealXFB works now, though that doesn't crash or anything, it's just 2D.
Link fabbex Wrote:strange that seems like so few playing in 3d on dolphinYeah, weirdly, Gamecube games are some of the best looking 3D games I've played. Though, if 3D gets official support, then I wouldn't be surprised if the 3D Vision forums pick up on it. Edit: Oh and I realized that taking 3D screenshots didn't actually work (even in the unedited plugin), so I figured I might aswell remove that code. Though, if you're using 3D vision, you can just click ALT+F1 to save a 3D screenshots to "My Documents/NVStereoscopic3D.IMG/imagename.png" anyway. |
« Next Oldest | Next Newest »
|
Users browsing this thread: 4 Guest(s)