I'm posting this here because the GitHub strangely doesn't have an issues tab (just like DuckStation, same reason?) so forgive me if I posted it in the wrong forum category.
It's been known for a while now that the Rogue Squadron games have an interesting issue with their cutscenes - whenever one starts, the game goes widescreen, and whenever it ends, it goes back to the aspect ratio you set it to. Reports say this is because the game switches back to interlaced mode.
https://imgur.com/a/smlpgjp
However, a silly little mistake on my part led me to the answer of what's going on: they're not breaking, rather it uses EFB Copies for cutscenes! I know this because 5.0-20849, which fixed the "Force 24-bit Color" option not affecting EFB Copies actually fixed discoloration during Rogue Squadron II's cutscenes, such as the intro cutscene for the night approach of Imperial Academy Heist - rainbow effects could be seen for years' worth of emulator releases, but stopped when that update released.
It turns out that the black aspect ratio bars on the bottom and top of the screen that appear during cutscenes aren't actually "real", and are the result of how the game renders cutscenes. What I presume is happening is that the game is resizing the EFB Copy-display to a certain width and height, but assumes the aspect ratio is always 4:3, meaning it fills a 16:9 screen. You can see this for yourself if you run the game in a 4:3 window:
https://imgur.com/a/gifv50w
My proposed solution to this would be to make EFB Copies respect the emulator's Aspect Ratio setting, meaning the game would only see a 4:3 part of the game window, and cutscenes wouldn't appear to break.
It's been known for a while now that the Rogue Squadron games have an interesting issue with their cutscenes - whenever one starts, the game goes widescreen, and whenever it ends, it goes back to the aspect ratio you set it to. Reports say this is because the game switches back to interlaced mode.
https://imgur.com/a/smlpgjp
However, a silly little mistake on my part led me to the answer of what's going on: they're not breaking, rather it uses EFB Copies for cutscenes! I know this because 5.0-20849, which fixed the "Force 24-bit Color" option not affecting EFB Copies actually fixed discoloration during Rogue Squadron II's cutscenes, such as the intro cutscene for the night approach of Imperial Academy Heist - rainbow effects could be seen for years' worth of emulator releases, but stopped when that update released.
It turns out that the black aspect ratio bars on the bottom and top of the screen that appear during cutscenes aren't actually "real", and are the result of how the game renders cutscenes. What I presume is happening is that the game is resizing the EFB Copy-display to a certain width and height, but assumes the aspect ratio is always 4:3, meaning it fills a 16:9 screen. You can see this for yourself if you run the game in a 4:3 window:
https://imgur.com/a/gifv50w
My proposed solution to this would be to make EFB Copies respect the emulator's Aspect Ratio setting, meaning the game would only see a 4:3 part of the game window, and cutscenes wouldn't appear to break.