Bug in the UI – malformed characters in filesize display (5.0-13988/Windows 10)

[Jendrej]

Hello.

I noticed a bug in the UI in Dolphin 5.0-13988 on Windows 10.
The filesize of a game is displayed with a diamond ? character if:

1. the file is between 1000MiB and 1024MiB
2. the language is set to a language that uses space as a thousand separator, for example Polish or Swedish.
   

This is what it looks like:

In English it is formatted as 1,010.82 MiB*.
In Polish it should be 1 010,82 MiB*.

For reference, this file is the NTSC-U Super Mario Sunshine, compressed with default settings (RVZ, block size 128KiB, Zstandard, level 5).

I tried to make an issue on the bug tracker, but it did not let me post in the UI/infrastructure section, only in the actual emulator section.

[JosJuice]

Yeah, I can see where the problem is. UICommon::FormatSize is using the system codepage on Windows. Annoying...

I'm not sure why it didn't let you post in the infrastructure section, but the infrastructure section is for things like the website, so the emulator section would actually have been the correct section.