Dolphin, the GameCube and Wii emulator - Forums
XFB fix for single-core mode - Printable Version

+- Dolphin, the GameCube and Wii emulator - Forums (https://forums.dolphin-emu.org)
+-- Forum: Dolphin Emulator Discussion and Support (https://forums.dolphin-emu.org/Forum-dolphin-emulator-discussion-and-support)
+--- Forum: Support (https://forums.dolphin-emu.org/Forum-support)
+--- Thread: XFB fix for single-core mode (/Thread-xfb-fix-for-single-core-mode)

Pages: 1 2

XFB fix for single-core mode - Luigi__ - 04-22-2009

The text homebrews take forever to load without XFB enabled. XFB only worked in dual-core mode. I did a small fix that makes it work in single-core mode as well.

I modified the Video_UpdateXFB() function in the OGL plugin (main.cpp, line 321). The changed lines are prefixed with '+++'.

Code:
void Video_UpdateXFB(u8* _pXFB, u32 _dwWidth, u32 _dwHeight, s32 _dwYOffset, bool scheduling)
{
    if (g_Config.bUseXFB && XFB_isInit())
    {
        if (scheduling) // from CPU in DC without fifo&CP (some 2D homebrews)
        {
            XFB_SetUpdateArgs(_pXFB, _dwWidth, _dwHeight, _dwYOffset);
            g_XFBUpdateRequested = TRUE;
        }
        else
        {
            if (_pXFB) // from CPU in SC mode
+++            {
                XFB_Draw(_pXFB, _dwWidth, _dwHeight, _dwYOffset);
+++                g_VideoInitialize.pCopiedToXFB();
+++            }
            else // from GP in DC without fifo&CP (some 2D homebrews)
            {
                XFB_Draw();
                g_XFBUpdateRequested = FALSE;
            }
        }
    }
}

Is it right? Or has it already been tried but dropped it didn't work?

EDIT: attached a patch. I had to upload it as a text file. Rename it to 'xfb_single_core.patch' .

RE: XFB fix for single-core mode - LuisR14 - 04-22-2009

shown better Tongue (the "[code']" bbtag shows the "[b']" bbtag as text themselves Tongue)

Quote:void Video_UpdateXFB(u8* _pXFB, u32 _dwWidth, u32 _dwHeight, s32 _dwYOffset, bool scheduling)
{
if (g_Config.bUseXFB && XFB_isInit())
{
if (scheduling) // from CPU in DC without fifo&CP (some 2D homebrews)
{
XFB_SetUpdateArgs(_pXFB, _dwWidth, _dwHeight, _dwYOffset);
g_XFBUpdateRequested = TRUE;
}
else
{
if (_pXFB) // from CPU in SC mode
{
XFB_Draw(_pXFB, _dwWidth, _dwHeight, _dwYOffset);
g_VideoInitialize.pCopiedToXFB();
}
else // from GP in DC without fifo&CP (some 2D homebrews)
{
XFB_Draw();
g_XFBUpdateRequested = FALSE;
}
}
}
}


RE: XFB fix for single-core mode - Luigi__ - 04-22-2009

Hmm... the new parts are now boldened, but the tabs are completely lost. I'll stick to the [code] tags, but find another way to highlight the new lines.
Anyway thank you for pointing this out! Wink

RE: XFB fix for single-core mode - LuisR14 - 04-22-2009

yea i noticed that Undecided

RE: XFB fix for single-core mode - Luigi__ - 04-23-2009

Code with tabs lost is harder to copy-paste. Because you have to manually add the tabs. Annoying when the code snippet is big.

RE: XFB fix for single-core mode - DacoTaco - 04-23-2009

OR you could just post a patch/diff file Tongue
makes it easier for us al

RE: XFB fix for single-core mode - Luigi__ - 04-23-2009

I'm so new
I don't know how to make such files. Maybe I can make them with TortoiseSVN?

RE: XFB fix for single-core mode - DacoTaco - 04-23-2009

ye you can make them with tortoiseSVN Wink
right click in the folder where the adjusted file is
tortoisesvn->create patch
the rest should be logical

RE: XFB fix for single-core mode - Luigi__ - 04-23-2009

Thank you! I just uploaded a patch.

RE: XFB fix for single-core mode - DacoTaco - 04-23-2009

(04-23-2009, 08:53 PM)Luigi__ Wrote: Thank you! I just uploaded a patch.
where did you upload the patch? :/