+- Dolphin, the GameCube and Wii emulator - Forums (https://forums.dolphin-emu.org)
+-- Forum: Dolphin Emulator Discussion and Support (https://forums.dolphin-emu.org/Forum-dolphin-emulator-discussion-and-support)
+--- Forum: Development Discussion (https://forums.dolphin-emu.org/Forum-development-discussion)
+--- Thread: Normalized analog stick input (/Thread-normalized-analog-stick-input)
Normalized analog stick input - BlueWanderer - 10-05-2016
It seems that at least for Xbox 360 controllers the input from an analog stick should be normalized. That is, for example, if I push the stick to the "corners", the magnitude should be 1 instead of square root of 2.
There are games where this is problematic that I either cannot walk in diagonal directions or cannot run in perpendicular directions.
I changed the GetState function of AnalogStick class, on the "stable" branch. There ought to be a switch for this I think, but I don't want to find out where to add it. So I guess it's a good idea for some else to deal with the repository.
Code:
void GetState(ControlState* const x, ControlState* const y)
{
ControlState yy = controls[0]->control_ref->State() - controls[1]->control_ref->State();
ControlState xx = controls[3]->control_ref->State() - controls[2]->control_ref->State();
ControlState radius = settings[SETTING_RADIUS]->value;
ControlState deadzone = settings[SETTING_DEADZONE]->value;
ControlState m = controls[4]->control_ref->State();
if (m)
{
radius *= 0.5;
}
ControlState max_a = std::max(std::abs(xx), std::abs(yy));
// Short circuit if within deadzone
// max_a == 0 check is not required if deadzone is alway non-negtive, but I don't know
if (max_a <= deadzone || max_a == 0)
{
*x = 0;
*y = 0;
}
// Scale down the value by the maximum magnitude on the current direction (distance(xx, yy) / max(abs(xx), abs(yy)))
else
{
ControlState dead_x = deadzone * (xx / max_a);
ControlState dead_y = deadzone * (yy / max_a);
xx = (xx > 0 ? xx - dead_x : xx + dead_x) / (1 - deadzone);
yy = (yy > 0 ? yy - dead_y : yy + dead_y) / (1 - deadzone);
ControlState scale = radius * max_a / std::sqrt(xx * xx + yy * yy);
*x = xx * scale;
*y = yy * scale;
}
}----
Guess I forgot to clamp the final results...
RE: Normalized analog stick input - leolam - 10-05-2016
The stable branch is pretty much out-of-date (though there haven't been huge changes to the input code since the 5.0 RCs). A real patch to the master branch would be more useful, so that people can figure out what you changed instantly
By the way, you may want to discuss this on IRC (#dolphin-dev on freenode) and maybe submit a PR?
RE: Normalized analog stick input - BlueWanderer - 10-06-2016
(10-05-2016, 09:04 PM)leolam Wrote: The stable branch is pretty much out-of-date (though there haven't been huge changes to the input code since the 5.0 RCs). A real patch to the master branch would be more useful, so that people can figure out what you changed instantlyI couldn't get the current head of master branch working
By the way, you may want to discuss this on IRC (#dolphin-dev on freenode) and maybe submit a PR?
But I located the release version of 5.0, and that function is unmodified. In the head version, only difference is "settings" renamed to "numeric_settings".I'm not an open source project guy (for example, I don't really know what a PR is _(:з)∠)_), and holiday ends tomorrow... So much I can do I think.
----
Ah, I guess PR means Pull Request. I don't know this is good to be pushed to server, for I don't know the protocols in an open source project
And there'd be a lot more work to do to make it a function.
RE: Normalized analog stick input - Aleron Ives - 10-07-2016
That's sort of the point of a pull request. You suggest a change to the other developers, then you discuss it with the other developers and make improvements until they decide the change is ready to be merged into the master branch.
RE: Normalized analog stick input - akyryz - 10-16-2016
same issue with this https://forums.dolphin-emu.org/Thread-wii-classic-controller-not-normalized
a picture showing:
RE: Normalized analog stick input - BlueWanderer - 10-19-2016
(10-07-2016, 04:22 AM)Aleron Ives Wrote: That's sort of the point of a pull request. You suggest a change to the other developers, then you discuss it with the other developers and make improvements until they decide the change is ready to be merged into the master branch.
I failed even push the change
Actually I can't login this forum for the past one week. So I post it here in case someone would like to update it.
RE: Normalized analog stick input - BlueWanderer - 10-19-2016
(10-16-2016, 06:18 AM)akyryz Wrote: same issue with this https://forums.dolphin-emu.org/Thread-wii-classic-controller-not-normalized
a picture showing:
If you have the environment you can paste my code. Classic controllers and GC controllers use the same routine.