Dolphin, the GameCube and Wii emulator - Forums
[Patch] Auto Frameskip - update page 3 - Printable Version

+- Dolphin, the GameCube and Wii emulator - Forums (https://forums.dolphin-emu.org)
+-- Forum: Dolphin Emulator Discussion and Support (https://forums.dolphin-emu.org/Forum-dolphin-emulator-discussion-and-support)
+--- Forum: Development Discussion (https://forums.dolphin-emu.org/Forum-development-discussion)
+--- Thread: [Patch] Auto Frameskip - update page 3 (/Thread-patch-auto-frameskip-update-page-3)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13


RE: [Patch] Auto Frameskip - update page 3 - Iulius - 08-24-2009

yes first post is completly outdated.

todays version (last page) should work best.

I cant imagine that its possible to improve it further.


RE: [Patch] Auto Frameskip - update page 3 - Diddy Kong - 08-24-2009

(08-24-2009, 03:43 AM)Iulius Wrote: yes first post is completly outdated.

todays version (last page) should work best.

I cant imagine that its possible to improve it further.

You won't be thinking the same thing a week from now. Smile


RE: [Patch] Auto Frameskip - update page 3 - Iulius - 08-24-2009

i tought about the auto frameskip version, not dolphin in general Wink

newest frameskip(page 8) never uses more skip than is needed and framelimit is turned off when frameskip is used.

i cant imagine how someone could get more performance out of this function as there is zero computing time wasted.


Of course dolphin can be improved by far and i hope i can help with that in future Smile


RE: [Patch] Auto Frameskip - update page 3 - Unknownforce - 08-25-2009

does the new one work correctly? cause if so u should have them commit the change to the SVN.


RE: [Patch] Auto Frameskip - update page 3 - KHRZ - 08-25-2009

Yeah, if I remember correctly SVN currently has the bugged version...


RE: [Patch] Auto Frameskip - update page 3 - DacoTaco - 08-25-2009

(08-25-2009, 01:06 AM)KHRZ Wrote: Yeah, if I remember correctly SVN currently has the bugged version...
yes it does, im waiting for a better version (final, not beta) before committing


RE: [Patch] Auto Frameskip - update page 3 - Iulius - 08-25-2009

there is a new one on page 8 or 9, but actually only 1 tried it and report.

it has more jitter in the framelimiter but at least doesn't waste computing time any more.

but i cant imagine a version with no framelimit jitter and no waste.

to do that, you need to look into the future if the game will get faster or slower, which is impossible.



so i'm not sure if this one should go in svn...people could complain because of the framelimiter...

for me, i will always use the new version as i prefer 10-20% more fps over +-5% framelimit jitter.

but that maybe doesn't count for everyone.


RE: [Patch] Auto Frameskip - update page 3 - DacoTaco - 08-25-2009

ill apply patch and commit. you know the drill by now (why ppl haven't added you to svn i dont know )

EDIT:here is a bug lol
VPS shows as 1/1 o.o

EDIT2: whats the point of these few lines?
Code:
        float VPS = (float)videoupd / t;

        VPS = waited;

        int TargetVPS = (int)(VideoInterface::TargetRefreshRate + 0.5);

        TargetVPS = no_framelimit + 1;
why assign the variables a value ...Twice


RE: [Patch] Auto Frameskip - update page 3 - Gombit - 08-25-2009

(08-25-2009, 05:36 AM)Daco Wrote: ill apply patch and commit. you know the drill by now (why ppl haven't added you to svn i dont know )

EDIT:here is a bug lol
VPS shows as 1/1 o.o

the vps 1/1 seems to be something to do with the newest revs like 4042.
with 4017. its shows 1/6

i dont know if its a bug with autofameskip or the revs.


RE: [Patch] Auto Frameskip - update page 3 - DacoTaco - 08-25-2009

(08-25-2009, 12:41 PM)Gombit Wrote:
(08-25-2009, 05:36 AM)Daco Wrote: ill apply patch and commit. you know the drill by now (why ppl haven't added you to svn i dont know )

EDIT:here is a bug lol
VPS shows as 1/1 o.o

the vps 1/1 seems to be something to do with the newest revs like 4042.
with 4017. its shows 1/6

i dont know if its a bug with autofameskip or the revs.
no idea
without the auto frameskipping patch it works fine tho