Dolphin, the GameCube and Wii emulator - Forums
[PATCH] Xenoblade: HLE audio hack fix - Printable Version

+- Dolphin, the GameCube and Wii emulator - Forums (https://forums.dolphin-emu.org)
+-- Forum: Dolphin Site (https://forums.dolphin-emu.org/Forum-dolphin-site)
+--- Forum: Dolphin Patches (Archive) (https://forums.dolphin-emu.org/Forum-dolphin-patches-archive)
+--- Thread: [PATCH] Xenoblade: HLE audio hack fix (/Thread-patch-xenoblade-hle-audio-hack-fix)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41

RE: [PATCH] Xenoblade: HLE audio hack fix - FilthyMonkey - 09-01-2011

You can run it at 30 fps with this patch. It is worth doing if your machine can handle it, as it makes things a bit smoother.

(09-01-2011, 05:59 AM)piccolo113 Wrote: Sorry for my ignorance, but I don't know what a 2600k (i know it's a processor, lol) is or how fast they come.
Sorry about that. I was confused about who I was replying to for a second. The easy way is just to try it. If it works at full speed, great. If it doesn't, well, then you would need to clock it up more. Maybe 3 gHz or so for your i7?

RE: [PATCH] Xenoblade: HLE audio hack fix - piccolo113 - 09-01-2011

(09-01-2011, 06:00 AM)FilthyMonkey Wrote: You can run it at 30 fps with this patch. It is worth doing if your machine can handle it, as it makes things a bit smoother.

(09-01-2011, 05:59 AM)piccolo113 Wrote: Sorry for my ignorance, but I don't know what a 2600k (i know it's a processor, lol) is or how fast they come.
Sorry about that. I was confused about who I was replying to for a second. The easy way is just to try it. If it works at full speed, great. If it doesn't, well, then you would need to clock it up more. Maybe 3 gHz or so for your i7?

I'm assuming this will drive up my core temp quite a bit. Wonder if my fans will handle it.

Edit: Oh, heh....I don't even know HOW to overclock it. For some reason I was thinking of using EVGA Precision to do it.....yeah, that's only for the video card.

RE: [PATCH] Xenoblade: HLE audio hack fix - anthonyli7 - 09-01-2011

(09-01-2011, 01:59 AM)FilthyMonkey Wrote: Why not just use LLE for sound if you have a machine like that, and sidestep the issue completely?

LLE still lags even for me... i mean, most normal people would notice it, but i have a very keen eye for these things (and ears Tongue) if i launch it in window mode, you can see the frames dropping from 30-29 every few seconds, and you get noticeable (for me) lag while moving around the world (feels like before i applied the 30fps patch. While using LLE i HAVE to use audio throttle otherwise there is crackling worse then HLE. Audio throttle seems to be what slows down the game to 29/30 rather then a constant 30. LLE sounds great! but that 1 frame performance dip annoys me when i have a system that should be fine running 30 fps Tongue
(09-01-2011, 02:50 AM)Mylek Wrote: AGuy:
Sounds like v3.1 it won't run on your machine and you'll have to use v3 of the hack. What kind of cpu do you have?

Anthonyli:
Do you have vsync off? Also shouldn't it run at 59.94 fps, which would be ~ 599 frames every 10s. Also did you mean you still get the issues with v3.1? that was supposed to fix the menu noise but i can see confusion since dolphin is also 3.0.

You can actually tune the fps you get with audio sync up and down by playing with period in SystemTimers.cpp at (period = period * 10000LL / 9993 * 48000 / 44100Wink If you make 9993 smaller you get higher fps, larger you get lower fps. I actually set it to run just a little bit faster already which is why that's there but I was aiming for max 59.94 with a more accurate fps counter. If it runs too fast audio sync in cutscenes starts to break.

Sorry for the double post, i'm a forum noob and don't know how to quote multible people.

Yeah vsync is off, never had that on.

In the 6856 build you uploaded, i had no weird menu sounds but obviously the game in general never ran as well as the later builds. It's not a crackling, it's sort of a high pitch sound that is played over the top of the normal sound.

As for the rest of your response, i'm sorry to say that i'm not that advanced lol, i have no idea what you are talking about Tongue can't seem to find this SystemTimers thingy lol

edit: oh look at that it just combined the posts for me... Tongue
(09-01-2011, 05:50 AM)FilthyMonkey Wrote: LLE works fine on my 2600k even at stock speed. Heck, if I turn off 'enable audio throttle', it will run overly fast at about 50 fps. In normal play, I never see the fps counter at anything other than 30 or 31 fps except during loading screens.

Also, that in game fps counter is somewhat wrong. There have been many occasions where the ingame counter says i have 29 fps but the windows counter says 30-31 and visa versa Tongue

Seems that when the in game counter switches between 30 and 31 constantly, that is a solid 30 fps. If it stays at 30 constantly, then the windows counter will be dropping to 29. When i get those 29 drops, thats when i get in game lag, with LLE or HLE audio throttle on. and as i said before, if audio throttle comes off on LLE, i get crackling worse then HLE xD not to mention LLE on these builds does some weird sound output... sounds like its in slow motion..

RE: [PATCH] Xenoblade: HLE audio hack fix - FilthyMonkey - 09-01-2011

When using LLE I suggest keeping audio throttle on, but turning off idle skipping and the frame limiter. That has lead to the best results for me, anyway.

Turning off both audio throttle and the frame limiter makes the game run at higher fps, but unnaturally fast. I've been using this to do some rough build benchmarking.

I made a couple of ICC builds with Mylek's 3.1 patch. Unlike my previous build, these have the handcoded SSE optimizations compiled in correctly. With rough testing, these builds are eight to ten percent faster on my machine than a VC++ build. Of course, your results may vary.
x64 SSE3
x64 SSE4.1

RE: [PATCH] Xenoblade: HLE audio hack fix - anthonyli7 - 09-01-2011

(09-01-2011, 08:35 AM)FilthyMonkey Wrote: When using LLE I suggest keeping audio throttle on, but turning off idle skipping and the frame limiter. That has lead to the best results for me, anyway.

Turning off both audio throttle and the frame limiter makes the game run at higher fps, but unnaturally fast. I've been using this to do some rough build benchmarking.

I made a couple of ICC builds with Mylek's 3.1 patch. Unlike my previous build, these have the handcoded SSE optimizations compiled in correctly. With rough testing, these builds are eight to ten percent faster on my machine than a VC++ build. Of course, your results may vary.
x64 SSE3
x64 SSE4.1

Hey thanks i'll give that a try Wink

edit: Ok so i tried the SSE4.1 build first... and im just wondering, can you hear how vastly different the sound is on LLE? even just going off the title screen between HLE and LLE it's totally different. LLE is deeper and a bit slower... hmm. I'm gonna have to turn on my wii and see which one is supposed to be correct xD
edit 2: well my wii says what i am hearing in HLE is correct xD not sure what im doing wrong. only heard this deep music on LLE since changing to any of the builds in this thread AFTER the original one.

RE: [PATCH] Xenoblade: HLE audio hack fix - FilthyMonkey - 09-01-2011

Mylek mentioned his patches messing with LLE, I think. If you are using LLE, you should probably be using an unpatched build.

RE: [PATCH] Xenoblade: HLE audio hack fix - anthonyli7 - 09-01-2011

(09-01-2011, 09:22 AM)FilthyMonkey Wrote: Mylek mentioned his patches messing with LLE, I think. If you are using LLE, you should probably be using an unpatched build.

Yeah but i'm pretty sure he said if you have it set to 32k, which i dont.

plus didnt you say you use LLE? xD which build do you use?

edit: ah man i am seriously getting sick of this lol. I ran into some more issues while using HLE. If anyone is at Sword Valley yet, when you decide to fight a fortress unit, if it does mega flame thrower it will just freeze your entire game. I would be happy using LLE if i could get it to stop dropping to 98% (FPS 29 / VPS 59)

I think i am just going to play on the Wii instead... xD Aliasing, here we come!

RE: [PATCH] Xenoblade: HLE audio hack fix - FilthyMonkey - 09-01-2011

I use my own builds. These are unpatched x64 r71 builds, made with ICC.
SSE 3
SSE4.1
SSE4.2
I have a 2600k, so I use the SSE4.2 one. Though honestly, the difference in performance between otherwise identical dolphin builds with differing compiler optimized SSE instruction sets is pretty minimal. The handcoded SSE optimizations in the videocommon library do make a noticeable difference though, and some of the other ICC builds I've seen around here seem to omit them. I assume this is because the define which turns them on is only set automatically when using microsoft's compiler.

RE: [PATCH] Xenoblade: HLE audio hack fix - anthonyli7 - 09-01-2011

(09-01-2011, 10:48 AM)FilthyMonkey Wrote: I use my own builds. These are unpatched x64 r71 builds, made with ICC.
SSE 3
SSE4.1
SSE4.2
I have a 2600k, so I use the SSE4.2 one. Though honestly, the difference in performance between otherwise identical dolphin builds with differing compiler optimized SSE instruction sets is pretty minimal. The handcoded SSE optimizations in the videocommon library do make a noticeable difference though, and some of the other ICC builds I've seen around here seem to omit them. I assume this is because the define which turns them on is only set automatically when using microsoft's compiler.

If you sit at the title screen in window mode. Can you see you FPS and VPS dropping by 1 and then returning to 30 / 60 constantly? as such, making your over all performance "98%"?

If not, what settings do you use? JIT or JITIL? lock threads to core? DSP LLE on thread? sorry to be a bother.. Also, sorry for hijacking the thread for a moment Tongue

RE: [PATCH] Xenoblade: HLE audio hack fix - AGuy - 09-01-2011

Edit: Looks like anthonyli7 asked a similar question right above me, too. Tongue

I've probably tried about eight different builds just to see how they all perform, and with the exception of Mylek's v3.1, they all seem to run the same. I'd love to get Mylek's v3.1 running well, though.

Despite the different builds, what are your takes on the Audio Throttle, Framelimit, Idle Skipping, and Lock Threads to Cores settings for r7719m or Mylek's v3? In the general game thread and in the Dolphin wiki I see so many different opinions on those four, but I figure it's better to ask the people who actually compile the various builds.

I believe Mylek suggested leaving Audio Throttle enabled and Framelimit off, correct? The wiki entry is the only place I've seen it suggest enabling Lock Threads to Cores.

Edit 2: I was testing the FPS with and without Idle Skipping, and leaving it off caused me to lose a few frames. I guess I'll leave that option on. Direct3D11 also caused me to lose a few frames, too.