Okay, I just took a more detailed look at the patches, got a few questions...
- Why did you decide not to install the license file on FreeeBSD?
- you added avcodec, avformat and swscale to the linked libs of the main executable, that's not particularly nice.. and shouldn't be necessary either. a) does linking against ${LIBAV_LIBRARIES} instead work as well? b) if you remove those three altogether and just set ENCODE_FRAMEDUMPS to OFF, does that work?
Hi,
(09-08-2011, 10:22 PM)neobrain Wrote: [ -> ]Okay, I just took a more detailed look at the patches, got a few questions...
- Why did you decide not to install the license file on FreeeBSD?
I've removed it because this file is already handled and installed by FreeBSD ports system (we want to avoid having the same license files installed again and again). This change is FreeBSD-related only and should not be merged back into the main branch.
(09-08-2011, 10:22 PM)neobrain Wrote: [ -> ]- you added avcodec, avformat and swscale to the linked libs of the main executable, that's not particularly nice.. and shouldn't be necessary either.
a) does linking against ${LIBAV_LIBRARIES} instead work as well?
Yes, linking is OK if I replace the 3 libs with ${LIBAV_LIBRARIES}.
(09-08-2011, 10:22 PM)neobrain Wrote: [ -> ]b) if you remove those three altogether and just set ENCODE_FRAMEDUMPS to OFF, does that work?
Yes, linking is OK too. Maybe ${LIBAV_LIBRARIES} should be added conditionally here ?
Best regards,
k, I just committed 854c4903ebf7 to the freebsd-port branch.. Could you just check if it still works okay for you so that I can merge it to master? thanks
(09-13-2011, 12:04 AM)neobrain Wrote: [ -> ]k, I just committed 854c4903ebf7 to the freebsd-port branch.. Could you just check if it still works okay for you so that I can merge it to master? thanks
Good, thanks ! I can confirm the freebsd-port branch builds and runs fine for me, so I think you can proceed to the merging
Merged as of 13ef4fc54ffa
Thanks again for your work
(09-13-2011, 04:06 PM)martymac Wrote: [ -> ]Great ! Thanks to you for having accepted my patches upstream
Following this merge, here is an updated and improved version of the port. It now reaches a state where it could hit the FreeBSD ports tree. It includes two new patches : one to link against libexecinfo, another one to provide cmake options to disable Nls, Alsa, Ao, Bluez, Portaudio, Pulseaudio if necessary. You can find the file here :
http://contribs.martymac.org/FreeBSD-ports/sandbox/dolphin-emu-3.0.r20110912-port.tgz
Note that I still need feedback on OpenGL rendering ! I'd like to check it works before adding this new port to the tree.
Best regards,
A few months ago I ran Dolphin on FreeBSD in Linux compatibility mode. (I wasn't aware of the FreeBSD port and from what I had seen of the Dolphin code I thought it would not build cleanly on FreeBSD.) It ran all right. Super Smash Bros at full speed, Pokemon Colosseum at about 2/3 speed. I don't know how it compares. The CPU isn't the fastest around, Athlon II X3 2.9 GHz. Video card is nvidia with the proprietary driver for FreeBSD. I played without sound because the Linux binaries I had compiled only had ALSA output compiled in.
Since the native FreeBSD port probably needs more testers, maybe I will give it a try one day.
Just to clarify my previous post: the Dolphin OpenGL backend was used and nvidia cg was among the libraries installed into /compat/linux
With both the FreeBSD 9.0 package and the latest port (r20130225) i'm getting similar results to martymac earlier in this thread. Software rendering and sound seem to work. With the OpenGL output, only black screen. Not a surprise, it's similar on other systems when building without Cg.
With the GLSL-master branch from early 2012 (the state this branch was in for a few months) OpenGL output appears to be functional. Super Smash Bros Melee is running at full speed and full fps.