Dolphin, the GameCube and Wii emulator - Forums

... The FreeBSD branch will get merged to master eventually

Well could the source include unistd.h so there wouldn't be an error, right? I don't know much about compilation, so I'm not sure.

.. really, don't post in a developer's area if you have no clue, thanks.

(08-28-2011, 04:51 AM)neobrain Wrote: [ -> ]Fwiw, I just committed your changes to the freebsd-port branch, see http://code.google.com/p/dolphin-emu/source/list?name=freebsd-port .

Good, thanks

(08-28-2011, 04:51 AM)neobrain Wrote: [ -> ]However, you broke at least the Windows build ;D
MemoryUtil.cpp fails to compile because unistd.h isn't available on Windows.

Damn ! Hey... that's not that bad, is it ? ;-)

Uhm.. we can't merge stuff to master if it breaks windows.. so, were you planning on fixing that? shouldn't be too hard, I just can't be bothered to look at it myself. Prolly just a matter of moving some #ifdefs around...

Hi,

(09-06-2011, 03:44 AM)neobrain Wrote: [ -> ]Uhm.. we can't merge stuff to master if it breaks windows.. so, were you planning on fixing that? shouldn't be too hard, I just can't be bothered to look at it myself. Prolly just a matter of moving some #ifdefs around...

Find here an up-to-date version of the port that should not break the Windows build (not tested though, as I am not a Windows user) :

http://contribs.martymac.org/FreeBSD-ports/sandbox/dolphin-emu-3.0.r20110823_1-port.tgz

Find also attached to this message a patch that reflects the changes to MemoryUtils.cpp since the previous version of the port (I think it should apply to your freebsd-port branch).

Best regards,

Are there any other changes to the port compared to what's in Git right now?
fwiw, actual all-in-one patches would be easier to handle than having to patch each file manually...
For now, I'll just test the MemoryUtil patch.

(09-06-2011, 10:39 PM)neobrain Wrote: [ -> ]Are there any other changes to the port compared to what's in Git right now?
fwiw, actual all-in-one patches would be easier to handle than having to patch each file manually...
For now, I'll just test the MemoryUtil patch.

Nope, it's the only change from the last patch set ; that's why I've sent it to you as a single patch

ok
With the new patch the Windows build works fine... Were you planning on submitting more changes or can I create a pull request for the branch?

(09-07-2011, 12:28 AM)neobrain Wrote: [ -> ]ok
With the new patch the Windows build works fine... Were you planning on submitting more changes or can I create a pull request for the branch?

I think you can create the pull request

The only remaining thing is OpenGL support, but *I need testers* for this, as I just don't know if it works or not (I get a black screen with sound on my laptop).

Thanks,