Dolphin, the GameCube and Wii emulator - Forums

no :p (patch isn't finished yet )

E:

(02-03-2010, 07:25 AM)James333 Wrote: [ -> ]

(02-03-2010, 04:43 AM)Xtreme2damax Wrote: [ -> ]

Code:

if (!g_Config.m_EnableAFCLoopingHack || g_Config.m_EnableAFCLoopingHack && PB.RepeatMode == 0)

well there is just a problem with that line, let me give them as examples :p

line above is equal:

so if m_EnableAFCLoopingHack is true and RepeatMode is 0 then the line above would be
which then evaluates to
which then you wouldn't get what you wanted (the AFC loop)

now if m_EnableAFCLoopingHack is false and RepeatMode is 0 then it would be
and then it would evaluate to
this time you wouldn't get the AFC loop (as expected from it being false :p)

then if m_EnableAFCLoopingHack is true and RepeatMode is not 0 then it would come out as
this time you would get it (as expected) but then

when m_EnableAFCLoopingHack is false and RepeatMode is not 0
you wouldn't get it to loop (again for the 3rd tiime, but at least it was expected :p)

so your method wouldn't work very well xD

And Why not just something like this? :


Anyway before the patch it was

So it never go to the "else" above. But making it like


and make those two
Would make it a PB.RepeatMode choise as the original coment said

hmm, thought of every possible output and that works o_o (i also found a less confusing way :p)

E: even though it has outputs that you wouldn't want it still works out as wanted :p

(02-03-2010, 08:11 PM)LuisR14 Wrote: [ -> ]well in the v2 patch i fixed the gameini :p

look carefully

Quote:if (!(g_Config.m_EnableAFCLoopingHack || g_GConfig.m_EnableAFCLoopingHack) && (PB.RepeatMode == 0))

(also look at Config.cpp/.h :p)

Yeah I figured that out..

I'm sorry, I'm just not good with coding, I need to hone my skills. I spent hours just trying to solve simple errors. At least I got most of the work completed.

So.. How we will leave it ?

I'm still working on it, I think I'm closer to working out all the quirks.

lol good luck with dolphin coding I think hacks are pointless.

Yeah, I'm trying to learn. I agree that hacks are pointless, but this is all we have until proper AFC looping can be implemented..

I modified the code a bit, can anyone tell me how to fix these errors?


Thank you.

What exactly did you do ?

By looking at your C++ decorations, the parameter lists are not matching. Better check the prototype against its declared function in the cpp file.