(02-02-2010, 07:30 PM)LuisR14 Wrote: [ -> ]took me some time to improve your patch and figure out what was wrong with ISOProperties but here's v2 of the patch :p
(also i was testing it and it seemed that ZTP was ok with it disabled o_o)
Code:
if (!(g_Config.m_EnableAFCLoopingHack || g_GConfig.m_EnableAFCLoopingHack) && (PB.RepeatMode == 0))
Is not a good idea to use && there
( or it is o.O ? ) , link just repeats "hey" if enabled
The checkbox in the Gameconfig still isn't working for me..
Also why over-complicate things when this works just fine?
Code:
if (!g_Config.m_EnableAFCLoopingHack || g_Config.m_EnableAFCLoopingHack && PB.RepeatMode == 0)
(02-03-2010, 04:43 AM)Xtreme2damax Wrote: [ -> ]The checkbox in the Gameconfig still isn't working for me..
Also why over-complicate things when this works just fine?
Code:
if (!g_Config.m_EnableAFCLoopingHack || g_Config.m_EnableAFCLoopingHack && PB.RepeatMode == 0)
Because I don't understand which comes first and which come second
And the Gameini config works fine for me
It must not be working for me because I am using different code in UCode_Zelda_Voice.cpp..
Did you say that link just continually repeats "Hey" with the current patch other than my patch?
(02-03-2010, 04:43 AM)Xtreme2damax Wrote: [ -> ]
Code:
if (!g_Config.m_EnableAFCLoopingHack || g_Config.m_EnableAFCLoopingHack && PB.RepeatMode == 0)
The line won't hook the gameini config , but get rid of the "hey" problem
Try
if ( (checkbox) && PB.RepeatMode == 0 )
And then hear the intro
With the hack enabled ( condition true ) link say "hey" all the time
With the hack disabled ( condition false) It's normal
PS: I always get confused with wich is the hack and wick isn't
I'll figure it out and post here when I fix it..
I have an idea what is wrong, let's hope that I am right.
I forgot to say , It doesn't happen when you use || instead of &&
I found this code works just as well
Code:
if (!g_Config.m_EnableAFCLoopingHack || PB.RepeatMode == 0)
However it still doesn't work for the Game/GameIniConfig..
well in the v2 patch i fixed the gameini :p
look carefully
Quote:if (!(g_Config.m_EnableAFCLoopingHack || g_GConfig.m_EnableAFCLoopingHack) && (PB.RepeatMode == 0))
(also look at Config.cpp/.h :p)
there is a compiled revision with this "loop" patch ?