Dolphin, the GameCube and Wii emulator - Forums

Full Version: Give ELF files unique game IDs
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Pages: 1 2
(01-20-2021, 05:39 PM)JosJuice Wrote: [ -> ]That is why my suggestion is the full file name including the extension Wink


Hm... Somewhere in Common, I guess? Can't think of any place that fits perfectly.

There is actually a collection of has functions under Common/Hash.cpp. If there are no objections I'll just add mine.
(01-21-2021, 04:05 AM)cbartondock Wrote: [ -> ]There is actually a collection of has functions under Common/Hash.cpp. If there are no objections I'll just add mine.

So it seems setting m_game_id in Common/UICommon/GameFile.cpp is insufficient to get the ID to show up in the UI. Should I be thinking about setting the title ID also? I looked in the QT code and I couldn't see anything that hard disables show ID for elf/dol files, and I even enabled the properties option on right click for elf/dol and the game id doesn't show up in it either.

Should I be thinking about setting the title_id or is there something else I am missing? Anyway I will keep fiddling.
(01-21-2021, 12:56 PM)cbartondock Wrote: [ -> ]So it seems setting m_game_id in Common/UICommon/GameFile.cpp is insufficient to get the ID to show up in the UI. Should I be thinking about setting the title ID also? I looked in the QT code and I couldn't see anything that hard disables show ID for elf/dol files, and I even enabled the properties option on right click for elf/dol and the game id doesn't show up in it either.

Should I be thinking about setting the title_id or is there something else I am missing? Anyway I will keep fiddling.

I would not suggest setting the title ID (since Dolphin tries to infer meaning from it), and I don't think it would help anyway. Try using View > Purge Game List Cache if you haven't.
(01-21-2021, 05:36 PM)JosJuice Wrote: [ -> ]I would not suggest setting the title ID (since Dolphin tries to infer meaning from it), and I don't think it would help anyway. Try using View > Purge Game List Cache if you haven't.

That did it ! Thanks so much for your help. I'll hopefully be submitting a PR for review shortly.
(01-22-2021, 01:02 AM)cbartondock Wrote: [ -> ]That did it ! Thanks so much for your help. I'll hopefully be submitting a PR for review shortly.

Submitted https://github.com/dolphin-emu/dolphin/pull/9461
Pages: 1 2