(02-20-2018, 11:47 AM)biomedical1010 Wrote: [ -> ]What are you going to do to me senpai?
Omae Wa Mou Shindeiru
But more seriously, the code is often written and commented with the assumption that the reader already has knowledge of the concepts and interfaces used. Not a beginner to the language. Then "excess" comments make it /more/ time consuming to understand. It's a fine balance between the two, and dolphin generally isn't too bad.
If you think this is a "badly" commented and poorly coded codebase, you'll be in for a surprise later
Would it be so hard if he just put a simple comment before each function to say what it's for? Why do I have to guess what each variable represents and each function does?
(02-20-2018, 05:14 AM)biomedical1010 Wrote: [ -> ]Where do I find the code for the controls? Give them to me. I don't. Care if it takes me 10 months I'll fix them.
They're buried somewhere in the EmulationFragment (
https://github.com/dolphin-emu/dolphin/blob/master/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/fragments/EmulationFragment.java) I believe.
I'm actually one of the Android UI devs degasus mentioned, he sent me your suggestions, and your tone aside, I think they're valid. I encourage you to try and hack at it yourself, but I'll also take a look to see if I can at least get transparency adjustment and control shape options working, since those are the easiest to implement. You'd be surprised how much logic goes into a a simple control overlay, since Android is actually quite clunky to deal with. I'm not sure if I'll be able to implement the joystick solution you mentioned, but there is another dev who probably can, I can ask him.
The Android codebase is also a bit of a mess, it took me quite a while to get my head around it. Also, the vast majority of functions are implementing a superclass from base Android, so you'll have to look up the corresponding Android class information.
(02-21-2018, 07:01 PM)degasus Wrote: [ -> ]https://github.com/dolphin-emu/dolphin/pull/6391
Search for "show all checks", click on the details of the android one, and download the apk.
I'm sorry but I couldn't find the android one you talked about. I checked all 6 pages of content for "android" after I searched for "show all checks" but I couldn't find anything.
That update has already been merged into the master branch, so the latest dev builds should have the changes included
(03-06-2018, 09:42 AM)addestroyer Wrote: [ -> ]That update has already been merged into the master branch, so the latest dev builds should have the changes included
I was just curious about "which variable does what" part. Do you know anywhere for me to start?
So, no need to fire @jonnyh?