Dolphin, the GameCube and Wii emulator - Forums

Yes, if it's deleting files that aren't showing up, that's a huge problem. I'll keep an eye out for it as well. Thanks for the heads up.

Thanks jmc

Hope someone can reproduce this.

trihy: Could you try PR 6161 please? https://github.com/dolphin-emu/dolphin/pull/6161

The PR merges the check and repair functions, so now any action that is actually taken is logged correctly.

@leolam, sure, but cant find pr builds here https://dl.dolphin-emu.org/prs/

There is another link?

Thanks.

Tried, made a fake save folder to trigger check nand corruption found. No warning, Hit fix, done. All saves are there but I can see that didnt delete the fake folder. Even without deleting the fake foler, now report no issues found. How is that posible?

Installed master branch build and report no issues with the folder still there. Check nand save some info and dont care anymore about that folder?

So, I created another save folder and master branch check nand report corruption, hit fix and all the saves are gone.

So, master branch kill all my saves including the fake save folder

And pr6161 doesnt kill anything, even the fake folder is still there.
.
Weird thing is that after hitting nand fix on pr6161, it wont touch a single file, but next check will report no issues found.


Log does not help:

31:23:473 WiiUtils.cpp:755 E[CORE]: CheckNAND: Missing dir C:/Users/xxxxxx/Documents/Dolphin Emulator/Wii/title/00010000/11111122//content for title 0001000011111122
31:23:473 WiiUtils.cpp:755 E[CORE]: CheckNAND: Missing dir C:/Users/xxxxxx/Documents/Dolphin Emulator/Wii/title/00010000/11111122//data for title 0001000011111122
31:23:473 WiiUtils.cpp:779 W[CORE]: CheckNAND: Missing TMD for title 0001000011111122
33:02:056 WiiUtils.cpp:779 W[CORE]: CheckNAND: Missing TMD for title 0001000011111122

Another one:

38:33:996 WiiUtils.cpp:743 E[CORE]: CheckNAND: Missing content directory for title 0001000053544d45
38:33:996 WiiUtils.cpp:769 W[CORE]: CheckNAND: Missing TMD for title 0001000053544d45
38:41:847 WiiUtils.cpp:743 E[CORE]: CheckNAND: Missing content directory for title 0001000053544d45
38:41:847 WiiUtils.cpp:769 W[CORE]: CheckNAND: Missing TMD for title 0001000053544d45
21:14:879 WiiUtils.cpp:755 E[CORE]: CheckNAND: Missing dir C:/Users/xxxxx/Documents/Dolphin Emulator/Wii/title/00010000/53544d45//content for title 0001000053544d45
21:14:880 WiiUtils.cpp:779 W[CORE]: CheckNAND: Missing TMD for title 0001000053544d45
21:17:063 WiiUtils.cpp:755 E[CORE]: CheckNAND: Missing dir C:/Users/xxxxx/Documents/Dolphin Emulator/Wii/title/00010000/53544d45//content for title 0001000053544d45
21:17:064 WiiUtils.cpp:779 W[CORE]: CheckNAND: Missing TMD for title 0001000053544d45

Cause it wont even delete that folder.

It's possible and perfectly valid for titles to have no TMD (*if* they also have no contents installed and no save data). This is the case with Dragon Quest X DLC titles, for example. The dummy title directory you created fits into that case.

It's why the "missing TMD" message is a Warning and not an Error

But how the first pass will show corruption and the second one no issues fou d without deleting anything?

Master branch still deletes all saves when you have an empty folder. Pr6161 wont do that.

Hmm, the PR branch actually has the correct behaviour here. There is no need to delete anything in this case. The only issue with your NAND after creating the dummy title dir, is that it is missing the content and data directories. This problem can be very simply fixed by creating these 2 directories.

If master deletes anything in the same case, that would mean there was a bug and the PR branch fixed it...

Oh, I didnt noticed that. Pr6161 creates content and data folder inside the fake save folder to "fix it" Thats why on second scan doesnt show issues.

Yes, pr6161 is doing the right thing, master is deleting every save when found a empty save folder. A totally different behavior. Do you have any conclusión on why master branch is doing that?