(07-22-2017, 11:46 AM)JonnyH Wrote: [ -> ]Can you list the games that showed bugs? Or even better, get a fifo log with a few frames that show the issue (see https://dolphin-emu.org/docs/guides/fifo and "How to record a fifo log") - it does *not* have to be on the same device, so you can record the fifo on your desktop that doesn't show the issues, but it saves me having to buy lots of games
I will look into this - you likely have Wind Waker , small black artifacts appear across the screen all the time during that game.
I can keep testing what I have and see what the requirements are to get a fifo log created.
(07-22-2017, 12:27 PM)cruise871 Wrote: [ -> ]I will look into this - you likely have Wind Waker , small black artifacts appear across the screen all the time during that game.
Where? I played the into and started a new game quickly and didn't see any issues.
Any chance you could get a screenshot or something?
What device is this? A snapdragon?
EDIT:
I've updated the PR to only use the framebuffer-fetch shader blending when dual-source blending is required, so hopefully that will avoid the corruption seen on games that don't actually use the feature (like wind waker).
I still haven't repro'd said corruption, so I suspect it's a driver bug as I can't test Qualcomm's driver (as the only adreno I have is too old to support framebuffer_fetch at all) - so it's not *fixed* as such.
(07-23-2017, 02:19 AM)JonnyH Wrote: [ -> ]Where? I played the into and started a new game quickly and didn't see any issues.
Any chance you could get a screenshot or something?
What device is this? A snapdragon?
EDIT:
I've updated the PR to only use the framebuffer-fetch shader blending when dual-source blending is required, so hopefully that will avoid the corruption seen on games that don't actually use the feature (like wind waker).
I still haven't repro'd said corruption, so I suspect it's a driver bug as I can't test Qualcomm's driver (as the only adreno I have is too old to support framebuffer_fetch at all) - so it's not *fixed* as such.
Is this PR update available from the same apk link?
I can confirm after finally locating my RE4 disc, that Mali devices are not improved at all. RE4 is still a white splotch mess.
(07-23-2017, 07:49 AM)Nintonito Wrote: [ -> ]I can confirm after finally locating my RE4 disc, that Mali devices are not improved at all. RE4 is still a white splotch mess.
Bah, I forgot to add a file and accidentally broke everything, and that build hasn't been updated since I fixed it. I'll try to kick a new build and let you know when it should be good.
(07-23-2017, 07:55 AM)JonnyH Wrote: [ -> ]Bah, I forgot to add a file and accidentally broke everything, and that build hasn't been updated since I fixed it. I'll try to kick a new build and let you know when it should be good.
Should be updated now. Sorry about that!
(07-23-2017, 08:01 AM)JonnyH Wrote: [ -> ]Should be updated now. Sorry about that!
No luck. Graphics appeared identical to before.
(07-23-2017, 09:10 AM)Nintonito Wrote: [ -> ]No luck. Graphics appeared identical to before.
Really? Interesting - there *should* be a clear difference, as I accidently disabled all blending for that previous build.
If it looks the same, I guess that means that framebuffer_fetch on arm just isn't working at all.
Are there any failed shader compliations? It should PanicAlert (and show a toast at the bottom of the screen), and put a "bad_ps_{number}.txt" or "bad_vs_{number}.txt" in /sdcard/dolphin-emu/Dump.
If so, any chance you could attach those bad_* files?
EDIT:
I noticed you made another thread saying Mali was just completely broken - was that on master? Maybe we're hitting some other bug, and this is just changing the visible result of that bug slightly?
(07-23-2017, 09:13 AM)JonnyH Wrote: [ -> ]Really? Interesting - there *should* be a clear difference, as I accidently disabled all blending for that previous build.
If it looks the same, I guess that means that framebuffer_fetch on arm just isn't working at all.
Are there any failed shader compliations? It should PanicAlert (and show a toast at the bottom of the screen), and put a "bad_ps_{number}.txt" or "bad_vs_{number}.txt" in /sdcard/dolphin-emu/Dump.
If so, any chance you could attach those bad_* files?
EDIT:
I noticed you made another thread saying Mali was just completely broken - was that on master? Maybe we're hitting some other bug, and this is just changing the visible result of that bug slightly?
That was on this build. That was with GPU texture Decoding enabled though, which i disabled when testing RE4. Also no bad shader compilations came up.