09-23-2009, 10:54 AM
09-24-2009, 11:08 PM
(09-23-2009, 01:16 AM)Xtreme2damax Wrote: [ -> ]I already mentioned what was wrong, in the revision prior to 4063 which was 4062 the Zelda Bloom hack was not needed for this game and the attack effects were visible.
Revision 4063 broke the graphics for this game, so now the Zelda Bloom hack is needed to see any kind of graphics and the attack effects are completely invisible.
This wasn't a problem in any of the revisions prior to 4063, now this has been an issue since revision 4063.
Also the Bloom hack or any of the projection hacks is needed for Dragonball Z Budokai Tenkaichi 2 as of revision 4063 to see any graphics, this was not needed in revisions prior to 4063 such as revision 4062 and below.
Could you try different settings, especially switch the Copy EFB methods also, you talked about DirectX, this issue also happens in the OGL plugin right ?
09-25-2009, 12:22 AM
I've already tried different settings, the same issue persists no matter which settings I try. The problem I mentioned about the projection hacks being required now and the invisible attack effects only occurs in the OpenGL plugin. This problem was created with the changes in revision 4063 and does not occur on any of the earlier revisions.
The problem with this game and the DX9 plugin is entirely different, in the screenshot I posted for this game and the DX9 plugin the colors are completely messed up, it's almost like a bad LSD trip.
I've already tried Copy EFB to Ram and Copy EFB to GL texture, which doesn't solve the problem with DBZBT3 in the OpenGL plugin. If you have this game, feel free to test this yourself since I've already tested and reported what I could.
The problem with this game and the DX9 plugin is entirely different, in the screenshot I posted for this game and the DX9 plugin the colors are completely messed up, it's almost like a bad LSD trip.
I've already tried Copy EFB to Ram and Copy EFB to GL texture, which doesn't solve the problem with DBZBT3 in the OpenGL plugin. If you have this game, feel free to test this yourself since I've already tested and reported what I could.
09-26-2009, 03:13 AM
I'v reviewed the code and most of it are checks for ini settings. can you please try deleting your config files and try again.
09-26-2009, 05:15 AM
(09-26-2009, 03:13 AM)Chaoscode Wrote: [ -> ]I'v reviewed the code and most of it are checks for ini settings. can you please try deleting your config files and try again.
No change, the issue still persists. Revision 4063 is definitely the culprit though, since revision 4062 works just fine. Every revision since 4063 has had this problem.
09-26-2009, 09:48 AM
the only graphical changes are checks in the settings config and a view port change. the view port change will not cause your issue. do a current build with out 4063 and see if its the same.
09-26-2009, 01:56 PM
I've freshly compiled all builds since this issue arose in revision 4063, this issue is present in all builds from 4063 onward, but not present in any revisions prior to 4063 so there has to be something that revision 4063 altered that caused these problems. I've thoroughly tested this and am confident that revision 4063 is indeed the culprit of this issue.
This could be caused by the changes to this file:
http://code.google.com/p/dolphin-emu/source/browse/trunk/Source/Core/VideoCommon/Src/PixelShaderManager.cpp?spec=svn4063&r=4063
or this file:
http://code.google.com/p/dolphin-emu/source/browse/trunk/Source/Plugins/Plugin_VideoOGL/Src/Render.cpp?spec=svn4063&r=4063
This issue with DBZBT3 started with revision 4063, I compiled and tested revision 4062 where this issue was not present, I then compiled and tested revision 4063 which contained this issue so I am quite certain this was the revision that broke this game.
It also seems to affect few other games as well, but I haven't thoroughly tested other games besides DBZBT3 to confirm this.
I'm not sure what more information or proof is needed to confirm the issue, I've thoroughly tested this in every possible way I can and no revision prior to 4063 exhibits this, yet every revision from 4063 onward does.
This could be caused by the changes to this file:
http://code.google.com/p/dolphin-emu/source/browse/trunk/Source/Core/VideoCommon/Src/PixelShaderManager.cpp?spec=svn4063&r=4063
or this file:
http://code.google.com/p/dolphin-emu/source/browse/trunk/Source/Plugins/Plugin_VideoOGL/Src/Render.cpp?spec=svn4063&r=4063
This issue with DBZBT3 started with revision 4063, I compiled and tested revision 4062 where this issue was not present, I then compiled and tested revision 4063 which contained this issue so I am quite certain this was the revision that broke this game.
It also seems to affect few other games as well, but I haven't thoroughly tested other games besides DBZBT3 to confirm this.
I'm not sure what more information or proof is needed to confirm the issue, I've thoroughly tested this in every possible way I can and no revision prior to 4063 exhibits this, yet every revision from 4063 onward does.
09-26-2009, 04:00 PM
so back port 4063 from a current svn and see if it fixes it like I asked. And as far as I know your the only one having the issue. I'v tested the games myself and don't have the issue.
09-26-2009, 11:44 PM
It might be caused by the change to PixelShaderManager.cpp, could you try to change back the numbers from 16777215.0f to 16777216.0f ?
Also, that's really annoying as 16777215 is meant to be the correct value for this...
Also, that's really annoying as 16777215 is meant to be the correct value for this...
09-27-2009, 03:04 AM
(09-26-2009, 11:44 PM)sl1nk3 Wrote: [ -> ]It might be caused by the change to PixelShaderManager.cpp, could you try to change back the numbers from 16777215.0f to 16777216.0f ?
Also, that's really annoying as 16777215 is meant to be the correct value for this...
I'll test that out in a bit, I've got to run somewhere.
@ChaosCode, what do you mean by backport?