(07-31-2015, 07:12 AM)ISuperMarioI Wrote: [ -> ] (07-31-2015, 07:10 AM)degasus Wrote: [ -> ]This pastie is a patch. It must be applied to the source before dolphin is compiled. So to use a patch, you have to compile the apk yourself.
So what you're saying is that I have to combine both the patch and the APK together and then I install it?
No, you need to combine the patch with the source code, which you can build an APK from.
(07-31-2015, 07:10 AM)degasus Wrote: [ -> ]This pastie is a patch. It must be applied to the source before dolphin is compiled. So to use a patch, you have to compile the apk yourself.
I figured out how to decompile the APK. Now all I need to do is to figure out where to put the patch. I'm not sure if I have to put it in a specific location or if I should put it the root of the decompiled folder.
You're headed in the entirely wrong direction! What JosJuice and degasus are saying is that you need to get the latest source code from GitHub, apply the patch to the source code (the patch degasus provided is a .diff/.patch file, use google-fu), then compile an APK from scratch using the build instructions in Source/Android/Readme.md.
(07-31-2015, 10:21 AM)OatmealDome Wrote: [ -> ]You're headed in the entirely wrong direction! What JosJuice and degasus are saying is that you need to get the latest source code from GitHub, apply the patch to the source code (the patch degasus provided is a .diff/.patch file, use google-fu), then compile an APK from scratch using the build instructions in Source/Android/Readme.md.
I 've already downloaded the .diff file degasus has sent me. The only problem is trying to figure out what kind of file the source code is in order to apply the patch.
The source code is made of .cpp, .h, .c (etc...) files, which are just like .txt files you can open in Notepad. If you look at the contents of the patch, the file that is being changed is "Source/Core/Core/PowerPC/JitArm64/JitArm64_FloatingPoint.cpp".
(07-31-2015, 06:50 AM)OatmealDome Wrote: [ -> ]Instead of just posting here in this thread, why not make bug reports on the issue tracker instead? It might be easier for the devs to keep track of them there.
Sorry for being very aggressive on pushing you all to build dolphin yourself. But there is currently no need to track random crashes. There are plenty of them, every game I've tried so far (but mkdd) had very noticeable JIT issues. So there is no need for a list with broken games.
But there is a need to check why they are broken. The usual way is to just disable random ppc instructions until you've found the single instruction which breaks the game. No coding knowlegde is required, but you need the infrastructur for compiling dolphin yourself.
eg yesterday, it took me one and a half hour to find out that the keys in xenoblade doesn't work because of this line:
https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/Core/PowerPC/JitArm64/JitArm64_Integer.cpp#L475 -- without knowing what it does. Don't worry, this was a very hard one. It usually takes half an hour
5 minutes later, fiora said "cmpli" and "gpr.GetImm(a) - inst.UIMM", that's wrong because of ...., 5 minutes later again, HdkR did provide a patch. Now I'm waiting for the PR
Edit: If you want to try it yourself, this is the patch HdkR send me:
http://hastebin.com/uhamuwotad.coffee This one was quite big, the usualy size of such patches is just
https://github.com/dolphin-emu/dolphin/commit/b7c4886d66461c3bf4831de7e7ad1081e8903f7e or
https://github.com/dolphin-emu/dolphin/commit/ec0582ee5bf290311a45c4b334bfbe218bbe7141
For compiling the source code myself, I simply gave up as I've never attempted to compile an emulator before as it is, to me, a rather complicated process. The only reason I've attempted to compile the source code in Github in the first place is simply to not only fix the crash in New Super Mario Bros. Wii when you collect a lot of coins at the same time, but to possibly fix other issues using that patch (although I'm not sure what it would fix). It may sound easy, but once I tried, it is a pain to accomplish as I'm not sure what programs are needed to apply the patch and to compile any source code. So, as of right now, I'm unable to complete this.
What ever happened to the details in the backgrounds for stages Mushroom Kingdom and Mushroom Kingdom II in Super Smash Bros. Melee (
https://www.youtube.com/watch?v=XBgimkI3QU8)? I saw those backgrounds looking fine in Kwee's builds of Dolphin Emulator for Android, but with the latest builds, they are now looking dull since they have hardly anything in the backgrounds.