Tested now some GC games, I was looking for vertical stretched ovals... to my surprise it seems that there are also horizontally stretched games like 1080 (~1,0575 PAR) and starfox assault (~1,07639 PAR) (probably Mario Kart DD too), wind waker is vertically stretched (~0,961 PAR). I attach some images. Also tested more games that seemed to be fine like Sonic Adventure 2, BG&E, F-ZeroGX (?), wave race, Mario Sunshine.
This is a proof that something odd is going on. I think the point to argue is how to accurately calculate this weird aspect ratio, and introduce a PAR option to Dolphin (DAR is bound to resolution so it's not relevant here).
Comparison here
So what do we do about it?
You opened a report on Google Code, didn't you? The devs will eventually get to it. Or if you don't want to wait, you could make a PR yourself if you know how.
I know but there's a ton of issues.
I might be able to code up a fix/partial fix depending on how involved it is. Let me look into it, never really used github before though.
phbgfj Wrote:I support a PAR ratio option that you can then input for each game's .ini (for example just as you have to for stereo convergence and depth). If the video-to-display scaling is done at Dolphin level the PAR adjustment can be done at the same step avoiding further image degradation.
Hacks to adjust things on a game by game basis is the exact
wrong way to do it! If Dolphin is doing something wrong, it is systemic, and that should be fixed so
every game is fixed, not just a few. Creating hacks for specific instances is exactly the kind of thing the developers have been
removing since 3.5, adding more will not be something any developers are interested in! Sorry, but anything following that concept is very unlikely to be merged into master.
As for what Dolphin may be doing wrong, no one is entirely sure, but many suspect that it is because Dolphin ignores scaling in the VI, similar to the
rogue squadron cutscenes problem. If you want to help fix this, the code godisgovernment pointed out in that issue would be a great place to start!
Of course that assumes that Dolphin is doing something wrong with these games in the first place. There is still a lot of doubt whether or not this is even really a problem! It would require a thorough analysis with TV Tuners and many different CRTs to really know for sure.
(07-21-2015, 02:57 AM)MaJoR Wrote: [ -> ]phbgfj Wrote:I support a PAR ratio option that you can then input for each game's .ini (for example just as you have to for stereo convergence and depth). If the video-to-display scaling is done at Dolphin level the PAR adjustment can be done at the same step avoiding further image degradation.
Hacks to adjust things on a game by game basis is the exact wrong way to do it! If Dolphin is doing something wrong, it is systemic, and that should be fixed so every game is fixed, not just a few. Creating hacks for specific instances is exactly the kind of thing the developers have been removing since 3.5, adding more will not be something any developers are interested in! Sorry, but anything following that concept is very unlikely to be merged into master.
@MaJor: Hack???! ROFL! What are you talking about. This is a damn PAR float box. Full stop. To picture how biased and hostile your post is, you completely ignored my last post yesterday (including a bunch of screenshots where the problem you don't dare to understand is exposed) and straightly went to the one I wrote 3 days ago!. At least make an effort. If you like playing with squashed (ie) SNES graphics, that's your choice. Let the rest of us play games with correct proportions, and please don't quote/write to me again, sorry but there's not much to argue with people on such mindset.
(07-21-2015, 07:16 AM)phbgjf Wrote: [ -> ]@MaJor: Hack???! ROFL! What are you talking about. This is a damn PAR float box. Full stop.
That it isn't a big hack doesn't mean that it isn't a hack. She's completely right about adjusting things on a game-by-game basis not being the Dolphin way of doing things.
The problem is that she missed the whole point of the thread. Smash Bros plays wrong (I repeat Smash Bros, not GC) and a few more titles. What she is saying is; "let's un-squash them all or do nothing instead..." now all of the sudden we come as emulation purists when emulation has always been to improve on the original experience. Disrespectful to say the least.
If this isn't clear enough... let me dumb it down. "The developers got it wrong"
It does seem fair to think it could be system wide however it seems like something you'd need to tweak on a game by game basis. Letting the user do it until every single game ever made can be tested doesn't really seem like the worst idea.