(12-26-2014, 06:41 PM)NanoByte Wrote: [ -> ] (12-25-2014, 10:25 PM)JMC47 Wrote: [ -> ]If you stand in certain spots, it will work correctly.
I have updated the code now for my changes based on the code review feedback. OGL works with zfreeze now and most of the glitches you stated earlier for RS games are gone. Mario Tennis also has no more character spikes... as for other games I'm not sure because I don't have them to test.
I think we have a good start on zfreeze and I hope we can keep progressing on solving all the zfreeze issues. 
what glitches have you corrected?
been testing rs3 what i've noticed;
doesn't like like virtual xfb (on my system anyway), screen madly flickers unless real xfb is set, get the same on rs2
only top half of screen is rendered in game and on other screens like intro logos, must be related to top half glitch on rs2, your build doesn't give me top glitch on rs2 but the one JMC47 shared does
targeting computer is corrupt but working
cockpit view works fine
pause menu works fine
sound garbled like rs2 in hle
runs very well in hle like rs2, shame about the audio
(12-26-2014, 06:56 PM)slarlac249 Wrote: [ -> ]what glitches have you corrected?
been testing rs3 what i've noticed;
doesn't like like virtual xfb (on my system anyway), screen madly flickers unless real xfb is set, get the same on rs2
only top half of screen is rendered in game and on other screens like intro logos, must be related to top half glitch on rs2, your build doesn't give me top glitch on rs2 but the one JMC47 shared does
targeting computer is corrupt but working
cockpit view works fine
pause menu works fine
sound garbled like rs2 in hle
runs very well in hle like rs2, shame about the audio
The fixes I am working on are related to this thread's topic which is zfreeze... the goal here isn't to get RS games working 100%, the goal is to get this emulation feature developed.
zfreeze can be utilized for things like skyboxes, shadows, rendering order, etc. I am not sure all of the features zfreeze can be used for but it is problematic for a few select games.
The updated code I just did, helped fix some things in the RS games like the end cutscene in Rogue Leader Yavin mission with the death star blowing up flickering... and in Rebel Strike it fixed the half space box appearing at the beginning of the first mission... in Mario Tennis it fixed the character polygon spikes... and most importantly zfreeze now works in OGL, though sometimes it's causing different results between rendering backends.
Anyways... I'm having fun diving into this problem so hopefully we can continue to make progress on fixing zfreeze issue here... some of the stuff you mentioned are not related to zfreeze.
ah right.
are the half screen glitches i mentioned zfreeze related?
because in rs3 i started a mission and the starfield was rendered over the bottom half of the screen, or it appeared to be, changing xfb settings didn't fix it.
like with the intro logos in rs3 i get only one half of the screen rendered, like rs2, bottom is rendered fine, but top flickers from black to normal, back and fourth.
is that all zfreeze?
(12-26-2014, 07:46 PM)slarlac249 Wrote: [ -> ]ah right.
are the half screen glitches i mentioned zfreeze related?
because in rs3 i started a mission and the starfield was rendered over the bottom half of the screen, or it appeared to be, changing xfb settings didn't fix it.
like with the intro logos in rs3 i get only one half of the screen rendered, like rs2, bottom is rendered fine, but top flickers from black to normal, back and fourth.
is that all zfreeze?
Yeah I'm not sure what's causing that, it only seems to happen in D3D and in Full Screen... if you stay in windowed mode I don't get that have screen flick on the intro logo and menu screens. So I'm not so sure it is related to zfreeze because OGL doesn't do this.
Hi, NanoByte. Thanks for the zfreeze patch. I can play rs2 for christmas.
Can you upload a compiled x64 exe with the last changes?
Regards
(12-26-2014, 07:49 PM)NanoByte Wrote: [ -> ] (12-26-2014, 07:46 PM)slarlac249 Wrote: [ -> ]ah right.
are the half screen glitches i mentioned zfreeze related?
because in rs3 i started a mission and the starfield was rendered over the bottom half of the screen, or it appeared to be, changing xfb settings didn't fix it.
like with the intro logos in rs3 i get only one half of the screen rendered, like rs2, bottom is rendered fine, but top flickers from black to normal, back and fourth.
is that all zfreeze?
Yeah I'm not sure what's causing that, it only seems to happen in D3D and in Full Screen... if you stay in windowed mode I don't get that have screen flick on the intro logo and menu screens. So I'm not so sure it is related to zfreeze because OGL doesn't do this.
i get it in windowed and fullscreen, it's worse in rs3, the menu is all flickery. some stuff on the menu might use zfreeze? if you turn on the depth calculation option some things vanish from the menus like the rebel logos and spinning text wheel. (well they do for me)
(12-26-2014, 08:07 PM)beatlep Wrote: [ -> ] (12-26-2014, 08:03 PM)huntsman360 Wrote: [ -> ]Hi, NanoByte. Thanks for the zfreeze patch. I can play rs2 for christmas.
Can you upload a compiled x64 exe with the last changes?
Regards
https://dl.dolphin-emu.org/prs/
1767
menu & logos display correctly now for me in rs2, windowed. however in fullscreen, i still get top half of screen flickering black every few seconds.
menu & logos display correctly now for me in rs3, windowed. same as above.
tried the mission again, deception at destrillion, screen is rendered correctly now from the cutscene through to ingame. only weird thing i noticed was a checkerboard effect around lights sources.
could be more glitches but i only played a few mins.
(12-26-2014, 07:49 PM)NanoByte Wrote: [ -> ] (12-26-2014, 07:46 PM)slarlac249 Wrote: [ -> ]ah right.
are the half screen glitches i mentioned zfreeze related?
because in rs3 i started a mission and the starfield was rendered over the bottom half of the screen, or it appeared to be, changing xfb settings didn't fix it.
like with the intro logos in rs3 i get only one half of the screen rendered, like rs2, bottom is rendered fine, but top flickers from black to normal, back and fourth.
is that all zfreeze?
Yeah I'm not sure what's causing that, it only seems to happen in D3D and in Full Screen... if you stay in windowed mode I don't get that have screen flick on the intro logo and menu screens. So I'm not so sure it is related to zfreeze because OGL doesn't do this.
Nanobyte since it happens in d3d and only at fullscreen using xfb it might be related to this issue:
https://code.google.com/p/dolphin-emu/issues/detail?id=6555&can=4 .
It's a fullscreen virtual xfb issue that only happens in d3d.