(12-25-2014, 07:11 AM)NanoByte Wrote: [ -> ] (12-25-2014, 06:40 AM)neobrain Wrote: [ -> ]Yeah, whatever you do please don't provide .exe files to GPL-licensed software without also providing a full copy of the source-code you built that executable from. Just putting your code on GitHub would be ideal. Also nice to see more attempts at zfreeze (even if it's still not quite following my suggested methodology), albeit I couldn't actually watch the video yet due to lack of proper internet connection.
ok so does that mean I can commit my code to GitHub (I'm all setup to do that I think unless I need a special login and permissions to commit to the Dolphin Project) and people can pull that revision? Or after the code is committed I can post a zip of the build I have?
After creating an account on GitHub, go to Dolphin's github page
https://github.com/dolphin-emu/dolphin and click the Fork button on the top right hand corner. Click your own account in the pop-up. Pull down that version using git to your local. Using git, create a branch and add your patch to the branch. Commit it locally and push it to GitHub. From the GitHub page, go to the branch and click the button to create a pull request.
(12-25-2014, 07:58 AM)skidq50180 Wrote: [ -> ]After creating an account on GitHub, go to Dolphin's github page https://github.com/dolphin-emu/dolphin and click the Fork button on the top right hand corner. Click your own account in the pop-up. Pull down that version using git to your local. Using git, create a branch and add your patch to the branch. Commit it locally and push it to GitHub. From the GitHub page, go to the branch and click the button to create a pull request.
Thanks skid that helps a lot...I will get on that as soon as I get the chance! I can
(12-25-2014, 10:23 AM)NanoByte Wrote: [ -> ] (12-25-2014, 07:58 AM)skidq50180 Wrote: [ -> ]After creating an account on GitHub, go to Dolphin's github page https://github.com/dolphin-emu/dolphin and click the Fork button on the top right hand corner. Click your own account in the pop-up. Pull down that version using git to your local. Using git, create a branch and add your patch to the branch. Commit it locally and push it to GitHub. From the GitHub page, go to the branch and click the button to create a pull request.
Thanks skid that helps a lot...I will get on that as soon as I get the chance! I can
Code committed
Pull request here:
https://github.com/dolphin-emu/dolphin/pull/1767
Was denied for build because I'm not auto-trusted (rightly so because I'm new around here!)... so do I wait until the changes are approved and the pull can be merged and auto-built, or should I post a build of this for the public so all who are interested can enjoy Rogue Squadron for an Xmas present? lol
I tested out the branch. It's pretty amazing considering that the old branch didn't work well for me on my graphics cards at all. Here, RS2/3 mostly work, Mario Tennis partially works, Mario Golf Partially works, and several EA games are affected as well.
I did quite a bit testing. It's a pretty decent zfreeze solution, even compared to phire's hacks. It's not perfect in any game afaik; but it makes quite a few work better.
(12-25-2014, 06:52 PM)JMC47 Wrote: [ -> ]I did quite a bit testing. It's a pretty decent zfreeze solution, even compared to phire's hacks. It's not perfect in any game afaik; but it makes quite a few work better.
Thanks... yeah I'm just happy I can play through the game...
This is just NeoBrain's initial implementation ported over to more recent builds, there was little extra I did to make it better... so this is just the initial step into solving more issues with zfreeze.
If you stand in certain spots, it will work correctly.
(12-25-2014, 10:25 PM)JMC47 Wrote: [ -> ]If you stand in certain spots, it will work correctly.
I have updated the code now for my changes based on the code review feedback. OGL works with zfreeze now and most of the glitches you stated earlier for RS games are gone. Mario Tennis also has no more character spikes... as for other games I'm not sure because I don't have them to test.
I think we have a good start on zfreeze and I hope we can keep progressing on solving all the zfreeze issues.