Since at least 3.5 and continuing to 4.0-2799, I've been seeing some nasty bloom effects that I just realized are broken in EFB to texture mode (i.e. artifacts disappear in EFB to RAM mode). Since the performance of the latter is crummy, is there any hope of fixing this?
See attached scren shots. Specifically, the "streaking" visible in the first (EFB to texture) which is not present in the second (EFB to RAM). This happens with at least RO7E7D and G6SE7D any time this sort of bloom effect is present at particular camera angles (usually, when the effect is brighter). Since realizing the cause, I've also noticed (in 3.5) that some effects are also missing.
(The blown colors, visible in both, are a separate issue, possibly due to bad FPU emulation; see
https://forums.dolphin-emu.org/Thread-fa...pid=337258 for possible details, although the issue there isn't quite the same as it has to do with fog-related calculations, which these aren't. This - the blown colors, not the EFB issue - is also a regression since 3.5. Also likely a separate issue, the bloom effect disappears
entirely when loading a save state.)
p.s. no FIFO possible for this (not sure though if it would be useful or not) until dolphin can save it without crashing...
(09-01-2014, 02:25 PM)triad Wrote: [ -> ]Since at least 3.5 and continuing to 4.0-2799, I've been seeing some nasty bloom effects that I just realized are broken in EFB to texture mode (i.e. artifacts disappear in EFB to RAM mode). Since the performance of the latter is crummy, is there any hope of fixing this?
See attached scren shots. Specifically, the "streaking" visible in the first (EFB to texture) which is not present in the second (EFB to RAM). This happens with at least RO7E7D and G6SE7D any time this sort of bloom effect is present at particular camera angles (usually, when the effect is brighter). Since realizing the cause, I've also noticed (in 3.5) that some effects are also missing.
(The blown colors, visible in both, are a separate issue, possibly due to bad FPU emulation; see https://forums.dolphin-emu.org/Thread-fa...pid=337258 for possible details, although the issue there isn't quite the same as it has to do with fog-related calculations, which these aren't. This - the blown colors, not the EFB issue - is also a regression since 3.5. Also likely a separate issue, the bloom effect disappears entirely when loading a save state.)
p.s. no FIFO possible for this (not sure though if it would be useful or not) until dolphin can save it without crashing...
Hey, thanks Triad I think I would you like to confirm an issue I've tracked it down to a specific revision. You are one of a few to have reported the problem so having confirmation would be great.
I'm at least hopeful it's the same issue here, seems very likely.
Here we go: it seems to be from the merge of "efb2tex_alpha" in revision 4.0-418.
Edit: here is a link:
https://dolphin-emu.org/download/dev/7d5...950b837c9/
And here is the last working version:
https://dolphin-emu.org/download/dev/0a3...a26a0943b/
(09-12-2014, 02:08 AM)zephyrsurfer Wrote: [ -> ]Hey, thanks Triad I think I would you like to confirm an issue I've tracked it down to a specific revision. You are one of a few to have reported the problem so having confirmation would be great.
I'm at least hopeful it's the same issue here, seems very likely.
Here we go: it seems to be from the merge of "efb2tex_alpha" in revision 4.0-418.
Edit: here is a link: https://dolphin-emu.org/download/dev/7d5...950b837c9/
And here is the last working version: https://dolphin-emu.org/download/dev/0a3...a26a0943b/
Assuming we're talking about the EFB "streaking" issue and not the blown colors (which is [1])... alas, I still see it in 0a31255. It's there in 3.5 also, so it's been around a while. (This might also be a mesa bug, though.)
1:
https://forums.dolphin-emu.org/Thread-fa...e6l?page=3
(09-12-2014, 12:00 PM)triad Wrote: [ -> ]Assuming we're talking about the EFB "streaking" issue and not the blown colors (which is [1])... alas, I still see it in 0a31255. It's there in 3.5 also, so it's been around a while. (This might also be a mesa bug, though.)
1: https://forums.dolphin-emu.org/Thread-fa...e6l?page=3
No about the colour not the streaking. Damn, well more issues. G'luck with them
(09-12-2014, 12:42 PM)zephyrsurfer Wrote: [ -> ] (09-12-2014, 12:00 PM)triad Wrote: [ -> ]Assuming we're talking about the EFB "streaking" issue and not the blown colors (which is [1])... alas, I still see it in 0a31255. It's there in 3.5 also, so it's been around a while. (This might also be a mesa bug, though.)
1: https://forums.dolphin-emu.org/Thread-fa...e6l?page=3
No about the colour not the streaking. Damn, well more issues. G'luck with them
As far as the color, see the other thread... I bisected it down to a range of six commits (but not circa the ones you mentioned; I didn't see the color issue in either of those). I haven't been able to narrow it down further because within that range other things break also such that the effects that would otherwise allow me to check if the issue is or isn't present are just missing entirely.
* sigh *
For the GOD sake, could you *please* stop referring to games by their IDs? Use game's names, not IDs.
(yes, I know that is offopic, but it's not the first time you do that -- every time I visit a thread created by you I need to search that damn game IDs to know of what game you're talking about )
Sooo... I noticed something else that might be relevant. If I sit in the graphics options dialog and (while a game is running) flip EFB back and forth between RAM and Texture, there is a delayed reaction when switching to Texture before it gets "fully" wonky. As if whatever is holding the EFB is not being cleared correctly?
Still trying to figure this out.
Something else I noticed while looking closely at the EFB dumps... it looks like the game produces two EFB's (149, 150) which rougly bisect the screen horizontally. These are then assembled into a third (whose dimensions are exactly the sum of the first two).
In the case of EFB to RAM, this works about as one would expect (119). In EFB to Texture, however, it seems that the second input EFB is just lost, and the bottom of the first is stretched to fill the space where it should be (151). In fact, is you look closely, you can see that the bottom row of 151 looks like the bottom row of 149, with the rows where 149 should be repeating the second-to-bottom row of 149 over and over.
I think there are actually two issues here. The above is the larger issue. The previously mentioned "delayed reaction" appears to be a separate issue when using non-(multiple-of-)native internal resolution... I do see some other issues with EFB to RAM in that case also, and it may be that they're interacting in a way that compounds things. While it would be nice to fix both, the latter is obviously more excusable and has a work-around.
Very interesting findings triad.
Can you tell me when it used to work??
(11-23-2014, 09:28 AM)zephyrsurfer Wrote: [ -> ]Can you tell me when it used to work??
3.5 is the earliest version of Dolphin I've ever used, and has the same issue. It's been like this for quite some time.
Something else I noticed... after patching the fog code so that the colors aren't so out of whack, take a close look at these two EFB dumps... even in the top half where it hasn't gone completely bonkers, there is a noticeable difference between RAM and Texture...