(08-13-2014, 08:27 AM)TurboK Wrote: [ -> ] (08-13-2014, 06:36 AM)purpasmart96 Wrote: [ -> ]You guys need to download the Windows 8.1 libraries, the windows 8.1 kit includes the necessary stuff for it to compile.
Tried it, the 8.1 Kit installed with no problems. The errors stayed, though, still failed to compile with VS2013.
I don't know much about compilers and if there are some settings (other than selecting "release" from the solution configuration instead of "debug") that should be checked/unchecked please tell. Dolphin master is still easy compile with default settings (gives some warnings about float/int conversions etc, but succeeds).
And if this build really dramatically changes the requirements to build (SDK's, OS, DirectX version ect) then I don't think it's worth it, unless the performance reeeally gets a huge boost. :-S
It doesn't, It compiles perfect for me, so I am going to release a binary,
Source for neobrain
https://github.com/purpasmart96/dolphin, Also I found out that the recent update to the Microsoft Visual compiler or the Windows SDK KIT broke it, Because I can't compile it anymore.
inb4 neobrain requests source
(08-13-2014, 02:40 PM)Anti-Ultimate Wrote: [ -> ]inb4 neobrain requests source
Some people might think that is funny, but it's serious. If neobrain can't compile the code either, he could demand compiling instructions. And i'd agree with that, if neobrain can't compile it, 99% of the people here won't be able to either. The use of the source code is limited, if you can't get it to work for an unknown reason. That's straight against the intention of somebody who releases stuff under the GPL. Worst case scenario could even be that a used SDK is not compatible with the GPL?
That being said, i hope that you still have some time to figure out what's missing. It doesn't look like galop1n is going to take care of anything anytime soon.
So, there's a Windows 8.1 SDK. Is there a DirectX 11.1 or 11.2 SDK too? Because we know it might have to do someting with using DirectX 11.1 and the compile errors are DirectX related. Also, is there some kind of special nvidia SDK? I know that galop1n is using some developer driver from nivida.
(08-13-2014, 02:40 PM)Anti-Ultimate Wrote: [ -> ]inb4 neobrain requests source
As mimimi pointed out, I'm being serious about this for good reasons. If you continue making it out as some kind of joke, these might be your last days around this forum. If your sole intent was to point out that the source code wasn't posted, then state that in a less personally annoying way.
(08-13-2014, 03:59 PM)mimimi Wrote: [ -> ]Some people might think that is funny, but it's serious. If neobrain can't compile the code either, he could demand compiling instructions. And i'd agree with that, if neobrain can't compile it, 99% of the people here won't be able to either. The use of the source code is limited, if you can't get it to work for an unknown reason. That's straight against the intention of somebody who releases stuff under the GPL. Worst case scenario could even be that a used SDK is not compatible with the GPL?
^This. Indeed, the GPL requires source releases to be compileable out of the box without any modification to the source or build files. galop1n's original source upload did not follow this rule and I tolerated it because it was better than nothing (here's still hope he'll eventually fix up his stuff), however given that the whole point of purpasmart96's work is to get it compile without modifications and that it's a no-brainer to upload the source, I see no reason not to demand the source code here.
Hence, please edit the post with a link to the source code (do NOT add it in a followup post, that just makes things annoyingly unorganized) or I'll need to remove the binary again.
(08-13-2014, 07:40 PM)neobrain Wrote: [ -> ]As mimimi pointed out, I'm being serious about this for good reasons. If you continue making it out as some kind of joke, these might be your last days around this forum. If your sole intent was to point out that the source code wasn't posted, then state that in a less personally annoying way.
Ok, you blew things way out proportion, you're the only Dev here I know here that is hostile towards people. Lighting up. also the SOURCE HAS BEEN POSTED MULTIPLE TIMES. If you're going keep this attitude of policing people that want to contribute and/or make a harmless statement because It's not "serious" enough for you, don't surprised if people start leaving.
(08-14-2014, 01:32 PM)purpasmart96 Wrote: [ -> ] (08-13-2014, 07:40 PM)neobrain Wrote: [ -> ]As mimimi pointed out, I'm being serious about this for good reasons. If you continue making it out as some kind of joke, these might be your last days around this forum. If your sole intent was to point out that the source code wasn't posted, then state that in a less personally annoying way.
Ok, you blew things way out proportion, you're the only Dev here I know here that is hostile towards people. Lighting up. also the SOURCE HAS BEEN POSTED MULTIPLE TIMES. If you're going keep this attitude of policing people that want to contribute and/or make a harmless statement because It's not "serious" enough for you, don't surprised if people start leaving.
Sorry for being hostile, but after asking a gazillion times nicely I've become tired of people just completely ignoring license terms. If you find my attitude hostile, then consider that I might feel offended by the fact that multiple notes from my side have blatantly been ignored by you and others.
That said, please change your link to actually point to the git revision your build was created from. Just linking to some repository is ambiguous, i.e. if you pushed new changes for whatever reason I'd have no way to know what your old build has been created from. Again, all of this is what the GPL requires you to do when you fork Dolphin and distribute compiled binaries.
[/quote]
Sorry for being hostile, but after asking a gazillion times nicely I've become tired of people just completely ignoring license terms. If you find my attitude hostile, then consider that I might feel offended by the fact that multiple notes from my side have blatantly been ignored by you and others.
That said, please change your link to actually point to the git revision your build was created from. Just linking to some repository is ambiguous, i.e. if you pushed new changes for whatever reason I'd have no way to know what your old build has been created from. Again, all of this is what the GPL requires you to do when you fork Dolphin and distribute compiled binaries.
[/quote]
So I have to link every single comment I do?, that's 70 individual comments right there, forget it , at this rate whats the point? I was trying help you guys out I uploaded the source which contains all the changes I did, the only reason it wont compile is because of the MSVS2013 update 3 broke it. THE BINARY CONTAINS THE EXACT SOURCE AS ON MY GITHUB. What do you mean you "don't know"?
https://github.com/purpasmart96/dolphin/compare/dolphin-emu:master...master
Perhaps I am wrong, but I think Neobrain is requesting that every time you post a new build, you also add a link to the latest revision of the source code from which it was built. I don't think you need to post a link to every revision or in every comment. Please let's not get too defensive.
Anyway, thank you purpasmart96 for your work on this. I am looking forward to testing the latest version in 3D.
I think it's time to take a deep breath and cool down
(08-14-2014, 11:25 PM)Tomkun Wrote: [ -> ]Perhaps I am wrong, but I think Neobrain is requesting that every time you post a new build, you also add a link to the latest revision of the source code from which it was built. I don't think you need to post a link to every revision or in every comment. Please let's not get too defensive.
^ This
(08-14-2014, 06:41 PM)purpasmart96 Wrote: [ -> ]So I have to link every single comment I do?, that's 70 individual comments right there, forget it , at this rate whats the point? I was trying help you guys out I uploaded the source which contains all the changes I did, the only reason it wont compile is because of the MSVS2013 update 3 broke it. THE BINARY CONTAINS THE EXACT SOURCE AS ON MY GITHUB. What do you mean you "don't know"? https://github.com/purpasmart96/dolphin/compare/dolphin-emu:master...master
As Tomkun pointed out, I'm asking you to put a link to the particular git revision for each build that you have. That's one link per build, not 70. Example: The about dialog in your dolphin build says 1502848840, hence you link to
https://github.com/purpasmart96/dolphin/commit/15028488401354c7eb24d992f3f947b855377ce1 . As simple as that. Wasn't that hard, was it? Now please do that for your stuff correspondingly.
What do I mean with "don't know"? I mean that once you upload a new build and just link to
https://github.com/purpasmart96/dolphin/compare/dolphin-emu:master...master again, I have no simple way of knowing how to get the source for the
old build. That's why you should link to the particular revision, not to the branch (I can compile thousands of different builds from a single branch, whereas a git revision is non-ambiguous).
(08-15-2014, 12:03 AM)neobrain Wrote: [ -> ]As Tomkun pointed out, I'm asking you to put a link to the particular git revision for each build that you have. That's one link per build, not 70. Example: The about dialog in your dolphin build says 1502848840, hence you link to https://github.com/purpasmart96/dolphin/commit/15028488401354c7eb24d992f3f947b855377ce1 . As simple as that. Wasn't that hard, was it? Now please do that for your stuff correspondingly.
What do I mean with "don't know"? I mean that once you upload a new build and just link to https://github.com/purpasmart96/dolphin/compare/dolphin-emu:master...master again, I have no simple way of knowing how to get the source for the old build. That's why you should link to the particular revision, not to the branch (I can compile thousands of different builds from a single branch, whereas a git revision is non-ambiguous).
Then you should close Tino's thread aswell since he doesn't do that either. He just uploads the builds to mega without any notice what commit they actually are.