Dolphin, the GameCube and Wii emulator - Forums

(08-11-2009, 10:48 PM)mo27772mo Wrote: [ -> ]

(08-11-2009, 10:23 PM)Dantee Wrote: [ -> ]

(08-11-2009, 06:14 PM)jasong Wrote: [ -> ]Pls, pls someone patch this in and upload it...

Patch the dolphin and upload for us, please.

http://cid-ec92aae47a89073b.skydrive.live.com/self.aspx/Emulation/Dolphin/Dolphin-r3960.7z

Thanks

(08-12-2009, 12:35 AM)Unknownforce Wrote: [ -> ]But in some places where I would get 60 fps, it seemed like it was still doing frame skipping...

yes it CAN happen, as when you have about 60fps, some frames will be a bit faster and some are slower.

60fps means 16,7ms per frame, but some may last only 14ms and some may last 20.

So after the slower ones (every frame above 17ms in your example), there will be skip.


i could add a minimum to avoid that.

for example : frame must be 10% slower then it should be before next is skipped.

But that depends a lot on the game...mario sunshine for example seems to have "super frames" which last nearly 50% longer then the other frames.

also adding a minimum would result in lower gamespeed then the desired value, because it accepts those slow frames.


Thats main reason why i have not done it.

Quote:How exactly does it work as far as the settings go?

it checks if a frame is too late and if yes skips the next.

it stops either when enough frames have been skipped, so that the timelimit has been reached or when your set maximum number of frames have been skipped in a row.

Quote:this patch needs to have an option like always
off , auto , and then the numbers of frameskip (1,2,3,4,..,9)

why ?

off is 0

on is 1-9 and also sets the maximum.

who needs another off/on ?


also : frameskip x in auto mode works NEVER worse then frameskip x without auto mode.

It works the same when the full frameskip is needed and it works better if less is needed.

so there is also no need to turn off the auto mode.





edit : one more thing.

some games have build in frameskip, for example SSBB.

Using dolphin frameskip together with framelimit cannot work with those games, for obvious reasons : it still uses game-specific frameskip, so the whole timing is wrong.

maybe metroid also uses that ?

(08-13-2009, 12:07 AM)Iulius Wrote: [ -> ]

(08-12-2009, 12:35 AM)Unknownforce Wrote: [ -> ]But in some places where I would get 60 fps, it seemed like it was still doing frame skipping...

yes it CAN happen, as when you have about 60fps, some frames will be a bit faster and some are slower.

60fps means 16,7ms per frame, but some may last only 14ms and some may last 20.

So after the slower ones (every frame above 17ms in your example), there will be skip.


i could add a minimum to avoid that.

for example : frame must be 10% slower then it should be before next is skipped.

But that depends a lot on the game...mario sunshine for example seems to have "super frames" which last nearly 50% longer then the other frames.

also adding a minimum would result in lower gamespeed then the desired value, because it accepts those slow frames.


Thats main reason why i have not done it.

Quote:How exactly does it work as far as the settings go?

it checks if a frame is too late and if yes skips the next.

it stops either when enough frames have been skipped, so that the timelimit has been reached or when your set maximum number of frames have been skipped in a row.

Quote:this patch needs to have an option like always
off , auto , and then the numbers of frameskip (1,2,3,4,..,9)

why ?

off is 0

on is 1-9 and also sets the maximum.

who needs another off/on ?


also : frameskip x in auto mode works NEVER worse then frameskip x without auto mode.

It works the same when the full frameskip is needed and it works better if less is needed.

so there is also no need to turn off the auto mode.

a, so if i set frameskip to 5 the auto will try and balance it somewhere around 5? :/ ?

if you set it to 5, auto will use a maximum of 5 skips in a row, but if the game is allready fast enough, it will use less.

keep in mind that it only works with framelimit.

if you dont set a framelimit, auto mode cannot know if the game is already fast enough.

(auto frameskip does not work correct in most cases !)

OK I tested this again last night, and unless I applied the wrong patch.. (got it from the 3rd page, second link not the first one, besides it's called autoframeskip-final.patch, pretty sure that's the only one you called that...) it doesn't seem to work for me, if I set frame limit to 60, and set frameskip to 1, the most fps I get is 30. Which is the case without this patch, and it looks as if there is 1 frameskip happening (it's not hard to tell) in places I know I get way more than 30 fps.

So I dunno...

ok so, i applied the patch
want me to commit it or let ector give you svn access (mind that he's away atm , altho he apparently still works on dolphin and reacts on mails from/to devs )

EDIT: frame limit has to be on? D:

can't you use the default set by the game if the frame limit is off?

Quote:if I set frame limit to 60, and set frameskip to 1, the most fps I get is 30

hold a minute, fps or vps ?

thats a crucial difference, as fps defines the game speed and vps are just useless, they tell nothing. (ok they tell about the video update, but that doesnt say how many real fps you got as many of them are shown twice etc)


fps should NEVER drop with frameskip, doesnt matter how high or auto or whatever.

if they do, the game probably has build in frameskip or whatever and does not work with framelimit, as the framecounter does NOT define the gamespeed for those games.

That means auto mode cannot work with this game.

Quote:EDIT: frame limit has to be on? D:

yes, of course.

till which fps should auto mode optimize if you dont tell him ?


you could also use "auto-framelimit" but that is often wrong.

Quote:want me to commit it

im not sure...

if most users dont understand how it works, or what needs to be set even if i write it 10 times...

i'm not sure if the common downloader would understand it then...


but well, as it never works worse then full-frameskip, it would at least dont hurt anyone.

you can decide.


if you upload to svn, please also mention the new framelimit mode, as people might think its inaccurate, which it only is to increase the speed for high demending scenes.

ill commit it like it is now once ive tested it
also, if i could decently look at the patch i wouldn't have needed the questions
but im kinda crappy atm

I mean FPS. As I have Overlay FPS on so that way I can watch it all the time. I've tried it with all metroid primes, and both zelda's (ww and tp) same results on all games. frame skip always makes FPS go down, because if you set frame skip to 1, you're skipping 1 of every 2 frames. meaning the most fps you can get when you would normally get 60fps would be 30 fps, because the other 30 are skipped and the FPS counter reflects this as it should.

Now I just thought about it and I realized that there are 2 FPS counters here... there's the overlay FPS and then there's the FPS on the status bar, which I never look at cause I play full screen. Are these different?

i dont know, i never use the overlay.

i always use the one on top of the window.

Quote:frame skip always makes FPS go down, because if you set frame skip to 1, you're skipping 1 of every 2 frames. meaning the most fps you can get when you would normally get 60fps would be 30 fps

thats wrong.

skipped frames still count as frames and get added to the frame counter.

that means, if you have 60fps with 1 frameskip, the game runs as if you would have 60fps, but you only see 30 different.


but the counter cannot drop with frameskip, not for zelda(gc), impossible.

or you are still using 3949, that had some kind of bug here, if i remember right.