oh my, I just wake up and almost a complete new page.
Neobrain delroth:
If you just look at my repository history you will see that my updates to the code are regular. Just forget to push the changes last night because I was too tired, a long day at work, and have to take my children’s to bed.
I really would prefer testing and code review instead of useless critics for my posting timming.
As I already say I’m working to improve things and I will not even bother discussing things that are unrelated to improve dolphin user experience.
Reminding you that you are infringing our license is not useless. If you prefer, I could DMCA your host for illegally using our IP. Dolphin is a copyleft project, sharing your source code along with the binary is not an option. If you have time to build a binary and upload it, you have time to git push.
If you are unhappy about that, feel free to stop using our GPLv2 codebase as the basis for your fork.
delroth: again, I have a public repository, all my releases are open to see. I forget a git push because I was too tired and that is a reason to call me illegal?
I been working on dolphin for a long time, longer than most of the current developers, if you take a look at my latest changes you will see that I’m trying more and more to make things that can be merged in the future to master. If there is a problem with any developer working at his own rhythm then there is something really wrong.
Posting the source code with the binary is not optional. End of the argument. Pushing your code takes less time than building and pushing a binary.
First off, let me make clear that I have no problem at all with how you're working currently. I do however think you're having some misconceptions in what you're saying, and maybe I can clear it up a little.
(06-25-2014, 12:57 AM)Tino Wrote: [ -> ]I forget a git push because I was too tired and that is a reason to call me illegal?
I think most of delroth's harsh tone is because you previously implied that you consider license violations (which, even if it was an accident because you merely forgot pushing, still made releasing binaries illegal to begin with indeed) were not important ("useless critics"). Your lack of understanding (and instead somewhat attacking replies) as to why we care about such issues intensifies that impression.
(06-24-2014, 10:52 PM)Tino Wrote: [ -> ]I really would prefer testing and code review instead of useless critics for my posting timming.
I happily review any code which is submitted via the standard procedure, i.e. via pull requests on GitHub. If you think it's a problem that I only review such code, I can't help but disagree, and either way I have other things on my time table to work on than making code reviews a full-time job because every contributor has his/her own impressions of how to submit changes.
In other words, you gave up chances for proper code review when you decided to effectively fork off into your own emulator project.
(06-25-2014, 12:57 AM)Tino Wrote: [ -> ]I’m trying more and more to make things that can be merged in the future to master.
That's a good thing, but ultimately most of your code will remain unchanged if they keep being worked on outside of the main project. I occasionally look over the commits in your branch, but all too often I still see multiple changes being stuffed into the same commit, seemingly random choices about feature designs being made without full consideration of the consequences (e.g. DDS compression with regards to custom textures), adding stuff to your branch which
simply isn't ready for merging, dubious cleanups (cf. PixelShaderGen.cpp) which make it seem like you're intentionally trying to make the code unreadable for anyone but yourself, ....
(06-25-2014, 12:57 AM)Tino Wrote: [ -> ]If there is a problem with any developer working at his own rhythm then there is something really wrong.
There's is not a problem with developers having their "own rhythm", but what you're doing here surely enough cannot be described as "having your own rhythm". Not following any of the guidelines provided to make code review not a full-time job for other people (and generally rarely interacting with the project, unless it's about throwing code at it without discussing it with other people) is a problem of yours if you want to see your changes merged in, not ours.
Delroth: It was never an argument. The license is very clear, it was just an error.
Neobrain: I really don't see where my comments were "attacking". I was just trying to explain why I forget to push my changes.
I did not considered license violations. When dolphin was in google code my fork was part of the repository. I created a new repository to make my code public because my old repository was closed when master moved to github. Sorry if everything I do is not in good timing but the time I have free to spend in dolphin is limited and I prefer to spend it improving the code.
I don’t violate any of the standard procedures. My branch is experimental and I didn’t do any PR request because there is still a lot of work on my side to make things compatible. I did not see anything on the rules against doing experiments in your own branch. About “adding stuff to your branch which simply isn't ready for merging” again is experimental so merging some concepts to test them is not something that must worry anyone, if something bad get merged it could be reverted.
“dubious cleanups (cf. PixelShaderGen.cpp) which make it seem like you're intentionally trying to make the code unreadable for anyone but yourself” have you seen pixelshadergen.cpp is not that different from master and every line added is to optimize output and keep compatibility with dx9.
“DDS compression with regards to custom textures” custom textures give the ability to customize games, customization implies that the original behavior will be changed. So providing a tool to make customized games playable don’t seems to me as “random choices about feature designs being made without full consideration of the consequences”. In my case the consequences are that anyone can play games at full speed with hires textures. About your worry about artifacts introduced by dds, anyone that wants to play a game with hires textures at full speed is aware that artifacts can be produced, and that’s even true with png.
Yeah uhm.. whatever, I tried. Do your thing if you like, but like I said don't be surprised that we don't merge any of your code to the official project tree. If that has been your intent all along, then so be it.
Why not merge it? It could finally make your code 1000x faster, so you could make it 2048x slower
almost reported because of how bad that joke was, you're lucky that I report the 4:30 nike every night and am unsure whether or not reporting too frequently does stuff
also that I'm not that much of a dickhead to do that to the moderators who might've ignored that post by chance and just missed that headache