Dolphin, the GameCube and Wii emulator - Forums

Full Version: Why should we not remove the OpenMP option?
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Pages: 1 2 3 4 5 6 7
Quote:I think the best way to measure microstutter is to measure number of ms it takes to render a frame, and finding the 99th percentile of it after 10000 frames or so.

Yes but how would we do that? I don't know of any non-commerical apps that can do that.
We have a whole team of people fairly fluent in C++. We could just tell Billiard that he has to write a measuring program and provide us with it before he has permission to remove the option.
Yeah, this is an open source project, so end users have the right to tell devs what to do and what not to!
Well you do have the right to remove whatever the hell you want and ignore end users. But removing useful things could make the users unhappy. And at the end of the day don't you feel all warm and fuzzy inside when users thank you for your hard work (ok maybe not you since we use you as a scapegoat)?
Isn't it usually just MaMario who is used as a scapegoat?
(02-18-2013, 12:41 AM)AnyOldName3 Wrote: [ -> ]We have a whole team of people fairly fluent in C++. We could just tell Billiard that he has to write a measuring program and provide us with it before he has permission to remove the option.

Wtf, that's the worst comment I've ever seen. Anyways, I'm not well versed in the dolphin source, but I think I know of a way. in render.cpp (at least for the dx9 plugin),

Code:
#include <omp.h>
#include "FileUtil.h"
static File::IOFile s_frame_latency_file;

and in the beginning of the void Renderer::Swap function

Code:
double start = omp_get_wtime();

and in the end of the function

Code:
if (bFrameLatency)
{
    if (!s_frame_latency_file.IsOpen())
    {
        s_frame_latency_file.Open(File::GetUserPath(D_LOGS_IDX) + "frame_latency.txt", "a");
    }
    char buffer[256];
    snprintf(buffer, 256, "%ld\n", (unsigned int) (start - omp_get_wtime()) * 1000);
    s_frame_latency_file.WriteArray(buffer, strlen(buffer));
    s_frame_latency_file.Close();
}

Probably a terrible idea to do any fileio in render.cpp, and repeated opening and closing of files will cause overhead in the user experience, but this should provide accurate frame by frame time in ms.
Missing the gui in videoconfig.cpp
Quote:Isn't it usually just MaMario who is used as a scapegoat?

Scapegoat implies that they're not actually at fault for what they're being accused of.
I'm sure something isn't actually 100% his fault. For example, it isn't entirely his fault that other people thought it would be a good idea to put him in charge. We could blame the people who put him there, or just him. I don't think I've seen a single naming and shaming of his allies/supporters, meaning that he's been scapegoated for the last 1% of something only 99% his fault.
Quote:For example, it isn't entirely his fault that other people thought it would be a good idea to put him in charge.

*Points to dictatorships to show that this is poor logic*

Quote: We could blame the people who put him there, or just him. I don't think I've seen a single naming and shaming of his allies/supporters, meaning that he's been scapegoated for the last 1% of something only 99% his fault.

He didn't have any supporters. He had bystanders
its avaliable in the mac OSX and windows o.o in fact i believe it should stay because it actually improved my game performance with pokemon XD:gale of darkness
(02-16-2013, 09:23 AM)pauldacheez Wrote: [ -> ]It's not even available on OS X since Clang doesn't support OpenMP yet, and the GCC is incapable of building any of Apple's headers. >_>
Pages: 1 2 3 4 5 6 7