Can you pastebin Source/Core/DolphinWX/Src/VideoConfigDiag.cpp, Source/Core/VideoCommon/Src/VideoConfig.cpp and Source/Core/VideoCommon/Src/VideoConfig.h anywhere?
Just keep the lines between "======" and ">>>>>", but remove anything "disable textures" related.
Thanks a lot!
I'll report back later how it goes
(12-19-2012, 07:16 PM)neobrain Wrote: [ -> ] (12-19-2012, 10:17 AM)Invader Wrote: [ -> ] (12-19-2012, 08:19 AM)neobrain Wrote: [ -> ]The option served absolutely no purpose (sorry, working around the osx lighting issue doesn't count). However, lots of noobs where coming to our forums complaining about issues with lighting when "Disable lighting" was used (ofc they didn't notice they enabled that option because they just blindly took over the settings from mamario's idiotic performance guide).
So it's basically no advantages vs that pretty annoying "disadvantage" (if you can call it like that).
EDIT: Meh, misread your question. Learn how to read please, your question has already been answered 
Is it possible to make it an option that can only be changed in the ini? That seems like it could solve both problems...
tl;dr is that I have no interest in bringing the option back in any way.
I wasn't asking if you had interest in bringing it back. I was asking if it was possible... Just out of curiosity. I don't have a mac nor do I plan to buy one.
neobrain Wrote:The option served absolutely no purpose (sorry, working around the osx lighting issue doesn't count).
neobrain Wrote:So it's basically no advantages
So basically what you're saying is "the option did nothing except fix an issue, therefore there is no advantage to keeping it".
I don't think avoiding the stupidity of users should take precedence over retaining fixes for issues for which there are currently no other workarounds for.
I may not be a mac user (which is why I didn't even notice that it had been removed) but I can imagine I would be slightly ticked off if I was and it was suddenly removed for no other reason than to prevent idiots from turning it on when it's not a default option and the tooltip specifically recommends against it. Please put yourself in their shoes for a minute.
(12-20-2012, 04:42 PM)NaturalViolence Wrote: [ -> ]neobrain Wrote:The option served absolutely no purpose (sorry, working around the osx lighting issue doesn't count).
neobrain Wrote:So it's basically no advantages
So basically what you're saying is "the option did nothing except fix an issue, therefore there is no advantage to keeping it".
I don't think avoiding the stupidity of users should take precedence over retaining fixes for issues for which there are currently no other workarounds for.
I may not be a mac user (which is why I didn't even notice that it had been removed) but I can imagine I would be slightly ticked off if I was and it was suddenly removed for no other reason than to prevent idiots from turning it on when it's not a default option and the tooltip specifically recommends against it. Please put yourself in their shoes for a minute.
It also breaks things. That doesn't count as a purpose either.
The option should not have been removed until the lighting bug was fixed. It was there for a reason. "It also breaks things" is not a legitimate reason to discredit issues fixed by the option. Nearly every option in dolphin breaks at least one element of at least one game therefore nearly everything should be removed by that logic (I know there are some devs that will actually agree with that statement). Even options like LLE audio that SHOULD always be the better option since they are intended to emulate the hardware more accurately occasionally produce issues that aren't present in their overall inferior counterparts. Whether anyone wants to say it or not the only difference between something like this and something like LLE audio from the end users perspective is the number of issues resolved versus the number caused. This is why the application generally uses the most accurate settings as the default to resolve as many issues as possible out of the box but still leaves the other options in there for advanced users to fix issues that need them. LLE audio is a rare exception in that it is disabled by default only because it requires external files that can't be included with dolphin for legal reasons. Not that you don't already know this, I'm just pointing it out so that somebody else doesn't try to use "but LLE is off by default" to discredit my argument.
That isn't to say that developers shouldn't strive to reduce the spaghetti code and bloat. But please if you're going to remove something like this make sure that any bugs that the option works around are fixed first. Or better yet ask the community about it so that you don't have to deal with the backlash later on.
(12-20-2012, 06:19 PM)NaturalViolence Wrote: [ -> ]The option should not have been removed until the lighting bug was fixed. It was there for a reason. "It also breaks things" is not a legitimate reason to discredit issues fixed by the option. Nearly every option in dolphin breaks at least one element of at least one game therefore nearly everything should be removed by that logic (I know there are some devs that will actually agree with that statement). Even options like LLE audio that SHOULD always be the better option since they are intended to emulate the hardware more accurately occasionally produce issues that aren't present in their overall inferior counterparts. Whether anyone wants to say it or not the only difference between something like this and something like LLE audio from the end users perspective is the number of issues resolved versus the number caused. This is why the application generally uses the most accurate settings as the default to resolve as many issues as possible out of the box but still leaves the other options in there for advanced users to fix issues that need them. LLE audio is a rare exception in that it is disabled by default only because it requires external files that can't be included with dolphin for legal reasons. Not that you don't already know this, I'm just pointing it out so that somebody else doesn't try to use "but LLE is off by default" to discredit my argument.
That isn't to say that developers shouldn't strive to reduce the spaghetti code and bloat. But please if you're going to remove something like this make sure that any bugs that the option works around are fixed first. Or better yet ask the community about it so that you don't have to deal with the backlash later on.
:') Well said bro.
NV: Simply put, the developers are free to do whatever they like with their project. That doesn't always mean that everyone is going to like it or that it has to fit in with your rationalization of what constitutes someone being able to add or remove options. Obviously some of the developers who have posted here do not want this option included with Dolphin any longer, so there is no point in continuing to talk about it.
Closed.