On my mobile i7 ICC builds are always 1-2 FPS faster than their non-ICC counterpart. But this non-ICC build is even 2 FPS faster than 3.0-799 ICC AVX.
Tested on the file select screen of Zelda SS in 1080p 3xIR 16XAA, overclocked GT555M, HLE audio.
3.0-799 ICC AVX 22 FPS
this build 24 FPS
Not too long ago, I only got 18 FPS, so Dolphin's speed improved a lot recently.
An ICC-optimized build of this revision would most likely be even faster.
In case you couldn't find a proper solution, eventually you could force in the game.inis the use of OpenGL for "Another Code R" (in fact Dx9 still has other graphic gliches in master) and 2x IR for "A shadow's tale"
Okay, I reviewed all of the changes in the branch today and only could find and correct one issue in the OpenGL backend...
@ everyone who reported issues: We're providing builds for the branch at
http://dolphin-emu.org/download/list/efb_scaling_fixes/1/ , could you test these builds and report what commit caused your specific issue? That would help a lot at addressing the problems ASAP. Thanks again for your help
The graphical problems with "Another Code: R" and "A Shadow's Tale" are due to r 3.0-781 (Fix some fractional EFB scaling issues).
Every previous revision of this branch works well with those games.
Okay thanks a lot. Turns out I had a very critical but subtle sign issue in the new code. I fixed that one and I hope all of the issues are sorted out now.
So if any of you guys who reported issues would test again with a new build (
x64 and
x86), I'd be very happy about that
If no other issues pop up, I'll merge the branch to master this weekend.
With this new 781 build the problems of Another code R and Shadow's tale are fixed
Quote:While attempting to do some additional testing I discovered a bug in the latest efb scaling fixes build. You cannot set 4x IR. Set the IR to 4x and you can clearly see that your games are running at 1x IR. Setting IR to 3x works though.
Come on neobrain don't make me look at the source code. You probably just have an off by one issue in an array somewhere.
(11-19-2012, 03:12 PM)NaturalViolence Wrote: [ -> ]Quote:While attempting to do some additional testing I discovered a bug in the latest efb scaling fixes build. You cannot set 4x IR. Set the IR to 4x and you can clearly see that your games are running at 1x IR. Setting IR to 3x works though.
Come on neobrain don't make me look at the source code. You probably just have an off by one issue in an array somewhere.
Yeah, nice find btw. A very dumb issue, I might add. For your personal entertainment, take a look at
this switch block.
I'll fix that one issue today and merge the branch to master then. Thanks again to everyone who helped out fixing these issues!
Quote:<ShizZy> I'll give you that, your attitude [...] has resulted in some big enhancements
What is the context of this?
Quote:Yeah, nice find btw. A very dumb issue, I might add. For your personal entertainment, take a look at this switch block.
None of that makes any sense. I mean the entire logic behind it makes no sense. But the ratios are correct. So what did you do to fix it?
(11-20-2012, 09:35 AM)NaturalViolence Wrote: [ -> ]Quote:<ShizZy> I'll give you that, your attitude [...] has resulted in some big enhancements
What is the context of this?
Mostly in the context of my signature. But additionally:
Quote:<ShizZy> yo no_cluez
<no_cluez> yo
<ShizZy> I made a branch, efb-copies :O
<no_cluez> :O
<ShizZy> :O
<ShizZy> I thought youd be proud at how far I've come with Git, it's my first Git branch 
<no_cluez> ye, it's 2 am here, you shouldn't be surprised that I'm in /nocare mode... xD
<ShizZy> you're not my father
<no_cluez> ShizZy: so where are your commitz for efb-copies? 
<Squall-Le> he never made any
<Squall-Le> just a branch ;D
<no_cluez> ye, that question was kinda rhetorical :|
<ShizZy> no i made the branch and got bored ;p
<no_cluez> -.-
<Squall-Le> he means he wants you to do it noclues
<no_cluez> yeah, I already told him that I know that he wants me to do all the work
<ShizZy> lol
<ShizZy> I will not argue that I am lazy
<no_cluez> yeah, too bad for you that I'm lazy as well xD
<ShizZy> but "all the work" seems like a bit far to take it, considering I have written a pretty awesome video core already
<ShizZy> just "some of the work"
<ShizZy> turns out that multiple minds == a way better piece of software
<no_cluez> ye, that's why I'm always telling you that stuff sucks :>
<ShizZy> I'll give you that, your attitude (despite lazieness) has resulted in some big enhancements
(11-20-2012, 09:35 AM)NaturalViolence Wrote: [ -> ]Quote:Yeah, nice find btw. A very dumb issue, I might add. For your personal entertainment, take a look at this switch block.
None of that makes any sense. I mean the entire logic behind it makes no sense. But the ratios are correct. So what did you do to fix it?
7 follows 6, not 8.