With 3.0-735 I can only get 48 FPS in Sonic Adventure 2 USA [
attachment=8070] [
attachment=8071]
And with 3.0-486 I can get more than 60 FPS (fullspeed) [
attachment=8072] [
attachment=8073]
Both Tested with the same settings.
Note:The fifo busy was already merged in the git 486, Actually, the fifo busy was merged on 3.0-484.
(08-02-2012, 05:40 AM)hyperspeed Wrote: [ -> ]With 3.0-735 I can only get 48 FPS in Sonic Adventure 2 USA
And with 3.0-486 I can get more than 60 FPS (fullspeed)
Both Tested with the same settings.
Note:The fifo busy was already merged in the git 486, Actually, the fifo busy was merged on 3.0-484.
You have to offer something more than just "here is a picture and the revision I used", like actually tracking down the revision that caused the issue. That would mean using the builds from 3.0-486 to 3.0-735 (or wherever you think it started) and finding the exact one that (according to you) broke or slowed something. The developers have a lot for stuff going on, the least you can do is put in some actual effort yourself and track down the issue. There is no guarantee that anyone will ever look at your issue, but the easier you make it for someone to find the issue, the better the chances will be that it may be fixed.
(08-02-2012, 05:56 AM)Starscream Wrote: [ -> ] (08-02-2012, 05:40 AM)hyperspeed Wrote: [ -> ]With 3.0-735 I can only get 48 FPS in Sonic Adventure 2 USA
And with 3.0-486 I can get more than 60 FPS (fullspeed)
Both Tested with the same settings.
Note:The fifo busy was already merged in the git 486, Actually, the fifo busy was merged on 3.0-484.
You have to offer something more than just "here is a picture and the revision I used", like actually tracking down the revision that caused the issue. That would mean using the builds from 3.0-486 to 3.0-735 (or wherever you think it started) and finding the exact one that (according to you) broke or slowed something. The developers have a lot for stuff going on, the least you can do is put in some actual effort yourself and track down the issue. There is no guarantee that anyone will ever look at your issue, but the easier you make it for someone to find the issue, the better the chances will be that it may be fixed.
Ok, hmm the 3.0 git 687 runs at same FPS of 3.0 git 735.
Edit: 3.0 git 587 and 3.0 git 600 runs fullspeed.
(08-02-2012, 11:05 AM)delroth Wrote: [ -> ]Could you try 3.0-673 and 3.0-678?
Oh, thanks @delroth.
Ok, I tried the 3.0-673 and it runs at 60 FPS.
With 3.0-678 it runs at 48 FPS.
So, this probably just (re-)confirms that Graphics_fixes should be burned with fire.
i can provide lava in that case.
Maybe graphics_fixes should not be burned but further optimized for performance since it provides some very essential fixes for important games.
When reading the many comments within the branch during the time it was developed, merged, removed, improved and remerged there were many games mentioned which had massive errors like invisible characters before and are now fine.
If the fix cannot be improved or rewritten there should at least be an option to use it where needed, like fast mipmaps before.
You cannot go the bsnes way and not include any hacks because dolphin is by far not accurate enough to do so.
There must be a reason for these graphic_fixes being made, if it would make no sense and do nothing better than the old, faster code why was it implemented at all?
The water splash effect in super mario galaxy was mentioned to be fixed by this branch for example and most likely much more.