(07-28-2011, 11:55 AM)fagoatse Wrote: [ -> ]Well, PCSX2 has received it's own FXAA implementation and the results are surprisingly good. Works best at lower resolutions, such as 2x, maybe 3x. Performance hit is negligible. It could work across all gfx plugins in Dolphin.
The amount of code needed to implement FXAA (like in pcsx2) is what I consider "bloat".
^
you consider couple hundred LoC as "bloated" ?
i only use that much code (not counting comments) implementing FXAA3 on my project using unity3D
(07-28-2011, 06:42 PM)neobrain Wrote: [ -> ] (07-28-2011, 11:55 AM)fagoatse Wrote: [ -> ]Well, PCSX2 has received it's own FXAA implementation and the results are surprisingly good. Works best at lower resolutions, such as 2x, maybe 3x. Performance hit is negligible. It could work across all gfx plugins in Dolphin.
The amount of code needed to implement FXAA (like in pcsx2) is what I consider "bloat".
Practically it would be a great addition to the emulator and maybe trouble free compared to other anti-aliasing methods used right now (that a problem with anti-aliasing options pops up every now and then).
(07-28-2011, 11:30 PM)setya5785 Wrote: [ -> ]^
you consider couple hundred LoC as "bloated" ?
i only use that much code (not counting comments) implementing FXAA3 on my project using unity3D
I don't really feel like explaining why it's bloat, since it's pretty obvious anyway. The number of LoC isn't the only thing that matters, you should know that.
(07-29-2011, 01:04 AM)Link_to_the_past Wrote: [ -> ]Practically it would be a great addition to the emulator and maybe trouble free compared to other anti-aliasing methods used right now (that a problem with anti-aliasing options pops up every now and then).
It indeed might be better than the crap we're calling SSAA right now..
Anyway, I sure won't be the one to implement it.
Quote:Anyway, I sure won't be the one to implement it.
JUST KIDNAP RODOLFO. That will be the end of this madness.
Yeah, the SSAA gets broken, like, once a month
The PSCX2 solution is just a post-processing filter, so there shouldn't be any issues with it. Someone implement, please ^^
Quote:Yeah, the SSAA gets broken, like, once a month
Actually it's been broken since 6549. It was never fixed.