I have even yet to understand how to navigate that GIT stuff xD
(10-17-2011, 06:06 AM)StripTheSoul Wrote: [ -> ]The TAS movie stuff? But that shouldn't interfere with Dolphin's functionality as long as that feature isn't used, right?
StripTheSoul has got it in one. All of the code in r7175 gets activated only while using TAS or save states. I think it is unlikely that r7175 is causing the issue.
I have made a small change to how threads get detected in the builds below. It shouldn't make any difference, as the code only gets executed when loading/saving states, but give it a try and see if it fixes the random crash.
Win32:
http://www.mediafire.com/?mcvl5lcachnp59d
x64:
http://www.mediafire.com/?ykmxvlryikifu3f
(10-19-2011, 09:07 PM)skid Wrote: [ -> ] (10-17-2011, 06:06 AM)StripTheSoul Wrote: [ -> ]The TAS movie stuff? But that shouldn't interfere with Dolphin's functionality as long as that feature isn't used, right?
StripTheSoul has got it in one. All of the code in r7175 gets activated only while using TAS or save states. I think it is unlikely that r7175 is causing the issue.
I have made a small change to how threads get detected in the builds below. It shouldn't make any difference, as the code only gets executed when loading/saving states, but give it a try and see if it fixes the random crash.
Win32: http://www.mediafire.com/?mcvl5lcachnp59d
x64: http://www.mediafire.com/?ykmxvlryikifu3f
Thanks skidau, i will.
No, it is not fixed
. I also tried again r7173 and it seems stable while r7175 definitely has the issue. Could you revert r7175 commit to test it just to be certain that it is the cause?
EDIT: Ok, with a bit of luck i think i have fixed it and found the cause. I reverted all the changes i could that where done from that rev, and i tracked it down to the change made to Source\Core\DolphinWX\Src\Main.cpp
by r7175. But i need testing from others too so, here is a build, it should be stable(i tested smg and smg 2):
http://www.mediafire.com/?dpoelttk96au19k
Straaaaaaange...what was r7174? cuz no one ever mentioned that one...just some wiki update?
Quote:Straaaaaaange...what was r7174? cuz no one ever mentioned that one...just some wiki update?
Quote:Fix gfx dialog configuration text on the advanced page, and alphebetize the
configuration selections.
@Link_to_the_past
What exactly did you change if I may ask?
(10-20-2011, 08:56 AM)NaturalViolence Wrote: [ -> ]Quote:Straaaaaaange...what was r7174? cuz no one ever mentioned that one...just some wiki update?
Quote:Fix gfx dialog configuration text on the advanced page, and alphebetize the
configuration selections.
@Link_to_the_past
What exactly did you change if I may ask?
It was trial and error, but my guess is it has something to do with this:
* Updated the status bar and title bar when an on-screen message is shown
Btw did anyone test it to see if there are any ntdll errors any more?
So, all the random crashes are gone now or just "one kind" of random crashes?
Looks good here, but I haven't had very much time to test.
(10-23-2011, 05:38 AM)StripTheSoul Wrote: [ -> ]So, all the random crashes are gone now or just "one kind" of random crashes?
Looks good here, but I haven't had very much time to test.
The ntdll!0x776D1B70 : RtlFreeHeap type of crashes are as it seems, but crashes for other reasons are not. For example Xenoblade still randomly freezes. I wonder though what skid meant with this:
"I think it is valid to add two pending events in a row. Dolphin does this in other parts of the code too."
A similar process with what caused these crashes happens to other parts of the code too? Meh, anyway at least these ntdll crashes were very frequent, good riddance i say.
Good riddance, indeed! My testing today went pretty well
You don't really know if any crashes are fixed yet, they are random and they probably just didn't happen this time.