Dolphin, the GameCube and Wii emulator - Forums

r7167: I introduced configuration profiles in Dolphin, making a combobox for them show up in the video config dialog. Just an initial implementation with a few rough edges and not-so-clean code. Didn't have any time to work on this for a while though, so others went ahead and tried to improve my code.

r7386: Billiard revamped the config profile system by removing the combobox and instead adding an option in the context menu of the game list items which opens a separate dialog for them. Needed some cruel hacks, but it's the nicest way to go from a usuability perspective

r7391: Gnick reverted Billiard's code, re-adding the combobox from my initial implementation. He also added numerous features on top of it, making the whole thing pretty feature-complete. However, the code is just a hell of a mess now. Also, it's not as nice as Billiard's implementation.

Around r7400, I was able to spend some time on Dolphin coding again. I tried my best to clean up the current video config dialog code, but it just didn't work. Well, actually it did work out, but I realized that it's just a mess to work with, since I was planning to do some major restructuring of the video config dialog in the future.

TL;DR: Thus, I decided to revert the WHOLE video config dialog code back to pre-r7167.
Since r7484, we have the old, configuration-profile-free video config dialog again. I plan on re-adding similiar functionality in the future, but it'll be implemented similiar to what Billiard did. I do not know if it'll happen before 3.0.


This thread was created for you to complain and argue about this removal. No one managed to convince me why you'd prefer my initial/gnick's implementation. I also want to give users more insight into why I decided to do this, so go ahead and complain why you need it to be done like it was done until r7483

Interesting read on the whole affair. How long have you been planning the changes to the video config dialog for?

And interesting mention of Dolphin 3.0. I was wondering when it'd be ushered out, only to leave new people behind as they wonder why the recent changes don't work for them

Good luck. I hope youll make it even better then it was.

I agree with reverting it, hated the new implementation.

I didn't like it either. +1.

Quote:I plan on re-adding similiar functionality in the future

Thank God at least for that.

Quote:go ahead and complain why you need it to be done like it was done until r7483

Why would you need reasons for reimplementing something you created in the first place?
You obviously felt the need for this enhancement since you spend time working on it.
I'm pretty sure you already know what those reasons are.

I was referring to reimplementing the feature the way I had implemented it first. Some people weren't agreeing with the way Billiard had implemented it, but I don't see a reason what Billiard's way is missing which my implementation does offer. Apart from modifying game specific configuration during emulation, but this REALLY is something you shouldn't do anyway (if you think you need to do this, you clearly haven't grasped the sense of game specific configuration).

Quote:I was referring to reimplementing the feature the way I had implemented it first

I know.
I personally liked the original implementation, and you did too:

Quote:Add per-game "configuration profiles" for video backend configuration:
This allows ALL settings in the gfx configuration dialog to be adjusted _per
game_ in a more user-friendly way than before.

I personally still liked it best with only per-game-settings, the way it was before (well, I think it's back to that now, only that the gfx settings are missing in there).

It's funny to see so many people happy that this feature (specific game profiles) has been removed, but maybe they still don't know that now there are a lot of "hidden" game ini profiles that overwrite the default profile setting and you cannot see those settings unless you search for the specific ini file
For me "game profiles" was a great feature and I still don't understand why it was removed in this way...