Quote:Why is this not committed?
Because if the devs committed every scale that people wanted the list would get very long very fast. NeoBrain is working on a custom scale option instead that will allow to to enter in custom width/height dimensions. This probably won't be committed until after release 3.0 however due to the feature freeze.
And sorry I didn't respond sooner. I was in Washington D.C. for the weekend visiting relatives. I'm going to be pretty busy for awhile but I'll take a look at the dolphin-emu source code sometime this weekend and see if anything has changed that might break it (I doubt it, probably just an issue with tortoisesvn like squall said).
(06-01-2011, 06:50 AM)NaturalViolence Wrote: [ -> ]NeoBrain is working on a custom scale option instead that will allow to to enter in custom width/height dimensions.
Cool! Can't wait! (hope it is in 3.0 tho
)
(06-01-2011, 06:50 AM)NaturalViolence Wrote: [ -> ]I'm going to be pretty busy for awhile but I'll take a look at the dolphin-emu source code sometime this weekend and see if anything has changed that might break it (I doubt it, probably just an issue with tortoisesvn like squall said).
Hope you find what is wrong (if anything).
Also this does not break ANYthing right? (I do not think so just want to double check
) If so I will commit it to my builds.
(06-01-2011, 07:41 AM)ryancollins Wrote: [ -> ] (06-01-2011, 06:50 AM)NaturalViolence Wrote: [ -> ]NeoBrain is working on a custom scale option instead that will allow to to enter in custom width/height dimensions.
Cool! Can't wait! (hope it is in 3.0 tho)
Feature freeze, so it won't make it in 3.0.
Also note that I'm not sure if I'll finish the patch at all due to general laziness
Wait, didn't I already say that?
Quote:This probably won't be committed until after release 3.0 however due to the feature freeze.
Quote:Also this does not break ANYthing right? (I do not think so just want to double checkWink) If so I will commit it to my builds.
No. It literally just adds a 4x scale option to the list. Which is as simple as copying the code and changing the number 3 to the number 4. Like neobrain said, it would be extremely easy to do this manually instead of applying the patch if you needed to.
(06-02-2011, 05:09 AM)NaturalViolence Wrote: [ -> ]No. It literally just adds a 4x scale option to the list. Which is as simple as copying the code and changing the number 3 to the number 4. Like neobrain said, it would be extremely easy to do this manually instead of applying the patch if you needed to.
This. I applied it manually a few weeks back when it first came out and my C++ experience was extraordinarily small (nigh nonexistent) at that time. It really is a simple patch, but its benefit is great.
This has been (basically) committed as of r7669
Good. Now people can stop PMing me with stupid questions about it.
