skid, do you know if Ayuanx is still working on the FIFO or has he once again thrown around some code and left broken what's been broken?

Since his first FIFO commit ("bring out the beast") SMG2 crashes on me after 1-2 min of gameplay...I read this happens for other players as well (though strangely not for all, it seems) and also for some other games.
right now i got svn to boot the game on normal JIT,but then i loose fps

audio goes into loop.and thats it
so i miss more..
--------------------------------------------------------------
*EDIT
Thank u SKID
here is result:
updated r5807 with patch,
-game does not need Zelda hack it works at full speed in dx11 and without any graphical glitches
-it does not boot with DC on,instead use SC and idle skipping there will be no slowdowns - tested on rather old comp DC 2.6ghz
i will upload builds in few mins[
attachment=3703][
attachment=3702]
here are builds
Code:
http://rapidshare.com/files/403641926/5807-Eternal-Darkness-x64.rar.html
http://rapidshare.com/files/403644834/5807-Eternal-Darkness-x32.rar.html
(06-29-2010, 03:51 AM)StripTheSoul Wrote: [ -> ]skid, do you know if Ayuanx is still working on the FIFO or has he once again thrown around some code and left broken what's been broken? 
Since his first FIFO commit ("bring out the beast") SMG2 crashes on me after 1-2 min of gameplay...I read this happens for other players as well (though strangely not for all, it seems) and also for some other games.
Strange because I'm not getting any crashes here, do you have Use Panic Handlers unchecked in the general configuration? I would suggest unchecking Use Panic Handlers since Dolphin has a tendency to crash when an error is encountered with this option enabled. Ayuanx still needs to fix the FPS limiter (VPS) and audio throttle limiting some games such as Resident Evil Code Veronica X to the wrong speed, I really hope he fixes the things that were broken due to his commits.
(06-29-2010, 06:03 AM)IcemanSR Wrote: [ -> ]here are builds
Code:
http://rapidshare.com/files/403641926/5807-Eternal-Darkness-x64.rar.html
http://rapidshare.com/files/403644834/5807-Eternal-Darkness-x32.rar.html
Did you make any changes to the code? If so, would you please attach them so that I can review?
@ Xtreme: yeah, the crashes also occur without panic handlers...the error message in Dolphon log is:
52:37:100 .\Src\MsgHandler.cpp:53 E[*]: Warning: FIFO is overflown by GatherPipe !
CPU thread is too fast, lower the HiWatermark may help.
And it came up with Ayuanx' first big FIFO change a few weeks ago. It really sucks since SMG2 plays in pretty nice speed in recent builds...but just 1 or 2 minutes and it crashes again.
Yes ofc,sorry
but didn't changed much just line here and there,and disabled fifobusy,i am dou slowly reinstating all missing changes into code.
just don't know how to enable DC to boot the game
[color=#FF0000]uh crap svn got corrupted when i was making a patch,hmpf lemme make a new one

[/color]
-------------------------
[color=#1E90FF]Sorry added correct patch.[/color]
stupid svn got badly corrupted its ok now.
(06-29-2010, 02:06 AM)IcemanSR Wrote: [ -> ]i am having a bit of a struggle with new fifobusy it does not like your changes very much,what do u make of it?
I'll need to check this out closer. I have not fully reviewed MarcosV's patch. I did see that he used fifobusy and by first glance, fifobusy=readidle.
(06-29-2010, 03:51 AM)StripTheSoul Wrote: [ -> ]skid, do you know if Ayuanx is still working on the FIFO or has he once again thrown around some code and left broken what's been broken? 
I do not know what Ayuanx's plans are. I've put my FIFO work on hold until the FIFO codebase stabilises. I do not want to be working on a moving base.
(06-29-2010, 03:51 AM)StripTheSoul Wrote: [ -> ]Since his first FIFO commit ("bring out the beast") SMG2 crashes on me after 1-2 min of gameplay...I read this happens for other players as well (though strangely not for all, it seems) and also for some other games.
Usually stuff like that is due to multi-threaded code. The code is written to be fast. The downside is that it introduces random occurrences like this.
(06-29-2010, 07:48 AM)StripTheSoul Wrote: [ -> ]@ Xtreme: yeah, the crashes also occur without panic handlers...the error message in Dolphon log is:
52:37:100 .\Src\MsgHandler.cpp:53 E[*]: Warning: FIFO is overflown by GatherPipe !
CPU thread is too fast, lower the HiWatermark may help.
And it came up with Ayuanx' first big FIFO change a few weeks ago. It really sucks since SMG2 plays in pretty nice speed in recent builds...but just 1 or 2 minutes and it crashes again.
My guess here is the speed of your video card plays a part in these error messages because the second thread runs in-line with your video card. The differences in speed between your video card and Xtreme2damax's can explain why he is not getting any error messages while you are.
(06-29-2010, 07:58 AM)IcemanSR Wrote: [ -> ]Yes ofc,sorry
but didn't changed much just line here and there,and disabled fifobusy,i am dou slowly reinstating all missing changes into code.
just don't know how to enable DC to boot the game
Thanks, will check it out.
Please use reuploaded patch,for reasons mentioned above(svn got messy)
still can't figure out why DC won't boot the game...
----------------
edit just compared your build from first topic and this i build with latest svn,sound is perfect now,while it was grabled(voices in video's,armor sound when walking ,hitting mobs with weapon) in your version.so all is good,if u could just take a look what is the problem with damn DC mode.
skid: I thought of using readidle But ayuanx is playing with this and you discuss with him in r5709 about this. So, I preferred create my own var. I put this into the "while" but I'dont know where is better "into the while" or "outside like readIdle".
I dont know if that is the best solution but the VI depends of CPU cycles and we need to keep sync this Event schedule.