Zelda HLE Testing Wanted: Zelda ucode Cleanup Merge

[JMC47]

Zelda HLE games have long been the odd ones out when it comes to the quality of HLE audio. As of 4.0-1300 there has been a change to the DSP HLE emulation for those games. As such, we would like to see what issues remain, which were fixed, and what, if any, regressions have cropped up.

The following games need to be tested in Revision 4.0-1302 or newer:

Animal Crossing
Donkey Kong Jungle Beat (GC)
Donkey Kong Jungle Beat (Wii)
Luigi's Mansion
Mario Kart: Double Dash!!
Pikmin
New Play Control: Pikmin
Pikmin 2
New Play Control: Pikmin 2
Super Mario Galaxy
Super Mario Galaxy 2
Super Mario Sunshine
The Legend of Zelda: Four Swords Adventures
The Legend of Zelda: Wind Waker
The Legend of Zelda: Twilight Princess (GC)
The Legend of Zelda: Twilight Princess (Wii)

GameCube Bios may also be affected.


The issues that are expected to be fixed in the above games include:
*Game freezes such as Issue 7125.
*The audio in all of these games should finally be synchronous with the action.
*Audio notes being dropped, or music stopping. (Issue 2399)

Issues that have still been observed at this early state and need confirmation:
Luigi's Mansion Crackling - Reported by DJBarry04
Super Mario Galaxy 2: Rolling Ball Levels have distorted music - Reported by JMC47
Twilight Princess (Wii): Music Distorted - Reported by MaJoR
Wind Waker: All audio stops playing, or plays at wrong speed. - This is likely fixed by Single Core and can occur even on LLE. Not a Zelda HLE bug. The amount of work it takes to cause this problem means that you have to be extremely unlucky to run into it on your own. Using auto framerate, not hitting tab, and definitely not using vsync will likely cause this never to happen in normal usage.
IF AUDIO OR GAME CRASHES CANNOT BE REPRODUCED IN SINGLE CORE THEN THEY ARE NOT A FAULT OF ZELDA UCODE HLE. These games are much less lenient about CPU <-> DSP communication, making it much easier for it for other flaws in Dolphin's Dualcore mode to cause audio crashes. I believe Wind Waker and Twilight Princess issues in this thread are caused by this. This also means the faster your computer is, the less likely you are to run into issues in dualcore. How unfair is that for the people with weak computers?

Confirmed Multi-game issues in Zelda HLE
*Reverb is missing
*Audio levels are still incorrect in many games. (issue 5763)
*Some sounds may still have incorrect pitch. (issue 5746)
*Audio channels may not be balanced properly. (Issue 7126)

Confirmed Issues in Zelda HLE games
*The Legend of Zelda: The Wind Waker
---Wrong Pitch on magic meter filling up/depleting
---Missing Reverb
*The Legend of Zelda: Twilight Princess
---Wrong Pitch on magic meter filling up/depleting
---Missing Reverb
*Mario Kart: Double Dash!!
---Music/Sound Effect Volumes incorrect
---Missing Reverb
*Super Mario Galaxy 1
---Sound Effects/Some Musical Notes too loud
*Super Mario Galaxy 2
---Sound Effects/Some Musical Notes too loud
*The Legend of Zelda: Four Swords Adventures
---All sounds are mono
---Missing Reverb
*GameCube Bios (NTSC)
---Dolphin used Screech, it was super effective.

Any other bugs/fixes should be noted. Please say what game, and the circumstances that it was tested in for reproducing bugs. Thanks everyone in advance!

[delroth]

Things that are not an issue:

* <anything> when my game does not run at 100% speed

[MayImilae]

4.0-1302 removed the DSP LLE default from the GameINIs. Remember to use 4.0-1302 for these tests instead of 4.0-1300 to avoid any confusion.

[RachelB]

(03-27-2014, 08:05 PM)delroth Wrote: Things that are not an issue:

* <anything> when my game does not run at 100% speed

I'm pretty sure anything other than stuttering that only happens at <100% speed is a legitimate issue.

[haddockd]

Played Mario Kart Double Dash for about 30 minutes (played 4 races) and the only thing I noticed was in the menus when going from one menu to another the sound would crackle. Only for a split second. Other than that, it sounded good. Now on to Wind Waker!

[Anti-Ultimate]

Played Mario Kart and the music didn't stop.


I love you all

[haddockd]

Wasnt really a stop but a pop/snap/crackle unrelated to the cereal It may just be my rig.

I just played WW for about 45 minutes. I sailed from Southern Fairy Island to GreatFish Island and then onward to WindFall Island and got the bombs (and all the plot in between). I only have 2 notes.
1) The intro now sounds fantastic. Kudos!
2) The magic meter, when it fills up or depletes the sound effect is off. Wrong pitch maybe?

Onward to Twilight Princess!

[JMC47]

Haddockd: Thank you for your report. We do know about the Magic Meter problems, thank you for confirming!

[Anti-Ultimate]

FYI, you can change how the Magic Meter sounds like when you edit the Rectangle Wave in Zelda_Synth IIRC.

[cyrax33]

This is really great news that this is getting much attention at the moment.

Tested Windwaker overall (intro and ingame) and music + sfx ran as normal. Does this include Donkey Kong Country Returns by any chance as I can test it?
I will try Super Mario Galaxy 2 and report.