What quirks should be reported

[Henke37]

As of 5.0-9166 dolphin now automatically reports certain quirks being exploited by games.

However, so far only one quirk is reported, the icache inconsistency. I can't help but think that there has to be more quirks than just one.

This begs the question, what quirks are there that are worth detecting and automatically reporting? The various progress reports articles tend to mention specific functionality, so that seems like a good starting point. In particular, the Wii vs GC myth debugging article seems to hit on a lot of detectable features.

The real question is, of course, what quirks are useful to track?

[mstreurman]

(05-13-2019, 08:29 AM)Henke37 Wrote: As of 5.0-9166 dolphin now automatically reports certain quirks being exploited by games.

However, so far only one quirk is reported, the icache inconsistency. I can't help but think that there has to be more quirks than just one.

This begs the question, what quirks are there that are worth detecting and automatically reporting? The various progress reports articles tend to mention specific functionality, so that seems like a good starting point. In particular, the Wii vs GC myth debugging article seems to hit on a lot of detectable features.

The real question is, of course, what quirks are useful to track?

I guess any and all quirks, that will make replicating the behavior in code easier. If dev's don't know a specific quirk of the hardware exists they can't replicate it.

Also keep in mind that a quirk is something else than a bug, it is some "strange" hardware/software behavior that isn't expected but does happen. (could be wrong here, but that is how I interpret it but I'm not a dev)

The only reason I see to not report a quirk is when Dolphin already emulates said quirk correctly. So how to test for this? Try something strange on the real hardware and see if it also happens on Dolphin... e.g. If I do this in game X the game crashes on real hardware but when I do it in Dolphin the game just keeps going like nothing happens or: I can go out of bounds using this trick on real hardware, but when I do it in Dolphin it is impossible to do.

again: I am not a dev and this is my interpretation. If a real dev wants to chime in: please do and correct me if I'm completely off/wrong here.

[Billiard26]

I suppose the relevant "quirks" worth reporting are those suspected of causing breakage because of inaccuracies in the emulator due to a proper implementation being impossible, infeasible, inefficient, and/or assumed to be unnecessary.

Knowing which games have the "quirks" can make devs aware of games that might be failing and if a fix is needed and how to test the fix.