• Login
  • Register
  • Dolphin Forums
  • Home
  • FAQ
  • Download
  • Wiki
  • Code


Dolphin, the GameCube and Wii emulator - Forums › Dolphin Emulator Discussion and Support › Development Discussion v
« Previous 1 ... 10 11 12 13 14 ... 104 Next »

What does WXInputBase.cpp do?
View New Posts | View Today's Posts

Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Thread Modes
What does WXInputBase.cpp do?
04-23-2017, 12:56 AM
#1
Sentret_C Offline
Junior Member
**
Posts: 25
Threads: 1
Joined: Feb 2013
As a translator, I found many strings, like "Decimal", have diffrent meanings in Source/Core/DolphinWX/WXInputBase.cpp and in other files. More specifically, they lies in the "WXKeyToString" function.
Then, trying to find which meaning is used more often, I searched "WXKeyToString" on github and found it only appearing in WXInputBase.cpp and WXInputBase.h. Furthermore, the other function in that file, "WXKeymodToString", also appears only in that two files.
Does that mean the function is no longer used and it's ok to ignore those meanings? If not, where is it used?
Find
Reply
04-23-2017, 03:00 AM
#2
Jack Frost Offline
aka. BhaaL
**********
Developers (Some Administrators and Super Moderators)
Posts: 467
Threads: 2
Joined: Oct 2009
WXInputBase.cpp is mostly concerned with keyboard input, so "Decimal" in that context does not mean the number type, but actually the decimal (or comma) key.
Find
Reply
04-23-2017, 03:07 AM
#3
JosJuice Online
Developer
**********
Developers (Some Administrators and Super Moderators)
Posts: 5,720
Threads: 3
Joined: Oct 2014
You're right, everything in WXInputBase.cpp is unused. Thanks for catching it. It seems like it only was being used for the old hotkey system, which was replaced shortly after 4.0-5400 IIRC. It's most likely fine to ignore the WXInputBase.cpp meanings of the strings, but I'll need to make sure with the others that this file isn't something we're keeping around because we might need it in the future. In case we don't need it, I'll delete it entirely.
Find
Reply
04-23-2017, 07:39 AM
#4
JosJuice Online
Developer
**********
Developers (Some Administrators and Super Moderators)
Posts: 5,720
Threads: 3
Joined: Oct 2014
WXInputBase has been deleted now, and the strings that only existed in WXInputBase will be removed from Transifex the next time I sync. You can ignore the WXInputBase meaning of strings that exist in multiple places.
Find
Reply
« Next Oldest | Next Newest »


  • View a Printable Version
  • Subscribe to this thread
Forum Jump:


Users browsing this thread: 1 Guest(s)



Powered By MyBB | Theme by Fragma

Linear Mode
Threaded Mode