• Login
  • Register
  • Dolphin Forums
  • Home
  • FAQ
  • Download
  • Wiki
  • Code


Dolphin, the GameCube and Wii emulator - Forums › Dolphin Emulator Discussion and Support › Development Discussion v
« Previous 1 ... 19 20 21 22 23 ... 117 Next »

What are the combined commits without PRs ?
View New Posts | View Today's Posts

Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Thread Modes
What are the combined commits without PRs ?
04-24-2018, 08:54 AM (This post was last modified: 04-24-2018, 09:17 AM by Zexaron.)
#6
Zexaron Offline
Member
***
Posts: 118
Threads: 15
Joined: Oct 2016
Update: Now I noticed this, what github made:

[Image: 1zgtg05.png]

Okay I'm not upset or anything, I actually am happy that those experimental strings got cut out just as I noticed them and thought before I continue I should get those removed.

Secondairly, I was just trying to let you guys know, It may not be a big deal but I thought someone else might be doing a PR to remove those experimental tags, just to tell you they were already gone.


EDIT:

(04-24-2018, 08:40 AM)MayImilae Wrote: The text you are pointing out is from the in-development warning which was entirely removed from Dolphin in 5.0-6562.

This looks like this is just a transifex update removing the language strings that are no longer going to be used anywhere.


Allright, so is it what I speculated that there's a system where you can modify pot from the code as it looks like in DolphinQt2/InDevelopmentWarning.cpp - But then the actual pot and language files get updatel later separately?

Oh sorry, I didn't see any posts while making these 2 images.


(04-24-2018, 08:29 AM)AnyOldName3 Wrote: To me, it looks like one or more recent commits updated the strings in Dolphin. Once they'd been merged, either because someone did it manually or because we've set up Transifex to do it automatically, these updated strings ended up on Transifex. Once they had, various users translated them. Once they were translated, they needed copying from Transifex back into Dolphin's repo so people could actually use Dolphin in those other languages. This is the commit which adds the updated translations back into Dolphin's repo. This couldn't have been done all at once as the person who created the commit which changed the strings probably doesn't speak all of the zillion languages that Dolphin supports, so we had to wait for other people to finish the job.

Other projects I've worked on don't hold the translated texts in their repo, but instead use the Transifex client to download the translated texts as part of the build process. This avoids commits like this which lag behind the code changes which caused them.

Oh, thanks for that, so it was a rare or a special thing, I thought it was some part or feature of git/github I didn't knew about, or maybe it's github that doesn't properly support from merge-to-Transifex-to-public-repo kind of back and forth action?

The root of this how it started was I was making a new po file and I came down to where I saw DolphinQt experimental, remembering the PR about being default merged, I first decided to make a bug report, I got on the github repo and found the srings, an hour or so passed doing offtopic work, then I decided just to make a PR myself to remove experimental tags, but I couldn't find the strings anymore, what should be a good thing (it is) turned into this wild goose chase what happened, but It's just my thing my mind isn't satisfied and determined to get to the bottom of it hehe.
Find
Reply
« Next Oldest | Next Newest »


Messages In This Thread
What are the combined commits without PRs ? - Zexaron - 04-24-2018, 07:06 AM
RE: What are the combined commits without PRs ? - AnyOldName3 - 04-24-2018, 08:29 AM
RE: What are the combined commits without PRs ? - Zexaron - 04-24-2018, 08:30 AM
RE: What are the combined commits without PRs ? - AnyOldName3 - 04-24-2018, 08:32 AM
RE: What are the combined commits without PRs ? - MayImilae - 04-24-2018, 08:40 AM
RE: What are the combined commits without PRs ? - Zexaron - 04-24-2018, 08:54 AM
RE: What are the combined commits without PRs ? - JosJuice - 04-24-2018, 03:56 PM
RE: What are the combined commits without PRs ? - Zexaron - 04-24-2018, 05:25 PM
RE: What are the combined commits without PRs ? - JosJuice - 04-24-2018, 06:02 PM
RE: What are the combined commits without PRs ? - Zexaron - 04-24-2018, 06:06 PM

  • View a Printable Version
  • Subscribe to this thread
Forum Jump:


Users browsing this thread: 1 Guest(s)



Powered By MyBB | Theme by Fragma

Linear Mode
Threaded Mode