Testing needed: Rewrite DTK/streaming audio (PR259)

[magumagu]

Build available at http://dl.dolphin-emu.org/prs/pr-259-dolphin-latest-x64.7z .

This change specifically affects GameCube games which use the DTK/streaming audio functionality of the DVD drive to play music. A list of potentially affected games is available at http://www.gc-forever.com/wiki/index.php?title=Audio_Streaming (this list is accurate, but incomplete). Highlights include Ikaruga, Eternal Darkness, and Super Monkey Ball.

This change has a few effects. The most noticeable one is that it makes music play at the correct rate even if the emulator isn't running at full speed. It also fixes issues in a few games; among other things, it fixes a crash in Ikaruga. (It will also make it easier to implement changes to the audio code and audio dumping in the future.)

Pac-Man Fever is known broken; besides that, there aren't any known issues with this change.

I'd like to get testing for more games before this change is merged. In particular, if anyone has "Zoids: Battle Legends", please test. (If you find an issue with this build, please compare the behavior to latest master.)

[JMC47]

Tested: Super Monkey Ball 1, 2, Mario Super Star Baseball, Dave Mirra Pro BMX 2, Tony Hawk Pro Skater 3, 4, Starfox Adventures, Swingerz Golf and Pacman Fever.

No noted issues, lots of synchronization issues fixed (cutscenes, transitions, etc.) in most games.

Pacman Fever is INCREDIBLY broken in Master, so the fact it's broken in this PR shouldn't exactly block it from being merged, mainly because it may be non-DTK audio issues.

[Darkness Knight]

Report:

Crazy Taxi (USA)

In the master branch play the first song; EVER! but in this build only play one song and stop =/...btw in pause still playing the audio BGM (song).

Edit: When starts a new game play a different track =).


Star Fox Adventures (Europe)

Desync cutscenes and muted sounds.


Salu2 - Darkness Knight

[JMC47]

It appears to be only playing the first DTK audio track in Starfox Adventures; I don't remember this happening in an older version of the Pull Request.

[magumagu]

Uploaded an updated version; same URL. Should fix the issue with audio stopping.

[Darkness Knight]

(06-16-2014, 08:20 AM)magumagu Wrote: Uploaded an updated version; same URL. Should fix the issue with audio stopping.

You new build don't fix Crazy Taxi =/.

Salu2 - Darkness Knight

[magumagu]

(06-16-2014, 09:24 AM)Darkness Knight Wrote:

(06-16-2014, 08:20 AM)magumagu Wrote: Uploaded an updated version; same URL. Should fix the issue with audio stopping.

You new build don't fix Crazy Taxi =/.

Salu2 - Darkness Knight

Updated again; hopefully this one fixes Crazy Taxi.

[Darkness Knight]

With your new build I tested Star Fox Adventures & Craxy Taxi:

Star Fox Adventures:
Sound pretty good, more sounds BGM, audio sync, etc.

Crazy Taxi:
Same issues.

HINT: For avoid confussion change the number of the build or date (ex. 20140618).

Salu2 - Darkness Knight.

[Darkness Knight]

This was merged at the brach master and not fix Crazy Taxi songs issue.

Nore details in the thread official of the game:
https://forums.dolphin-emu.org/Thread-gc-crazy-taxi?pid=329313#pid329313

Salu2 - Darkness Knight

[JMC47]

Darkness Knight: It was outside of the scope of the pull request. It was broken before the rewrite. We don't know what's wrong, or if it's even related to DTK audio itself. That's why it didn't get fixed.