Telemetry data

[Wexrio]

So I just built the latest dolphin git revision 8122d2cc9f4db427c9ecd9fabf8413376bc4314c and had a menu pop up asking about telemetry data. Enough said, why has this not been burned with fire yet?

[Shonumi]

It's completely optional. You can control if Dolphin sends anything at all. Read more here -> https://dolphin-emu.org/blog/2016/06/19/optional-usage-statistics-reporting/

[Wexrio]

Found the offending commit https://github.com/dolphin-emu/dolphin/commit/65f76cfc634af50fd9c42f41ab5abf531cfa1a55

Went browsing through the Core/Core/Analytics* and Core/Common/Analytics* it's fine. But is there a cmake option to disable it? Maybe I could make one...

Also why is a constexpr used and then defined as a u32 on line 138 of Core/Common/Analytics.cpp ? Excuse my noobness in programming but wouldn't that make the buffer size 800 bits instead of dependent on compile time options? Seems like a small buffer for all the data you are grabbing up.

[JosJuice]

(09-29-2016, 01:05 PM)Wexrio Wrote: But is there a cmake option to disable it? Maybe I could make one...

Yes, there's ENABLE_ANALYTICS, but it's actually completely broken right now. In the rush to get analytics finished before the 5.0 release, no code got added to make it do anything. If you want to fix that, pull requests are welcome.

(09-29-2016, 01:05 PM)Wexrio Wrote: Also why is a constexpr used and then defined as a u32 on line 138 of Core/Common/Analytics.cpp ? Excuse my noobness in programming but wouldn't that make the buffer size 800 bits instead of dependent on compile time options? Seems like a small buffer for all the data you are grabbing up.

I don't know why you're talking about "instead of dependent on compile time options", but anyway... The u32 means that the value 25 is stored in a u32 – it doesn't mean that the size limit is 25 u32s. m_reports_queue contains strings, so the size limit is 25 strings.