Synchronised FIFO patch (for Eternal Darkness)

[Xtreme2damax]

@Iceman, the patch file in the following post is a mess, there's a few or more duplicate files mixed in and it doesn't merge with the latest source..

http://forums.dolphin-emu.org/thread-10036-post-98591.html#pid98591

[IcemanSR]

duplicate files?mess?

your point is?

why would u even merge it into latest svn?there is no point to it.

[sharksmile]

Iceman,
When I use load my normal save (in-game), chapters name comes on screen and then game breaks, screen turns to black and nothing happens at all. I'm guessing that this version of emulator still has compatibility issues with some hardware you haven't tested. Well, still great work! I will be waiting for a more stable version though.

[IcemanSR]

sharksmile i believe u have serious issues with your iso or something gone VERRY wrong with your config.
If u get problem when loading from memory card then something is VEEEEERY damaged.

and it definitely is not my build

are u using directx9?if so did u applied zelda hack?
your problems are definitely not problem with build.

There is no such hardware compatibility which can explain issues u are having.Ur problem lies elsewhere.

[Xtreme2damax]

(07-15-2010, 02:47 PM)IcemanSR Wrote: duplicate files?mess?

your point is?

why would u even merge it into latest svn?there is no point to it.

The point is that I thought it was mentioned that the patch should now be able to be merged into a more recent trunk than skids patch could.

Your patch also contains quite a few duplicates such as main.cpp and CommandProcessor.cpp.

There is also a point to it, that there has been fixes since revision 5688, the last revision skids patch worked with.

[IcemanSR]

fine ,i will review patch to be applied to newer svn.BUT
new svn has some issues with PIPE.
and what fixes are u suggesting that could give this build something?

and i just checked patch .u are slightly wrong,there is no duplicates at all

Code:

Index: Source/Core/VideoCommon/Src/CommandProcessor.cpp
Index: Source/Plugins/Plugin_VideoSoftware/Src/CommandProcessor.cpp

as u can see those are not duplicates.
main.cpp

Code:

Index: Source/Plugins/Plugin_VideoDX11/Src/main.cpp
Index: Source/Plugins/Plugin_VideoDX9/Src/main.cpp
Index: Source/Plugins/Plugin_VideoOGL/Src/main.cpp

Those are not duplicates either.
did u used patch3 from that post?
skid patch originally was compatibile with 5688 only while i merged patch to be compatibile with 5807,that was last svn at the moment when i created patch
5807vs5879 is not such difference ,since as i see game already has what it needs?perfect video under dx11 good sound under SC.Just point me what u think it might benefit to build?couse it might be better to just apply specific fix instead merging to whole revision

and at this moment difference between skid's build and mine is:
mine has working dx11 properly graphic is perfect,skids older build dx11 was giving only black screen.
mine works perfect under SC no problems of any kind,DC has only slight outburts.skid's version has outbursts in both SC and DC.thats about it.

---

i later made second build which i extremly cleaned the code,i can put the patch if u won't it ,its just that i got tired after making that so i laylow for a bit :-)
@sharksmile
it just hitted me,
which build are u using?

[Xtreme2damax]

I was looking at what files the patch patched, I didn't see that the paths were different, my apologies..

[IcemanSR]

but what fixes from latest svn did u had in mind that could contribute to ED build?

[Xtreme2damax]

Graphical fixes might have fixed some rendering issues in ED, core fixes might have fixed instability and crashes if there is any.

[IcemanSR]

yeah ok,i will merge it,graphic problems might be fixed under dx9,dx11 is already perfect.