Super Mario Galaxy (1/2) Sound - Needs Developer Feedback

[razor1911]

thanks for the hardwork mate, would you mind uploading dolphin with patch applied, I cant setup the build here to patch it manually.

I would provide feedback you require

regards

[Xtreme2damax]

(07-22-2010, 09:09 AM)razor1911 Wrote: thanks for the hardwork mate, would you mind uploading dolphin with patch applied, I cant setup the build here to patch it manually.

I would provide feedback you require

regards

Sure.

I set a record, got the following two stars without music stopping:

Sky Station Galaxy - Storming the Sky Fleet
Fluffy Bluff Galaxy - Luma Secret Star

I then quit, I didn't check to see how much further I could go without the music stopping. Oddly, the AFC looping fixes seem to work better for SMG/SMG2 than it does for Twilight Princess.


  DSP_HLE_Patched.7z (Size: 921.29 KB / Downloads: 180)

I've included the x86 and x64 patched DSP_HLE plugins.

We are so close to nailing this issue, I can feel it and taste the sweat of hard work. Now we need a developer, particularly someone experienced with dsp emulation to provide feedback regarding what is wrong with the code for the current looping hack and how it can be improved.

Yeah, I apologize if I am repeating myself.

[kernel64]

Testing the patch... great work @Xtreme and all the people helping on this.

EDIT: Well, SMG1 Overture theme didn't looped. This particular song plays for 45 seconds, then silence. In SMG2 I've tried one song and it looped ok!!! (tested about 3 minutes or 4). I've noted a barely audible gap in-between loops (about 1/3 of second, I'm not complaining, just reporting back in case it could be useful info) but this is looking great!!!

It's late here and I'm tired. I'll do some more tests tomorrow.

[Xtreme2damax]

I'd be interested how much longer the music lasts for everyone, I've had mixed results, but the music seems to last quite a bit longer than before. There's got to be a better way, wish I knew how to code because then I wouldn't of needed to spend hours and basically accomplish nothing.

[razor1911]

I tested it in SMG1 in the observatory the music didnt last for long, I would say same amount of time it used to last

[Xtreme2damax]

Perhaps the music wasn't using AFC or something else caused it to quit. I tried good egg galaxy and another galaxy in SMG1 and it looped fine for a while, then quit. Music in SMG2 lasts quite a bit longer, but somewhere in the AFC looping code that causes music to quite.

Too bad on the fly debugging and the ability to observe what code is causing trouble wasn't possible, if it is I'd like to know how.

[Granville]

I haven't tested MG2, but this patch does absolutely nothing for the first game. Tried Good Egg Galaxy and the music stops at the exact same point it always has, right as the song is supposed to loop...

[Xtreme2damax]

Well it worked for me, that's all I can say, I'm not a coder else I would be fixing these issues.

Beyond that I can't offer any suggestions or any way to fix the issue, the best bet would be to try contacting neXus as he might have a good idea how to solve the looping issue, especially since he improved the AFC looping hack a while back.

[razor1911]

its sad to see the thread dieing without any support going into fixing SMG issues

[Xtreme2damax]

Indeed..

It would be nice if skid by any chance could at least convince Lord Mark or nakee to at least work on fixing AFC looping. I tried posting my findings on the IRC channel, but my feedback was ineffective at best despite the debugging and testing I did to help narrow down the issue for them.

I tried asking ector for ideas or suggestions regarding how the current AFC looping hack could be fixed to loop AFC audio correctly, I've yet to receive a response back. :/