• Login
  • Register
  • Dolphin Forums
  • Home
  • FAQ
  • Download
  • Wiki
  • Code


Dolphin, the GameCube and Wii emulator - Forums › Dolphin Site › Dolphin Patches (Archive) v
« Previous 1 … 3 4 5 6 7 Next »

SMS Flashing Fix
View New Posts | View Today's Posts

Pages (2): 1 2 Next »
Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Threaded Mode
SMS Flashing Fix
10-30-2010, 04:09 AM (This post was last modified: 10-30-2010, 04:33 AM by Anti-Ultimate.)
#1
Anti-Ultimate Offline
Above and Beyond
*******
Posts: 1,957
Threads: 29
Joined: May 2010
The patch was made in 2 hours
This fixes the Super Mario Sunshine red flashing problem.
(However the flashing is still too fast.)Not an Issue (happens on real hardware tooTongue)
The best is that it doesn't break NSMB fog and background texturesTongue.
This needs alot more work.
Maybe fixes other games flashing.


Attached Files
.patch   fixfogsms.patch (Size: 818 bytes / Downloads: 211)

Find
10-30-2010, 05:04 AM
#2
neobrain Offline
"Wow, I made my code 1000x faster! That means I can make it 2048x slower now!"
**********
Developers (Some Administrators and Super Moderators)
Posts: 3,208
Threads: 50
Joined: Jun 2009
Hm, great if it works, but is there any reasoning behind the changes, i.e. could you explain why you've inserted that a<2 check?
My blog
Me on Twitter
My wishlist on Amazon.de
Find
10-30-2010, 05:24 AM
#3
Anti-Ultimate Offline
Above and Beyond
*******
Posts: 1,957
Threads: 29
Joined: May 2010
without it it wouldn't compile.
but i just noticed that that big shine stays just violett (can't explain which colour that is).
I could make it better, but it would break NSMB background textures and fog.

Find
10-30-2010, 05:48 AM
#4
Jack Frost Offline
aka. BhaaL
**********
Developers (Some Administrators and Super Moderators)
Posts: 523
Threads: 3
Joined: Oct 2009
Hmm, the first change is the same one I just saw on googlecode (Issue 2589, present since r4714, fixed the NSMB fog but apparently broke RE4 fog)...
And apart from the a < 2 (which looks pretty random), you broke/disabled the "Disable Fog" switch.

Boils down to a revert of r4714 for that file, eh?
Find
10-30-2010, 05:50 AM
#5
neobrain Offline
"Wow, I made my code 1000x faster! That means I can make it 2048x slower now!"
**********
Developers (Some Administrators and Super Moderators)
Posts: 3,208
Threads: 50
Joined: Jun 2009
What wouldn't compile? Dolphin? The generated shader?

Reverting r4714 isn't an option since that would most likely break nsmb again.
My blog
Me on Twitter
My wishlist on Amazon.de
Find
10-30-2010, 06:04 AM (This post was last modified: 10-30-2010, 06:11 AM by Anti-Ultimate.)
#6
Anti-Ultimate Offline
Above and Beyond
*******
Posts: 1,957
Threads: 29
Joined: May 2010
pixelshadermanager won't compile ( error C2061: syntax error : identifier 'SetPSConstant4f )
This is my first patch,never did something like this before.
However when reverting the changes from 4714 everything was working again but i had to use Disable Fog (I think you know why).

EDITBig Grinisable Fog is still workingTongue.

Find
10-30-2010, 06:14 AM (This post was last modified: 10-30-2010, 06:22 AM by neobrain.)
#7
neobrain Offline
"Wow, I made my code 1000x faster! That means I can make it 2048x slower now!"
**********
Developers (Some Administrators and Super Moderators)
Posts: 3,208
Threads: 50
Joined: Jun 2009
hm, reverting 4714 makes it work for me as well, WITHOUT breaking nsmbw...
EDIT: nvm, nsmbw is broken after reverting 4714 Tongue
My blog
Me on Twitter
My wishlist on Amazon.de
Find
10-30-2010, 06:31 AM
#8
Anti-Ultimate Offline
Above and Beyond
*******
Posts: 1,957
Threads: 29
Joined: May 2010
@Jack Frost: Disable Fog switch is still working using the patch. (at least for me.)
Just compile for yourself and see what this patch does.

@NeoBrain: You used the Disable Fog option ?!

Find
10-30-2010, 06:34 AM
#9
neobrain Offline
"Wow, I made my code 1000x faster! That means I can make it 2048x slower now!"
**********
Developers (Some Administrators and Super Moderators)
Posts: 3,208
Threads: 50
Joined: Jun 2009
what bhaal meant was that you effectively disabled the feature "disable fog" by removing the else block in your patch...

nah, nevermind... Tongue
My blog
Me on Twitter
My wishlist on Amazon.de
Find
10-30-2010, 07:16 AM
#10
Anti-Ultimate Offline
Above and Beyond
*******
Posts: 1,957
Threads: 29
Joined: May 2010
made another one:

this is actually pretty better and added the else stuff.


Attached Files
.patch   fogsmsgixV2.patch (Size: 709 bytes / Downloads: 217)

Find
« Next Oldest | Next Newest »
Pages (2): 1 2 Next »


  • View a Printable Version
Forum Jump:


Users browsing this thread: 1 Guest(s)



Powered By MyBB | Theme by Fragma