Since Dtk merge, audio has static in it

[purpasmart96]

Ever since the DTK rewrite, auido has horribly annoying static in all of the sound
the culprit is the DTK rewrite
https://github.com/dolphin-emu/dolphin/pull/259
Tested and reproducible in many games, including, but not limited to Super smash Bros Melee, Super Mario sunshine, LoZ Wind Waker, Luigi's Mansion, Kirby air ride, Pokemon Battle Revolution, POKeMON XD, Pokemon Colosseum, etc..
I'm currently uploading dumped audio files of what they were before the DTK rewrite and after.
and I tested under Dolphin's DSP LLE rom's and and my own real DSP roms's that were dumped from my Wii, same thing.

[JMC47]

I thought that was handled; I do know it was a bug in the original DTK rewrite PR. I did check the static in Starfox Adventures and other DTK games and thought it was finally gone.

If you could make comparison audio dump files between the build with DTK rewrite and the build before, and put up an issue report, I'm sure someone will look at it.

[purpasmart96]

(07-09-2014, 01:46 PM)JMC47 Wrote: I thought that was handled; I do know it was a bug in the original DTK rewrite PR. I did check the static in Starfox Adventures and other DTK games and thought it was finally gone.

If you could make comparison audio dump files between the build with DTK rewrite and the build before, and put up an issue report, I'm sure someone will look at it.

Yeah I'm just waiting for it be uploaded, mediafire takes awhile to upload...
EDIT: Uploaded, I'm using Windwaker as the test game. http://www.mediafire.com/download/pv4ukzsejw3k4sa/audiodump.7z

[JMC47]

It's my fault for missing this in my last test if it is indeed true. I missed a lot of minor bugs in the DTK audio PR, and there weren't many people who tested it in the thread.

[purpasmart96]

(07-09-2014, 01:52 PM)JMC47 Wrote: It's my fault for missing this in my last test if it is indeed true. I missed a lot of minor bugs in the DTK audio PR, and there weren't many people who tested it in the thread.

Do you think magumagu, and lioncash, and also including neobrain would allow an revert of the new DTK until this is fixed? It's most notable in Windwaker if you want to test it that is.

[JMC47]

I don't think it should be reverted, rather, we should find out what build within it caused it and search for a solution.

[purpasmart96]

In the audio dump I uploaded, You should hear very clearly in the audiodump_DTK_new.wav file at 0:09 to 0:20 , that's one of the most obvious one.