fx some issues, release a new apk on github.
Share my personal build for android
|
10-19-2018, 03:15 PM
10-19-2018, 06:07 PM
(10-17-2018, 11:24 PM)weihuoya Wrote: I'm not experienced programmer, and I made minor changes in my spare time. hope you like it. Hi May I ask you to rebase your branch instead of merging master? The commit history is a bit messy else, and it will get worse: https://github.com/weihuoya/dolphin/commits/master I see, maintaining a nice patch history and rewriting the history on every update is a big overhead, but else you'll just end in one big diff of your branch vs master. Maybe also squash your fixup commits in the right patch. One commit per feature is so much easier to read, to maintain, and to merge If you need help, feel free to ask us on #dolphin-dev on freenode. Thanks (10-19-2018, 12:47 PM)FrangoST Wrote: tested it on MKWii and FIFA 15, on my Mi 6 (SD835) : Explain better, because I did not understand what you mean. PS: It would be nice, if you also attached the screenshots, of the eventual issue. Thank you. (10-19-2018, 02:27 PM)weihuoya Wrote: fx some issues, release a new apk on github. In Download! (10-19-2018, 06:07 PM)degasus Wrote: May I ask you to rebase your branch instead of merging master? The commit history is a bit messy else, and it will get worse: https://github.com/weihuoya/dolphin/commits/master No, the commits are correct and based on the changes, which from time to time the author of the project, considers it necessary to add or modify. His commits, in order of his times. 10-19-2018, 06:44 PM
(10-19-2018, 06:07 PM)degasus Wrote: Hi oh, a lot of work, l will try. 10-19-2018, 06:46 PM
10-19-2018, 06:53 PM
(10-19-2018, 06:46 PM)stizzo Wrote: Your commits are right. git log ..weihuoya --stat Code: commit 09645e847e0729c387bb16383b61d98b781e023e 10-19-2018, 07:06 PM
Maybe it can be difficult for you, but the author, I see that it also adds the changes of the other authors of the main branch.
It would be a job that would take away a lot of precious time. Come to meet him. 10-19-2018, 07:25 PM
(10-19-2018, 07:06 PM)stizzo Wrote: Maybe it can be difficult for you, but the author, I see that it also adds the changes of the other authors of the main branch. I think you've missed my point. I don't want them to do it for me. I suggest them to do it for making it easier for them over time. Merging is easier in the beginning, rebasing is more work in the beginning. But over time, this changes. You'll see some random merge conflicts without any additional hints what was changed. So rebasing stays at the same complexity, but merging will get harder over time, even with the same amount of modification. |
« Next Oldest | Next Newest »
|
Users browsing this thread: 1 Guest(s)