• Login
  • Register
  • Dolphin Forums
  • Home
  • FAQ
  • Download
  • Wiki
  • Code


Dolphin, the GameCube and Wii emulator - Forums › Dolphin Site › Site Feedback and Questions v
« Previous 1 2 3 4 5 6 … 26 Next »

"Search Google" in Wiki info boxes doesn't work properly
View New Posts | View Today's Posts

Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Threaded Mode
"Search Google" in Wiki info boxes doesn't work properly
04-16-2020, 12:10 PM
#1
hman360 Offline
Junior Member
**
Posts: 15
Threads: 5
Joined: Aug 2019
It's a minor bug, but if you click the "Search Google" link in the info box for a game with a space in its name in the wiki, the search has a + in place of the space, which seems to be some kind of URL encoding bug. I don't know if this can be fixed in the wiki template or if it requires a wiki software fix, but I couldn't figure out how to do it through the wiki.

Here's a page with an example of what I'm talking about. Just click "Search Google" in the info box and the Google search will be for "Batman+Vengeance" instead of "Batman Vengeance".
Find
Reply
04-16-2020, 12:30 PM
#2
ExtremeDude2 Offline
Gotta post fast
*******
Posts: 9,376
Threads: 273
Joined: Dec 2010
It's an underscore (Batman_Vengeance) for me.
Check out my videos (dead)
[Image: sig-22354.png]
Website Find
Reply
04-16-2020, 12:42 PM (This post was last modified: 04-16-2020, 12:44 PM by mbc07.)
#3
mbc07 Offline
Wiki Caretaker
*******
Content Creators (Moderators)
Posts: 3,620
Threads: 47
Joined: Dec 2010
I'll take a look, shouldn't be hard to fix...

(04-16-2020, 12:30 PM)ExtremeDude2 Wrote: It's an underscore (Batman_Vengeance) for me.
That was one of my attempts, still working on it Tongue
Avell A70 MOB: Core i7-11800H, GeForce RTX 3060, 16 GB DDR4-3200, Windows 11 (Insider Preview)
ASRock Z97M OC Formula: Pentium G3258, GeForce GT 440, 16 GB DDR3-1600, Windows 10 (22H2)
Find
Reply
04-16-2020, 01:28 PM (This post was last modified: 04-16-2020, 03:13 PM by MayImilae.)
#4
MayImilae Offline
Chronically Distracted
**********
Administrators
Posts: 4,669
Threads: 122
Joined: Mar 2011
If you are looking at the URL, spaces will be converted to another character in the URL. If you look at the title of the Google search you'll see the real search without special characters for the URL. Regardless of how the URL looks, it should still work perfectly fine.

Here is what I got from Batman Vengeance. It's working perfectly fine, for me at least.

[Image: JvAbw7o.png]
[Image: RPvlSEt.png]
AMD Threadripper Pro 5975WX PBO+200 | Asrock WRX80 Creator | NVIDIA GeForce RTX 4090 FE | 64GB DDR4-3600 Octo-Channel | Windows 11 23H1 | (details)
MacBook Pro 14in | M1 Max (32 GPU Cores) | 64GB LPDDR5 6400 | macOS 12
Find
Reply
04-16-2020, 02:38 PM (This post was last modified: 04-16-2020, 02:43 PM by mbc07.)
#5
mbc07 Offline
Wiki Caretaker
*******
Content Creators (Moderators)
Posts: 3,620
Threads: 47
Joined: Dec 2010
Correcting this was trickier than what I expected but it should be fixed (like, for real) now.

(04-16-2020, 01:28 PM)MayImilae Wrote: If you are looking at the URL, spaces will be converted to another character in the URL. Regardless of how the URL looks, it still works perfectly fine. If you look at the title of the Google search you'll see the real search without special characters for the URL.

Here is what I got from Batman Vengeance. It's working perfectly fine, for me at least.

There was a bug indeed. Our template code was correctly replacing spaces with + before constructing the URL but, for whatever reason, the built-in [[google:]] function we were using on the wiki would then replace + with %2B when generating the link, which would result on a Google search query having + instead of spaces.

What you saw on your test is the correct behavior and it's how it's working now. As I was fighting with this for the past two hours (as I later discovered similar issues with pages containing actual +, ', ", or & characters on their titles), you probably got caught in the middle of my attempts, just like ExtremeDude2 a little before (which was getting this)...
Avell A70 MOB: Core i7-11800H, GeForce RTX 3060, 16 GB DDR4-3200, Windows 11 (Insider Preview)
ASRock Z97M OC Formula: Pentium G3258, GeForce GT 440, 16 GB DDR3-1600, Windows 10 (22H2)
Find
Reply
04-16-2020, 03:12 PM
#6
hman360 Offline
Junior Member
**
Posts: 15
Threads: 5
Joined: Aug 2019
(04-16-2020, 02:38 PM)mbc07 Wrote: Correcting this was trickier than what I expected but it should be fixed (like, for real) now.


There was a bug indeed. Our template code was correctly replacing spaces with + before constructing the URL but, for whatever reason, the built-in [[google:]] function we were using on the wiki would then replace + with %2B when generating the link, which would result on a Google search query having + instead of spaces.

What you saw on your test is the correct behavior and it's how it's working now. As I was fighting with this for the past two hours (as I later discovered similar issues with pages containing actual +, ', ", or & characters on their titles), you probably got caught in the middle of my attempts, just like ExtremeDude2 a little before (which was getting this)...

Thanks for fixing it so fast!
Find
Reply
04-16-2020, 03:53 PM
#7
MayImilae Offline
Chronically Distracted
**********
Administrators
Posts: 4,669
Threads: 122
Joined: Mar 2011
Thanks for taking care of it so fast mbc07!
[Image: RPvlSEt.png]
AMD Threadripper Pro 5975WX PBO+200 | Asrock WRX80 Creator | NVIDIA GeForce RTX 4090 FE | 64GB DDR4-3600 Octo-Channel | Windows 11 23H1 | (details)
MacBook Pro 14in | M1 Max (32 GPU Cores) | 64GB LPDDR5 6400 | macOS 12
Find
Reply
« Next Oldest | Next Newest »


  • View a Printable Version
Forum Jump:


Users browsing this thread: 1 Guest(s)



Powered By MyBB | Theme by Fragma