"Search Google" in Wiki info boxes doesn't work properly

[hman360]

It's a minor bug, but if you click the "Search Google" link in the info box for a game with a space in its name in the wiki, the search has a + in place of the space, which seems to be some kind of URL encoding bug. I don't know if this can be fixed in the wiki template or if it requires a wiki software fix, but I couldn't figure out how to do it through the wiki.

Here's a page with an example of what I'm talking about. Just click "Search Google" in the info box and the Google search will be for "Batman+Vengeance" instead of "Batman Vengeance".

[ExtremeDude2]

It's an underscore (Batman_Vengeance) for me.

[mbc07]

I'll take a look, shouldn't be hard to fix...

(04-16-2020, 12:30 PM)ExtremeDude2 Wrote: It's an underscore (Batman_Vengeance) for me.

That was one of my attempts, still working on it

[MayImilae]

If you are looking at the URL, spaces will be converted to another character in the URL. If you look at the title of the Google search you'll see the real search without special characters for the URL. Regardless of how the URL looks, it should still work perfectly fine.

Here is what I got from Batman Vengeance. It's working perfectly fine, for me at least.

[mbc07]

Correcting this was trickier than what I expected but it should be fixed (like, for real) now.

(04-16-2020, 01:28 PM)MayImilae Wrote: If you are looking at the URL, spaces will be converted to another character in the URL. Regardless of how the URL looks, it still works perfectly fine. If you look at the title of the Google search you'll see the real search without special characters for the URL.

Here is what I got from Batman Vengeance. It's working perfectly fine, for me at least.

There was a bug indeed. Our template code was correctly replacing spaces with + before constructing the URL but, for whatever reason, the built-in [[google:]] function we were using on the wiki would then replace + with %2B when generating the link, which would result on a Google search query having + instead of spaces.

What you saw on your test is the correct behavior and it's how it's working now. As I was fighting with this for the past two hours (as I later discovered similar issues with pages containing actual +, ', ", or & characters on their titles), you probably got caught in the middle of my attempts, just like ExtremeDude2 a little before (which was getting this)...

[hman360]

(04-16-2020, 02:38 PM)mbc07 Wrote: Correcting this was trickier than what I expected but it should be fixed (like, for real) now.


There was a bug indeed. Our template code was correctly replacing spaces with + before constructing the URL but, for whatever reason, the built-in [[google:]] function we were using on the wiki would then replace + with %2B when generating the link, which would result on a Google search query having + instead of spaces.

What you saw on your test is the correct behavior and it's how it's working now. As I was fighting with this for the past two hours (as I later discovered similar issues with pages containing actual +, ', ", or & characters on their titles), you probably got caught in the middle of my attempts, just like ExtremeDude2 a little before (which was getting this)...

Thanks for fixing it so fast!

[MayImilae]

Thanks for taking care of it so fast mbc07!