• Login
  • Register
  • Dolphin Forums
  • Home
  • FAQ
  • Download
  • Wiki
  • Code


Dolphin, the GameCube and Wii emulator - Forums › Dolphin Emulator Discussion and Support › Development Discussion v
« Previous 1 ... 57 58 59 60 61 ... 116 Next »

Revision page changed - FAQ
View New Posts | View Today's Posts

Pages (8): 1 2 3 4 5 ... 8 Next »
Jump to page 
Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5
Thread Modes
Revision page changed - FAQ
08-21-2011, 12:00 AM (This post was last modified: 08-22-2011, 10:12 AM by neobrain.)
#1
neobrain Offline
"Wow, I made my code 1000x faster! That means I can make it 2048x slower now!"
**********
Developers (Some Administrators and Super Moderators)
Posts: 3,208
Threads: 50
Joined: Jun 2009
We've recently switched to Git. This thread is meant to give a small insight into the reasons as to why this was done as well as a comment on the problems which arose with the switch.

Q: Why Git?
A: Git has many advantages over Subversion which makes it more comfortable to use for developers. The most important thing is easier branches, i.e. if someone decides to implement a major feature like GLSL support or the texture cache rewrite, you don't need to f*ck up the main development tree but can play around in another branch of the source code without causing problems in the main build.


Q: Where did the revision numbers like r7714 go?
A: Git doesn't use a revision counter, but rather links each changeset with a SHA1 hash. This raised numerous complaints, most of which are either solved easily or which aren't relevant to developers. You need to understand that the whole GoogleCode page is meant to be a developers' place, so there is really no reason for us to care about complaints like "omg I want my rev numbers back!!1".


Q: But how can I tell how old a changeset is just by looking at that hash?
A: You can't. You can, however, simply use your Git tool to show some info about the current commit, which will output the date and branch of the corresponding changeset. Using the CLI of Git, you just need to call "git show <hash>", for example.


Q: Will I still be able to get the Dolphin source with TortoiseSVN?
Q: So, what client should I use to get the source now?

A: You will need another client to get the Dolphin source. For Windows, there's TortoiseGit, GitExtensions as well as msysgit (which is just the command line interface). I'm using TortoiseGit since it's similiar to TortoiseSVN, but GitExtensions is easier to install and might be easier to handle as well. I didn't really try GitExtensions but some devs seem to prefer it, I'd like to hear about which one end users prefer.
For Linux, you most likely already know what you're doing. Just install the CLI of git or use one of the various GUIs available, e.g. gitk or QGit.


Q: How will the homepage handle this now, i.e. how will Git builds be distributed now?
A: We're not entirely sure about that - merely because we haven't heard anything from mamario, yet.


Q: How will the general development process be affected by the switch?
A: (gotta answer this another time)
My blog
Me on Twitter
My wishlist on Amazon.de
Find
Reply
08-21-2011, 02:27 AM (This post was last modified: 08-21-2011, 02:28 AM by naoan.)
#2
naoan Offline
Senior Member
****
Posts: 570
Threads: 2
Joined: Jul 2009
Anything to make developer's life easier Tongue

A question, by date does it include HH:MM: SS on the description? if so why not use that to identify/distribute the git build? Just a suggestion...
Find
Reply
08-21-2011, 02:33 AM (This post was last modified: 08-21-2011, 02:34 AM by Runo.)
#3
Runo Offline
Greeny
*******
Posts: 1,194
Threads: 43
Joined: Mar 2009
(08-21-2011, 12:00 AM)neobrain Wrote: Q: Where did the revision numbers like r7714 go?
A: Git doesn't use a revision counter, but rather links each changeset with a SHA1 hash. This raised numerous complains, most of which are either solved easily or which aren't relevant to developers. You need to understand that the whole GoogleCode page is meant to be a developers' place, so there is really no reason for us to care about complains like "omg I want my rev numbers back!!1".

My main concern was how to give support in the forums, but since I heard you guys do not intend to have noobs using non release builds anymore, that should be no problem, plus the git description thing will do the trick when trying to track down bugs and feedbacking... Also I didn't realize that using the hash you cant go back any specific source state (revisions?), I was too stupid last night. As a suggestion, if you are really going to do this way, I think you should only make available to download in the site the stable builds or alphas, betas whatever. Whoever needs/wants another one will have a reason to be looking for that and therefore will know how to build. This would totally solve the support problem Smile.
Also, I like the branches thing Tongue
If I ever happen to want to build a revision older than the switch, is that possible? Old change records seems to be messed up after this...
OS: Windows 10 Pro 64bit Creators Update
CPU: AMD Phenom II X4 960 @ 3.6 GHz
Graphics Card: Nvidia GeForce GTX 960 2GB GDDR5
Motherboard: Gigabyte GA-870A-USB3 AM3+ Revision
RAM: HyperX 8GB Dual Channel @ 1600Mhz
Find
Reply
08-21-2011, 02:58 AM
#4
neobrain Offline
"Wow, I made my code 1000x faster! That means I can make it 2048x slower now!"
**********
Developers (Some Administrators and Super Moderators)
Posts: 3,208
Threads: 50
Joined: Jun 2009
(08-21-2011, 02:27 AM)naoan Wrote: Anything to make developer's life easier Tongue

A question, by date does it include HH:MM: SS on the description? if so why not use that to identify/distribute the git build? Just a suggestion...

example output:
Code:
commit 91e9d272a9e20f0c042e463a9ac8c0b0847563c4
Author: Shawn Hoffman <godisgovernment@gmail.com>
Date:   Fri Aug 19 00:00:10 2011 -0700

    ignore *.ipch

So yeah, it would be a theoretical option. However, showing the commit info and copy-pasting the date (including the time, since there might be multiple commits within a day) is more work to do than just copy-pasting the hash Tongue also, it's more error prone and cumbersome for the devs to work with. With the hash, we can just look up the commit easily. With the date.. that won't work.
Again, this doesn't necessarily apply to the download list of the homepage, since we still haven't heard from mamario.
Rule of thumb: Use the hash and be done.
My blog
Me on Twitter
My wishlist on Amazon.de
Find
Reply
08-21-2011, 03:00 AM
#5
mbc07 Offline
Wiki Caretaker
*******
Content Creators (Moderators)
Posts: 3,562
Threads: 47
Joined: Dec 2010
And about the separate repositories (such as dolphin-cheats-database and dolphin-shaders-database)? They migrated to GIT too? And the issues and wiki pages of these repositories went to another place?
Avell A70 MOB: Core i7-11800H, GeForce RTX 3060, 16 GB DDR4-3200, Windows 11 (Insider Preview)
ASRock Z97M OC Formula: Pentium G3258, GeForce GT 440, 16 GB DDR3-1600, Windows 10 (22H2)
Find
Reply
08-21-2011, 03:03 AM
#6
neobrain Offline
"Wow, I made my code 1000x faster! That means I can make it 2048x slower now!"
**********
Developers (Some Administrators and Super Moderators)
Posts: 3,208
Threads: 50
Joined: Jun 2009
(08-21-2011, 02:33 AM)Runo Wrote: My main concern was how to give support in the forums, but since I heard you guys do not intend to have noobs using non release builds anymore, that should be no problem, plus the git description thing will do the trick when trying to track down bugs and feedbacking... Also I didn't realize that using the hash you cant go back any specific source state (revisions?), I was too stupid last night. As a suggestion, if you are really going to do this way, I think you should only make available to download in the site the stable builds or alphas, betas whatever. Whoever needs/wants another one will have a reason to be looking for that and therefore will know how to build. This would totally solve the support problem Smile.
Only problem with that: You can't make the noobs do the regression testing anymore if you don't provide any builds.

(08-21-2011, 02:33 AM)Runo Wrote: Also, I like the branches thing Tongue
If I ever happen to want to build a revision older than the switch, is that possible? Old change records seems to be messed up after this...
Just check out an older commit? That should work fine generally (and worked 5 seconds ago when I tried it Tongue).
e.g. git checkout master~20 will checkout the 20th commit before the most recent one in the master branch (master=main branch).
My blog
Me on Twitter
My wishlist on Amazon.de
Find
Reply
08-21-2011, 03:04 AM
#7
neobrain Offline
"Wow, I made my code 1000x faster! That means I can make it 2048x slower now!"
**********
Developers (Some Administrators and Super Moderators)
Posts: 3,208
Threads: 50
Joined: Jun 2009
(08-21-2011, 03:00 AM)Jhonn Wrote: And about the separate repositories (such as dolphin-cheats-database and dolphin-shaders-database)? They migrated to GIT too? And the issues and wiki pages of these repositories went to another place?

dolphin-cheats-database and dolphin-shaders-database are included in the main repository now. The Wiki pages habe been copied over. The issue list isn't stored in the repository at all.
My blog
Me on Twitter
My wishlist on Amazon.de
Find
Reply
08-21-2011, 03:13 AM (This post was last modified: 08-21-2011, 04:40 AM by Runo.)
#8
Runo Offline
Greeny
*******
Posts: 1,194
Threads: 43
Joined: Mar 2009
(08-21-2011, 03:03 AM)neobrain Wrote: Just check out an older commit? That should work fine generally (and worked 5 seconds ago when I tried it Tongue).
e.g. git checkout master~20 will checkout the 20th commit before the most recent one in the master branch (master=main branch).

All right, sorry for the stupid question there, I still haven't installed TortoiseGit, so I was asking blind back there, I will do it later. I saw the google code wasnt displaying all of the recent revisions in order so I thought...

About the testing thing, maybe mamario's site could label it then. I mean, not the build itself, but the download link, you know, you will see you are clicking in the download for revision xxxx. And than each time it builds a new one it increases the number by one and etc... That could solve it...

EDIT: I'm having some trouble with TortoiseGit, it's giving me a path error, I suspect I must direct it to git.exe, could anyone tell me how does this work?
OS: Windows 10 Pro 64bit Creators Update
CPU: AMD Phenom II X4 960 @ 3.6 GHz
Graphics Card: Nvidia GeForce GTX 960 2GB GDDR5
Motherboard: Gigabyte GA-870A-USB3 AM3+ Revision
RAM: HyperX 8GB Dual Channel @ 1600Mhz
Find
Reply
08-21-2011, 04:44 AM (This post was last modified: 08-21-2011, 04:45 AM by naoan.)
#9
naoan Offline
Senior Member
****
Posts: 570
Threads: 2
Joined: Jul 2009
(08-21-2011, 02:58 AM)neobrain Wrote:
(08-21-2011, 02:27 AM)naoan Wrote: Anything to make developer's life easier Tongue

A question, by date does it include HH:MM: SS on the description? if so why not use that to identify/distribute the git build? Just a suggestion...

example output:
Code:
commit 91e9d272a9e20f0c042e463a9ac8c0b0847563c4
Author: Shawn Hoffman <godisgovernment@gmail.com>
Date:   Fri Aug 19 00:00:10 2011 -0700

    ignore *.ipch

So yeah, it would be a theoretical option. However, showing the commit info and copy-pasting the date (including the time, since there might be multiple commits within a day) is more work to do than just copy-pasting the hash Tongue also, it's more error prone and cumbersome for the devs to work with. With the hash, we can just look up the commit easily. With the date.. that won't work.
Again, this doesn't necessarily apply to the download list of the homepage, since we still haven't heard from mamario.
Rule of thumb: Use the hash and be done.

Ah no, no, I mean in regard for svn/git builder like mamario to distribute his build, I imagine it'd be easier for him and testers alike.

As for how it looks on code.google I think you should not bother to change anything just to please users (we should not mess with it in the first place anyway, right?) as long as it works for developers. Smile
Find
Reply
08-21-2011, 08:52 AM
#10
Runo Offline
Greeny
*******
Posts: 1,194
Threads: 43
Joined: Mar 2009
Agreed.
OS: Windows 10 Pro 64bit Creators Update
CPU: AMD Phenom II X4 960 @ 3.6 GHz
Graphics Card: Nvidia GeForce GTX 960 2GB GDDR5
Motherboard: Gigabyte GA-870A-USB3 AM3+ Revision
RAM: HyperX 8GB Dual Channel @ 1600Mhz
Find
Reply
« Next Oldest | Next Newest »
Pages (8): 1 2 3 4 5 ... 8 Next »
Jump to page 


  • View a Printable Version
  • Subscribe to this thread
Forum Jump:


Users browsing this thread: 1 Guest(s)



Powered By MyBB | Theme by Fragma

Linear Mode
Threaded Mode