[Regression] Latest Dolphin improperly resets controllers between games

[Silent Hell]

The latest Dolphin appears to have a regression where it can't properly reset all of the analogue positions to zero, causing stick drift and light inputs on shields. This initially led me to believe that I had damaged my controllers when I was cleaning then. This affects a variety of games making them nigh unplayable unless you completely close dolphin.exe between games. Some examples are Mario constantly spraying water in Sunshine, strafing constantly in Bloody Roar, and Stick Drift in Melee. I am using the official Wii U Gamecube Adapter with WinUSB installed through Zadig. I have no idea if this affects other controllers at the moment or USB/Xinput controllers.

I initially used Melee 20XX to test my analogue values but Visual Controller Test works just as well.
Here are my results.

Dolphin 5.0-9751:
Original Gamecube Controller (1st Run)

Original Gamecube Controller (2nd Run)

Smash Ultimate Controller (1st Run)

Smash Ultimate Controller (2nd Run)

---

Dolphin 5.0 Stable:
Original Gamecube Controller (1st Run)

Original Gamecube Controller (2nd Run)

Smash Ultimate Controller (1st Run)

Smash Ultimate Controller (2nd Run)


The latest Ishiiruka build (add5cb3d1) produces similar results as the Stable built of 5.0.
I hope this issue gets resolved before 6.0 because it really does make some games unplayable if you forget to close dolphin between games. And this makes testing settings a pain to have to kill the process every time.

[Silent Hell]

Upon further testing with the bisection tool, I yielded interesting results. The first instance of the controller calibration being off was this revision. 5.0-9470

However, unlike the current issue, the controllers start off uncalibrated and are stuck with drift and trigger presses from the get go. So that would mean that another update "fixed" it, but then it uncalibrates upon switching games. I will look into this further to see if I can find the instance that the "fix" occurs.

EDIT: I have found the source of the issue. So as it would appear, revision 5.0-9470 changed the code so that the controller would be set to a "perfect" initial value, which also modified the way triggers worked somehow?
Then, revision 5.0-9494 attempted to restore the calibration behavior of the actual hardware, but wasn't able to fix it completely as it still occurs upon switching/restarting games.

It appears that these issues are also affected by this problem.
https://bugs.dolphin-emu.org/issues/11608
https://bugs.dolphin-emu.org/issues/11622

I would like to add that one user stated this issue affects Smash Ultimate controllers specifically. This is half true, Smash controllers are affected more by this issue, but it is still present in OG controllers.

[Helios]

Thanks for bisecting. That helps massively. I'll ping some people.

[Silent Hell]

Thanks! I'm glad I could expedite this issue. I honestly thought I broke my controllers while cleaning them.