QTDIR not set question

[JosJuice]

Okay, now we're down to a problem I'm familiar with

I'm not sure if Dolphin builds correctly with VS2017 anymore. If you happen to have 16.5 (a slightly older version of VS2019), that will work.

However, there is an even simpler solution. Instead of building using dolphin-emu.sln, build using CMake. Instructions for this are available at https://github.com/dolphin-emu/dolphin/wiki/Building-for-Windows

[charliee1151]

Holy Smokes, Batman.

I've never seen such a thing in my life!

I have 1 error and 7 warnings.


Error is in CMakeLists.txt, Line 9 = "find_package(Qt5 5.9 REQUIRED COMPONENTS Gui Widgets)"

Error:
------------------------------------------------------
CMake Error at Source/Core/DolphinQt/CMakeLists.txt:9 (find_package):
 By not providing "FindQt5.cmake" in CMAKE_MODULE_PATH this project has
 asked CMake to find a package configuration file provided by "Qt5", but
 CMake did not find one.

 Could not find a package configuration file provided by "Qt5" (requested
 version 5.9) with any of the following names:

   Qt5Config.cmake
   qt5-config.cmake

 Add the installation prefix of "Qt5" to CMAKE_PREFIX_PATH or set "Qt5_DIR"
 to a directory containing one of the above files.  If "Qt5" provides a
 separate development package or SDK, be sure it has been installed.
----------------------------------------

Is this requesting an install of QT? (note that I previously indicated that I have NOT installed it), although I don't see QT listed in the link you posted.

Charlie

[JosJuice]

The CMake build should work with just Dolphin's Qt submodule that you already have... I'm not sure why it's failing. If "Qt5_DIR" is set (I don't know if it is), you should unset it.

[charliee1151]

Nope, no QT5 anything in EnvironmentalVariables.

And, in CMakeLists.txt, the code attempts to point to the existing submodule anyway.

I'll keep looking.

Thanks

Charlie

EDIT: PS: There is no Dolphin.exe listed in the StartupItem list anyway. Possible due to the error?

EDIT#2: Found an errant(?) Build directory in the Dolphin folder. Deleted it, and reloaded from scratch. EXE file now showing in Select list. Building now. Stay tuned

[charliee1151]

As an FYI:
(Thought a new reply would be better than yet-again another edit)

I now have 1 error and 106 warnings.

But the error message is:
"Error C2220 the following warning is treated as an error"

It's in StringUtil.cpp, line 601:
" std::wstring_convert<std::codecvt_utf8_utf16<char16_t>, char16_t> converter;"

I see the "std" thingy again, wonder if it's related.

Oh well...
Charlie

[JosJuice]

Whelp, turns out that the Windows CMake build has been broken by a code change once again... I'll try to get that fixed.

[charliee1151]

Ah, there goes my sanity again!

I'll standby

C

[JosJuice]

This has now been fixed. If you have done nothing to the git repo other than "git clone --recursive", you should be able to update to the fixed version of the code with "git pull origin". Hopefully the build will work after that.

[charliee1151]

Success!  I am finally debugging and have just taken the first trace step to stop at "Int main(...)", which IS something I am familiar with.

(As an FYI, after updating the project as per the "git pull origin" stuff, I had major problems getting anything in VS to work.  I had to restart my PC)

General question now:

I believe that what we did was, starting from scratch:
1. Download the whole project via GIT
2. Find some bugs which necessitated some code fixes
3. Download JUST THE FIXES(?) via GIT

So:
1. Am I correct in step #2?
2. Does this mean if I were to dump the whole project and start again, the original download (ie: Step #1) would automatically pickup the fixes?  That is, is the project that is in GIT now fully updated so a future download should function the first time?

Of course, major thanks for your efforts.  

I'm off to learn now...who knows what dumb stuff I might pull in the future!!

Seriously, thanks to all who contributed to my success.

Charlie

[JosJuice]

(08-01-2020, 01:15 AM)charliee1151 Wrote: So:
1. Am I correct in step #2?
2. Does this mean if I were to dump the whole project and start again, the original download (ie: Step #1) would automatically pickup the fixes?  That is, is the project that is in GIT now fully updated so a future download should function the first time?

Yes and yes.