I get what you're saying about increasing the code complexity by offering enhancements that the original console never did, and it's a perfectly valid opinion. I know firsthand (in a way) how that goes. Adding support for custom graphics and arbitrarily scaled custom graphics in GB Enhanced has easily doubled the amount of code necessary to render a single scanline (at least it will when I'm finished). The code is commented thoroughly (at least I tried) but I fear that at this point it's just not intuitive anymore unless someone really takes the time to dissect what's happening line by line, an unfortunate consequence if anyone wants to continue or expand upon my work.
I will honestly tell you that my custom graphics code is not nice, and what with the hashing of tiles, keeping a list of updated tiles, keeping a list of updated hashes, discarding certain hashes, and more, it's not nearly as straightforward as making a regular GB emulator. Then there's the crazy plan I have to accommodate GBC fade in/fade out effects (involves brightening/darkening the custom graphics on a per-pixel basis given the current luminosity of the GBC color palette). So I very much understand your views and where you're coming from. Personally though, I've chosen to make these sacrifices to support this feature, and I do like the challenge :p
Obviously I'm somewhat on the other end of the spectrum of purists (I do love pursuing emulator accuracy since that is usually more challenging than anything else), but I do like that there are other people who aren't crazy about enhancements (hello Mednafen and its PS1 emulation). I mean, if no one paid much attention to making accurate emulators, that poses the risk of making only adequate emulators, and as a user myself of many emulators, I'll deal with a stable experience over an enhanced one.
I will honestly tell you that my custom graphics code is not nice, and what with the hashing of tiles, keeping a list of updated tiles, keeping a list of updated hashes, discarding certain hashes, and more, it's not nearly as straightforward as making a regular GB emulator. Then there's the crazy plan I have to accommodate GBC fade in/fade out effects (involves brightening/darkening the custom graphics on a per-pixel basis given the current luminosity of the GBC color palette). So I very much understand your views and where you're coming from. Personally though, I've chosen to make these sacrifices to support this feature, and I do like the challenge :p
Obviously I'm somewhat on the other end of the spectrum of purists (I do love pursuing emulator accuracy since that is usually more challenging than anything else), but I do like that there are other people who aren't crazy about enhancements (hello Mednafen and its PS1 emulation). I mean, if no one paid much attention to making accurate emulators, that poses the risk of making only adequate emulators, and as a user myself of many emulators, I'll deal with a stable experience over an enhanced one.